IntenseWebs/sphinx
3
0
Fork 0
mirror of https://github.com/sphinx-doc/sphinx.git synced 2025-02-25 18:55:22 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10263 from nicoa/escape_base_uri_in_extlinks

Browse Source 
escape base_uri in extlinks
This commit is contained in:
Takeshi KOMIYA
2022-03-28 00:06:22 +09:00
committed by GitHub
parent 8a1830ca36 81830cc770
commit 746df61452
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
sphinx/ext/extlinks.py
View File

@@ -18,6 +18,7 @@ Both, the url string and the caption string must escape ``%`` as ``%%``.
"""
import re
import sys
import warnings
from typing import Any, Dict, List, Tuple
@@ -65,7 +66,13 @@ class ExternalLinksChecker(SphinxPostTransform):
title = refnode.astext()
for alias, (base_uri, _caption) in self.app.config.extlinks.items():
uri_pattern = re.compile(base_uri.replace('%s', '(?P<value>.+)'))
if sys.version_info < (3, 7):
# Replace a leading backslash because re.escape() inserts a backslash before %
# on python 3.6
uri_pattern = re.compile(re.escape(base_uri).replace('\\%s', '(?P<value>.+)'))
else:
uri_pattern = re.compile(re.escape(base_uri).replace('%s', '(?P<value>.+)'))
match = uri_pattern.match(uri)
if match and match.groupdict().get('value'):
# build a replacement suggestion