IntenseWebs/sphinx
3
0
Fork 0
mirror of https://github.com/sphinx-doc/sphinx.git synced 2025-02-25 18:55:22 -06:00
Code Issues Packages Projects Releases Wiki Activity

refactor applehelp: Use shlex.quote() instead of pipes.quote()

Browse Source
This commit is contained in:
Takeshi KOMIYA 2019-01-11 01:22:02 +09:00
parent aa4d4917f7
commit bf62a96831
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sphinx/builders/applehelp.py
View File

@ -8,7 +8,6 @@
:license: BSD, see LICENSE for details. :license: BSD, see LICENSE for details.
""" """
import pipes
import plistlib import plistlib
import shlex import shlex
import subprocess import subprocess
@ -205,7 +204,7 @@ class AppleHelpBuilder(StandaloneHTMLBuilder):
if self.config.applehelp_disable_external_tools: if self.config.applehelp_disable_external_tools:
logger.info(__('skipping')) logger.info(__('skipping'))
logger.warning(__('you will need to index this help book with:\n %s'), logger.warning(__('you will need to index this help book with:\n %s'),
' '.join([pipes.quote(arg) for arg in args])) ' '.join([shlex.quote(arg) for arg in args]))
else: else:
try: try:
p = subprocess.Popen(args, p = subprocess.Popen(args,
@ -240,7 +239,7 @@ class AppleHelpBuilder(StandaloneHTMLBuilder):
if self.config.applehelp_disable_external_tools: if self.config.applehelp_disable_external_tools:
logger.info(__('skipping')) logger.info(__('skipping'))
logger.warning(__('you will need to sign this help book with:\n %s'), logger.warning(__('you will need to sign this help book with:\n %s'),
' '.join([pipes.quote(arg) for arg in args])) ' '.join([shlex.quote(arg) for arg in args]))
else: else:
try: try:
p = subprocess.Popen(args, p = subprocess.Popen(args,