Probably for accidental reasons, pdflatex and lualatex (but not platex
and xelatex) were configured with a blank line above the logo on title
page, below the top rule. This commit removes it.
The file ``pdfcolor.tex`` included in tex distributions is for Plain
pdfTeX, not for LaTeX use. Loading it complicates task of supporting
multiple TeX engines. If needed all corresponding colour names are
better available from passing to ``color`` or ``xcolor`` the
``dvipsnames`` option. It is better to leave responsability of using
this option to Sphinx user, if needed. The macros for setting the color
defined by ``pdfcolor.tex`` were never documented to Sphinx user, and
they can not be used from reST apart from ``.. raw:: latex`` directive,
they are for Plain TeX without use of ``color`` package. Thus, this
commit drops loading this file and the complicated conditionals around
it (``\ifsphinxpdfoutput``), which are also used in the class files
``sphinxmanual.cls``, ``sphinxhowto.cls``.
Also, this fixes issue #2693.
This reverts commit 7db8141238.
As discussed at
<https://github.com/sphinx-doc/sphinx/pull/2736#issuecomment-230140016>
platex and xelatex engines led to a slightly different title page layout
missing a blank line underneath the top rule (above the logo) compared
to pdflatex and lualatex. This was probably accidental.
All LaTeX commands such as \textbf, \emph, \underline.. are "short",
thus there was no need of ``\long`` prefix. Regarding
``\sphinxoptional`` which was defined via ``\newcommand``, the ``\long``
is there for full backwards compatibility, but a priori the argument
will always be a "short" one (i.e. not containing empty line or ``\par``
token.)
It prevents this bug:
```python
viewcode can't import None, failed with error "__import__() argument 1 must be str, not None"
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/sphinx/ext/viewcode.py", line 28, in _get_full_modname
return get_full_modname(modname, attribute)
File "/usr/local/lib/python3.5/dist-packages/sphinx/util/__init__.py", line 263, in get_full_modname
__import__(modname)
TypeError: __import__() argument 1 must be str, not None
```
The function is used from many builders which combines multiple
doctrees to single one (e.g. LaTeX, singlehtml and so on).
To deprecate it might cause big troubles for 3rd party builders.
So I withdraw the deprecation.
