mirror of
https://github.com/libvirt/libvirt.git
synced 2025-02-25 18:55:26 -06:00
virsh: Check whether enough arguments was passed to iothreadset
Virsh has iothreadset command which allows setting various attributes of IOThreads. However, when the command is called without any arguments (besides domain and IOThread IDs), then @params stays NULL and is passed to virDomainSetIOThreadParams() which produces rather user unfriendly error message: error: params in virDomainSetIOThreadParams must not be NULL Introduce a check and produce better error message. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Claudio Fontana <cfontana@suse.de>
This commit is contained in:
@@ -7853,6 +7853,11 @@ cmdIOThreadSet(vshControl *ctl, const vshCmd *cmd)
|
||||
|
||||
#undef VSH_IOTHREAD_SET_UINT_PARAMS
|
||||
|
||||
if (nparams == 0) {
|
||||
vshError(ctl, _("Not enough arguments passed, nothing to set"));
|
||||
goto cleanup;
|
||||
}
|
||||
|
||||
if (virDomainSetIOThreadParams(dom, id, params, nparams, flags) < 0)
|
||||
goto cleanup;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user