mirror of
https://github.com/libvirt/libvirt.git
synced 2026-10-02 12:20:06 -05:00
storagepoolxml2argvtest: Avoid double free
A double free may occur in testCompareXMLToArgvFiles() when @def is freed right after virStoragePoolObjNew() failed and the second time at cleanup label. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Erik Skultety <eskultet@redhat.com>
This commit is contained in:
1 parent
cb0c3a7066
commit
230243594e
1 file changed
-1
@@ -39,7 +39,6 @@ testCompareXMLToArgvFiles(bool shouldFail,
|
||||
case VIR_STORAGE_POOL_NETFS:
|
||||
if (!(pool = virStoragePoolObjNew())) {
|
||||
VIR_TEST_DEBUG("pool type '%s' alloc pool obj fails\n", defTypeStr);
|
||||
virStoragePoolDefFree(def);
|
||||
goto cleanup;
|
||||
}
|
||||
virStoragePoolObjSetDef(pool, def);
|
||||
|
||||
Reference in new issue
Block a user