NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2026-09-03 20:53:04 -05:00
Code Issues Packages Projects Releases Wiki Activity

conf: Fix virNodeDeviceObjGetNames nnames increment

Browse Source 
To be safer, only increment nnames after the VIR_STRDUP is successful.
This commit is contained in:
John Ferlan
2017-04-10 13:47:02 -04:00
parent fd6e3f48ed
commit 44d3db9785
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/conf/virnodedeviceobj.c
+2 -1
View File
@@ -512,10 +512,11 @@ virNodeDeviceObjGetNames(virNodeDeviceObjListPtr devs,
virNodeDeviceObjLock(obj);
if (aclfilter && aclfilter(conn, obj->def) &&
(!cap || virNodeDeviceObjHasCap(obj, cap))) {
if (VIR_STRDUP(names[nnames++], obj->def->name) < 0) {
if (VIR_STRDUP(names[nnames], obj->def->name) < 0) {
virNodeDeviceObjUnlock(obj);
goto failure;
}
nnames++;
}
virNodeDeviceObjUnlock(obj);
}