Fix closedir usage in virNumaGetPages

virNumaGetPages calls closedir(dir) in cleanup and dir could
be NULL if we jump there from the failed opendir() call.

While it's not harmful on Linux, FreeBSD libc crashes [1], so
make sure that dir is not NULL before calling closedir.

1: http://lists.freebsd.org/pipermail/freebsd-standards/2014-January/002704.html
This commit is contained in:
Roman Bogorodskiy
2014-06-23 19:25:59 +04:00
parent 60c343f688
commit 4a82ef92be
+2 -1
View File
@@ -843,7 +843,8 @@ virNumaGetPages(int node,
VIR_FREE(tmp_free);
VIR_FREE(tmp_avail);
VIR_FREE(tmp_size);
closedir(dir);
if (dir)
closedir(dir);
VIR_FREE(path);
return ret;
}