mirror of
https://github.com/libvirt/libvirt.git
synced 2026-08-19 01:24:42 -05:00
tests: Fix mode_t usage with va_arg()
Clang complains about it:
error: second argument to 'va_arg' is of promotable type
'mode_t' (aka 'unsigned short'); this va_arg has undefined
behavior because arguments will be promoted to 'int'
[-Werror,-Wvarargs]
mode = va_arg(ap, mode_t);
^~~~~~
Work around the issue by passing int to va_arg() and casting
its return value to mode_t afterwards.
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
+1
-1
@@ -87,7 +87,7 @@ open(const char *path, int flags, ...)
|
||||
va_list ap;
|
||||
mode_t mode;
|
||||
va_start(ap, flags);
|
||||
mode = va_arg(ap, int);
|
||||
mode = (mode_t) va_arg(ap, int);
|
||||
va_end(ap);
|
||||
ret = real_open(newpath ? newpath : path, flags, mode);
|
||||
} else {
|
||||
|
||||
@@ -731,7 +731,7 @@ int open(const char *path, int flags, ...)
|
||||
va_list ap;
|
||||
mode_t mode;
|
||||
va_start(ap, flags);
|
||||
mode = va_arg(ap, mode_t);
|
||||
mode = (mode_t) va_arg(ap, int);
|
||||
va_end(ap);
|
||||
ret = real_open(newpath ? newpath : path, flags, mode);
|
||||
} else {
|
||||
|
||||
+1
-1
@@ -983,7 +983,7 @@ open(const char *path, int flags, ...)
|
||||
va_list ap;
|
||||
mode_t mode;
|
||||
va_start(ap, flags);
|
||||
mode = va_arg(ap, mode_t);
|
||||
mode = (mode_t) va_arg(ap, int);
|
||||
va_end(ap);
|
||||
ret = real_open(newpath ? newpath : path, flags, mode);
|
||||
} else {
|
||||
|
||||
+1
-1
@@ -180,7 +180,7 @@ int open(const char *path, int flags, ...)
|
||||
va_list ap;
|
||||
mode_t mode;
|
||||
va_start(ap, flags);
|
||||
mode = va_arg(ap, mode_t);
|
||||
mode = (mode_t) va_arg(ap, int);
|
||||
va_end(ap);
|
||||
ret = real_open(path, flags, mode);
|
||||
} else {
|
||||
|
||||
Reference in New Issue
Block a user