mirror of
https://github.com/libvirt/libvirt.git
synced 2026-10-02 12:20:06 -05:00
qemuDomainManagedSaveDefineXML: Add top-level flag validation
The implementation for managed save uses 'qemuDomainSaveImageDefineXML' internally which validates the flags. To have a top level flag validation for the upcoming flag introspection export the supported flags as a macro and add a 'virCheckFlags' to 'qemuDomainManagedSaveDefineXML'. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
1 parent
7fbfb59938
commit
6a0e6a5502
1 file changed
+8
-2
@@ -6126,6 +6126,11 @@ qemuDomainSaveImageGetXMLDesc(virConnectPtr conn, const char *path,
|
||||
return ret;
|
||||
}
|
||||
|
||||
|
||||
#define QEMU_SAVE_IMAGE_DEFINE_FLAGS \
|
||||
VIR_DOMAIN_SAVE_RUNNING | \
|
||||
VIR_DOMAIN_SAVE_PAUSED
|
||||
|
||||
static int
|
||||
qemuDomainSaveImageDefineXML(virConnectPtr conn, const char *path,
|
||||
const char *dxml, unsigned int flags)
|
||||
@@ -6138,8 +6143,7 @@ qemuDomainSaveImageDefineXML(virConnectPtr conn, const char *path,
|
||||
virQEMUSaveData *data = NULL;
|
||||
int state = -1;
|
||||
|
||||
virCheckFlags(VIR_DOMAIN_SAVE_RUNNING |
|
||||
VIR_DOMAIN_SAVE_PAUSED, -1);
|
||||
virCheckFlags(QEMU_SAVE_IMAGE_DEFINE_FLAGS, -1);
|
||||
|
||||
if (flags & VIR_DOMAIN_SAVE_RUNNING)
|
||||
state = 1;
|
||||
@@ -6249,6 +6253,8 @@ qemuDomainManagedSaveDefineXML(virDomainPtr dom, const char *dxml,
|
||||
g_autofree char *path = NULL;
|
||||
int ret = -1;
|
||||
|
||||
virCheckFlags(QEMU_SAVE_IMAGE_DEFINE_FLAGS, -1);
|
||||
|
||||
if (!(vm = qemuDomainObjFromDomain(dom)))
|
||||
return -1;
|
||||
|
||||
|
||||
Reference in new issue
Block a user