mirror of
https://github.com/libvirt/libvirt.git
synced 2026-07-31 08:38:16 -05:00
qemuhotplugtest: Make the test more useful by validating used commands against QMP schema
qemuhotplugtest validates only that a given command is used but not the arguments of the command. With this patch we'll validate the arguments against the QMP schema thus we can catch possible issues with deprecated commands. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
@@ -57,6 +57,7 @@ struct qemuHotplugTestData {
|
||||
GHashTable *capsLatestFiles;
|
||||
GHashTable *capsCache;
|
||||
GHashTable *schemaCache;
|
||||
GHashTable *schema;
|
||||
};
|
||||
|
||||
static int
|
||||
@@ -342,7 +343,7 @@ testQemuHotplug(const void *data)
|
||||
if (qemuHotplugCreateObjects(driver.xmlopt, &vm, domain_xml,
|
||||
test->arch, test->capsLatestFiles,
|
||||
test->capsCache, test->schemaCache,
|
||||
NULL) < 0)
|
||||
&test->schema) < 0)
|
||||
goto cleanup;
|
||||
}
|
||||
|
||||
@@ -356,7 +357,7 @@ testQemuHotplug(const void *data)
|
||||
|
||||
/* Now is the best time to feed the spoofed monitor with predefined
|
||||
* replies. */
|
||||
if (!(test_mon = qemuMonitorTestNew(driver.xmlopt, vm, NULL, NULL)))
|
||||
if (!(test_mon = qemuMonitorTestNew(driver.xmlopt, vm, NULL, test->schema)))
|
||||
goto cleanup;
|
||||
|
||||
tmp = test->mon;
|
||||
|
||||
Reference in New Issue
Block a user