mirror of
https://github.com/libvirt/libvirt.git
synced 2026-09-03 20:53:04 -05:00
Fix leak on OOM in qemuBuildCommandLine dealing with sound card
The qemuBuildCommandLine code for parsing sound cards will leak an intermediate variable if an OOM occurs. Move the free'ing of the variable earlier to avoid the leak. Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
@@ -9102,7 +9102,7 @@ qemuBuildCommandLine(virConnectPtr conn,
|
||||
goto error;
|
||||
|
||||
virCommandAddArg(cmd, str);
|
||||
|
||||
VIR_FREE(str);
|
||||
if (sound->model == VIR_DOMAIN_SOUND_MODEL_ICH6 ||
|
||||
sound->model == VIR_DOMAIN_SOUND_MODEL_ICH9) {
|
||||
char *codecstr = NULL;
|
||||
@@ -9130,8 +9130,6 @@ qemuBuildCommandLine(virConnectPtr conn,
|
||||
VIR_FREE(codecstr);
|
||||
}
|
||||
}
|
||||
|
||||
VIR_FREE(str);
|
||||
}
|
||||
}
|
||||
} else {
|
||||
|
||||
Reference in New Issue
Block a user