mirror of
https://github.com/libvirt/libvirt.git
synced 2026-07-29 15:54:48 -05:00
virExec: fix logic bug
As pointed out in https://bugzilla.redhat.com/show_bug.cgi?id=659855#c9,
commit c3568ec2 introduced a regression where we no longer close any
fd's beyond FD_SETSIZE.
* src/util/util.c (__virExec): Continue to close fd's beyond
keepfd range.
Reported by Stefan Praszalowicz.
This commit is contained in:
+1
-1
@@ -570,7 +570,7 @@ __virExec(const char *const*argv,
|
||||
i != null &&
|
||||
i != childout &&
|
||||
i != childerr &&
|
||||
(!keepfd || (i < FD_SETSIZE && !FD_ISSET(i, keepfd)))) {
|
||||
(!keepfd || i >= FD_SETSIZE || !FD_ISSET(i, keepfd))) {
|
||||
tmpfd = i;
|
||||
VIR_FORCE_CLOSE(tmpfd);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user