Michal Privoznik
26a137093b
tools: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:59 +01:00
Michal Privoznik
4fa804c0c7
tests: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:59 +01:00
Michal Privoznik
06030f05bb
vz: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
3bfb359944
vmx: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
adca67448e
vmware: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
24d213b03c
vbox: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
837f5619e7
secret: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
91d88aaf23
util: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
ad1118ebd2
test: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
930cae510b
storage: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
2e9fe8b9a7
security: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
c684b3c7e8
rpc: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
2b41a017ab
remote: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
d4e5b98330
qemu: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
183a60aa75
phyp: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
e5caed83bd
openvz: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
c09b0fe7a7
nwfilter: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
7847f011b0
node_device: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
52a6b45e18
network: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
c2d0db54df
lxc: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
862d06df94
logging: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
b1d58418aa
locking: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
f9d6b01262
libxl: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
9a2454bbc4
interface: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
5858950a85
hyperv: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
8cc297932a
esx: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
2b3061f2a1
cpu: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
daeeb3603d
conf: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
89b6825189
bhyve: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
87af7ff8b7
access: Use g_strdup_printf() instead of virAsprintf()
...
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 16:15:58 +01:00
Michal Privoznik
492d7cb47a
src: Wrap long lines in Makefiles
...
In my previous commit of v5.9.0-83-g4ae7181376 I've fixed
check-aclrules but whilst doing so, I forgot to wrap long
lines that I've added.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
2019-11-12 16:07:41 +01:00
Pavel Hrdina
0c59ca9eae
spec: fix vpath build on RHEL 7
...
Macro _vpath_builddir is not defined so we have to define it ourselves.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com >
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com >
2019-11-12 15:21:56 +01:00
Michal Privoznik
f4eb27a9b4
make check-driverimpls work again
...
Previously we generated all source files into $srcdir which is no
longer true. This means that we can't just blindly prepend each
source file with $srcdir.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com >
2019-11-12 15:00:01 +01:00
Michal Privoznik
4ae7181376
src: Make check-aclrules work again
...
Previously we generated all source files into $srcdir which is no
longer true. This means that we can't just blindly prepend each
source file with $srcdir.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com >
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com >
2019-11-12 15:00:01 +01:00
Peter Krempa
6245296f05
conf: capabilities: Modernize virCapabilitiesFormatMemoryBandwidth
...
Use virXMLFormatElement and the automatic memory handlers to simplfy the
code.
Signed-off-by: Peter Krempa <pkrempa@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com >
2019-11-12 14:37:59 +01:00
Peter Krempa
3ca2bdefa5
conf: caps: Modernize virCapabilitiesFormatCaches
...
Use automatic memory freeing and use virXMLFormatElement instead of open
coding it.
Signed-off-by: Peter Krempa <pkrempa@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 14:37:59 +01:00
Peter Krempa
fa7e8bb824
conf: turn virDomainMemtuneFormat void
...
Signed-off-by: Peter Krempa <pkrempa@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 14:37:59 +01:00
Peter Krempa
a06c856d43
conf: domain: Split up formatting of <memtune> and <memoryBacking>
...
Signed-off-by: Peter Krempa <pkrempa@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 14:37:59 +01:00
Peter Krempa
7596df34b4
conf: caps: Automaticaly free 'cpus_str'
...
Signed-off-by: Peter Krempa <pkrempa@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 14:37:59 +01:00
Peter Krempa
d95eded4bb
conf: Rename virDomainCapsFeature to virDomainProcessCapsFeature
...
The enum name sounds too generic. It in fact describes the capabilities
of the process, thus add 'Process' to the name.
Signed-off-by: Peter Krempa <pkrempa@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 14:37:59 +01:00
Peter Krempa
2ac56edbf8
conf: storagecaps: Fix broken attempt at being const-correct
...
The code formatting storage capabilities faithfully copied the wrong use
of 'const' from domain capabilities.
Signed-off-by: Peter Krempa <pkrempa@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com >
2019-11-12 14:37:57 +01:00
Peter Krempa
f118a00342
conf: domaincaps: Fix broken attempt at being const-correct
...
'virBlahPtr const blah' results into modification to the value of 'blah'
triggering compilation error rather than the modification of the virBlah
struct the pointer points to.
All of the domain capability formatting code was broken in this regard.
Signed-off-by: Peter Krempa <pkrempa@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 14:37:56 +01:00
Peter Krempa
6b9f2e8847
qemu: caps: Make capability filler functions void
...
Most of them don't have anything to report so we can simplify the logic.
Signed-off-by: Peter Krempa <pkrempa@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com >
2019-11-12 14:37:55 +01:00
Peter Krempa
e60174fb3a
qemu: caps: Rework memory allocation in virQEMUCapsFillDomainFeatureSEVCaps
...
Use g_new0 instead of VIR_ALLOC to avoid error cases.
Signed-off-by: Peter Krempa <pkrempa@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com >
2019-11-12 14:37:49 +01:00
Yi Li
94af82b936
storage: improve the while loop virStorageBackendFileSystemIsMounted
...
Move virStorageBackendFileSystemGetPoolSource outside of the while loop
Signed-off-by: Yi Li <yili@winhong.com >
Signed-off-by: Ján Tomko <jtomko@redhat.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 13:56:47 +01:00
Mao Zhongyi
f62f729b42
qemu: remove duplicate header files
...
"#include vircgroup.h" appears in both qemu_cgroup.h and
qemu_cgroup.c, and qemu_cgroup.c contains qemu_cgroup.h,
so remove the duplicate declarations.
Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com >
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 13:45:31 +01:00
Mao Zhongyi
d4aecbf1ff
lxc: remove duplicate header files
...
"#include vircgroup.h" appears in both lxc_cgroup.h and
lxc_cgroup.c, and lxc_cgroup.c contains lxc_cgroup.h,
so remove the duplicate declarations.
Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com >
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com >
Reviewed-by: Ján Tomko <jtomko@redhat.com >
2019-11-12 13:45:31 +01:00
Peter Krempa
8a2c37c4f6
qemu: snapshot: split out preparation of a snapshot with blockdev
...
Separate the blockdev code since it makes the original function lengthy.
Signed-off-by: Peter Krempa <pkrempa@redhat.com >
ACKed-by: Eric Blake <eblake@redhat.com >
2019-11-12 08:51:50 +01:00
Peter Krempa
3e2e627287
qemu: command: Use XML based disk bus convertor in error message
...
The qemu driver has an internal implementation for converting disk bus
to string for use with qemu. This should not be used in error messages
though as we want to report the string based on the XML value.
Signed-off-by: Peter Krempa <pkrempa@redhat.com >
ACKed-by: Eric Blake <eblake@redhat.com >
2019-11-12 08:51:50 +01:00
Peter Krempa
53b402f70c
syms: Add 'global:' keyword to LIBVIRT_5.8 section
...
Signed-off-by: Peter Krempa <pkrempa@redhat.com >
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com >
2019-11-12 08:51:50 +01:00