NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2026-09-03 20:53:04 -05:00
Code Issues Packages Projects Releases Wiki Activity
23,519 Commits 67 Branches 733 Tags
4808ebdef61e4c03ccfa310be2914e9d42ce63d9
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Ján Tomko 4808ebdef6 test-wrap-argv: set cutoff at 78 characters 
For every but the last argument, we also need space for a space
and a backslash.

Rewrap everything longer than 78 characters.
 2016-07-12 12:35:41 +02:00
Ján Tomko a5dace965a test-wrap-argv: print diff instead of the incorrectly wrapped file 
Commit c9c03ea stopped creating an intermediate file during syntax-check
to save on execution time. It also switched to outputting the whole
incorrectly wrapped file instead of a diff needed to fix it.

Feed the newly wrapped file to diff via a pipe.

Note that fixing it by running test-wrap-argv.pl --in-place or
the unit test with VIR_TEST_REGENERATE_OUTPUT is easier.
 2016-07-12 12:15:50 +02:00
Ján Tomko cc04181a7c testutils: only rewrap args files 
test-wrap-argv.pl does not know how to rewrap other files.
 2016-07-12 12:15:50 +02:00
Ján Tomko bd6708a862 testutils: find perl early 
Commit 843a70a changed test-wrap-argv.pl to use
/usr/bin/env perl
instead of
/usr/bin/perl

However when called from qemuxml2argvtest with
VIR_TEST_REGENERATE_OUTPUT, PATH is set to '/bin'.

Find the path to perl early in virTestMain, in case we
are going to need it later after we've overridden PATH.
 2016-07-12 12:15:50 +02:00
Ján Tomko 45ff2362e4 qemuxml2argvtest: drop empty pseries-vio-address-clash.args 
Unused since its introduction in commit 4b942fe.
 2016-07-12 12:15:50 +02:00
Ján Tomko aa7bb4f36d examples: check asprintf return value in client_info.c 
On error, asprintf returns -1 and the contents of the string
pointer is undefined. In the rest of the libvirt code,
the virAsprintf wrapper takes care of that.

Check the return value and report a generic error, since we
purposefully avoid linking to virutil.
 2016-07-01 15:39:01 +02:00
Ján Tomko 492b3bfda1 Introduce virDomainUSBDeviceDefForeach 
A helper that will execute a callback on every USB device
in the domain definition.

With an ability to skip USB hubs, since we will want to treat
them differently in some cases.
 2016-07-01 12:25:18 +02:00
Ján Tomko 3681e0a9fe Add USB addresses to qemuhotplug test cases 
This test assumes the XML will be the same after formatting.
Add USB addresses to it to keep it working when we autoassign them.
 2016-07-01 12:25:18 +02:00
Ján Tomko a3f565b339 Fix possible invalid read in adminClientGetInfo 
virNetServerClientGetInfo returns the client's remote address
as a string, which is a part of the client object.

Use VIR_STRDUP to make a copy which can be freely accessed
even after the virNetServerClient object is unlocked.

To reproduce, put a sleep between virObjectUnlock in
virNetServerClientGetInfo and virTypedParamsAddString in
adminClientGetInfo, then close the queried connection during
that sleep.
 2016-06-29 16:13:12 +02:00
Ján Tomko 05eab47559 Revert "util: new function virNetDevIPInfoAddToDev" 
This reverts commit f1e0d0da11.

This feature was accidentally pushed in the feature freeze.
 2016-06-27 12:54:55 +02:00
Ján Tomko f6acf039f0 Revert "conf: allow setting peer address in <ip> element of <interface>" 
This reverts commit 93135abf14.

This feature was accidentally pushed in the feature freeze.
 2016-06-27 12:54:55 +02:00
Ján Tomko d658456530 Revert "conf: support host-side IP/route information in <interface>" 
This reverts commit fe6a77898a.

This feature was accidentally pushed in the feature freeze.
 2016-06-27 12:54:55 +02:00
Ján Tomko cba06aea8d Revert "util: support setting peer for virNetDevIPInfo addresses" 
This reverts commit cb20f989df.

This feature was accidentally pushed in the feature freeze.
 2016-06-27 12:54:55 +02:00
Ján Tomko 1549f16832 Revert "lxc: support setting host-side IP addresses/routes" 
This reverts commit cd5c9f21de.

This feature was accidentally pushed in the feature freeze.
 2016-06-27 12:54:55 +02:00
Ján Tomko 84d47a3cce Revert "qemu: support setting host-side IP addresses/routes" 
This reverts commit 0b4645a7e0.

This feature was accidentally pushed in the feature freeze.
 2016-06-27 12:54:55 +02:00
Ján Tomko b7200d7236 build: increase xz compression level 
Increase the default compression level to 9 from 6.

This also increases decompression memory requirements
from 9 MB to 65 MB.

Also turn on verbosity.
 2016-06-24 16:41:57 +02:00
Ján Tomko 9beb299554 openvz: do not open-code STRSKIP 
Remove one more use of STREQLEN with strlen as its argument.
 2016-06-24 16:30:55 +02:00
Ján Tomko 83066f99a9 Fix error detection in virStorageBackendISCSIGetHostNumber 
In the unlikely case the iSCSI session path exists, but does not
contain an entry starting with "target", we would silently use
an initialized value.

Rewrite the function to correctly report errors.
 2016-06-24 16:30:55 +02:00
Ján Tomko 0f79480b9f Replace some uses STREQLEN with STRPREFIX 
Do not call it with a magic constant matching the length
of the pattern.
 2016-06-24 16:30:55 +02:00
Ján Tomko 290f2adf46 virStorageBackendISCSIGetHostNumber: correctly use virDirOpen 
Incorrect conflict resolution in my commit e81de04c1 broke this.
 2016-06-24 14:51:35 +02:00
Ján Tomko 32d0a57812 Prohibit opendir in syntax-check 
Prefer virDirOpen.
 2016-06-24 14:20:57 +02:00
Ján Tomko 994b024624 Use virDirOpenQuiet 
Remove all the remaining usage of opendir.
 2016-06-24 14:20:57 +02:00
Ján Tomko 7a5df06e10 Introduce virDirOpenQuiet 
A helper function that does not report any errors.
 2016-06-24 14:20:57 +02:00
Ján Tomko 42b4a37d68 Use virDirOpenIfExists 
Use it instead of opendir everywhere we need to check for ENOENT.
 2016-06-24 14:20:57 +02:00
Ján Tomko 941ccbc174 Add virDirOpenIfExists 
Just like virDirOpen, but it returns 0 without reporting an error
on ENOENT.
 2016-06-24 14:20:57 +02:00
Ján Tomko e81de04c10 Use virDirOpen 
Switch from opendir to virDirOpen everywhere we need to report an error.
 2016-06-24 14:20:57 +02:00
Ján Tomko f0ced7086a Introduce virDirOpen 
A helper that calls opendir and reports an error if it fails.
 2016-06-24 14:20:57 +02:00
Ján Tomko 16d77fc6b5 openvz: split single-line if 
Put the 'continue' statement on a separate line.
 2016-06-24 10:36:12 +02:00
Ján Tomko 541bd183f7 Rename virNetClient*AddrString 
Add SASL at the end to make the format obvious.
 2016-06-23 22:31:20 +02:00
Ján Tomko eaf7ff3873 Rename virNetServerClient*AddrString 
Add SASL at the end to make the format obvious.
 2016-06-23 22:23:21 +02:00
Ján Tomko ea537e7b36 Add SASL to virNetSocket{Local,Remote}AddrString 
Rename them to virNetSocket{Local,Remote}AddrStringSASL
to make their format more obvious.
 2016-06-23 22:23:21 +02:00
Ján Tomko dbce70b243 virNetSocket: rename AddrStr to AddrStrSASL 
Make it more obvious that these are in the SASL format.
 2016-06-23 22:23:21 +02:00
Ján Tomko 42362c9166 virnetsockettest: fix error messages 2016-06-23 22:23:21 +02:00
Ján Tomko 23b6559d65 Introduce virNetServerClientRemoteAddrStringURI 
Use it in virNetServerClientGetInfo to switch back to using
the URI-format (separated by ':') instead of the SASL format
(separated by ';').

Also use it in the error message reported by virNetServerAddClient.
 2016-06-23 22:23:02 +02:00
Ján Tomko 2da6a13e5f Introduce virNetSocketRemoteAddrStringURI 
It will return the socket address and port in a URI-like
format: [::1]:1234
Add a test case to virnetsockettest.
 2016-06-23 22:21:36 +02:00
Ján Tomko 0f7eeb20ad Revert "virnetsocket: Provide socket address format in a more standard form" 
This partially reverts commit 9b45c9f049.

It changed the default format of socket address from the one SASL
requires, but did not adjust all the callers.

It also removed the test coverage for it.

Revert most of the changes except the virSocketAddrFormatFull support
for URI-formatted strings.

This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1345743 while
reverting the format used by virt-admin's client-info command from
the URI one to the SASL one.

https://bugzilla.redhat.com/show_bug.cgi?id=1345743
 2016-06-23 22:15:06 +02:00
Ján Tomko 6d7ba87359 Do not skip files starting with a dot in leases directory 
'.' and '..' are skipped by virDirRead already.
 2016-06-23 21:58:38 +02:00
Ján Tomko 5217fe3db4 Allow configs to start with a dot 
This fixes the disappearance of domains and networks starting with a
dot.

https://bugzilla.redhat.com/show_bug.cgi?id=1333248
 2016-06-23 21:58:38 +02:00
Ján Tomko dad2f010b0 Do not skip hidden entries when looking for a stable path 
The device names are unlikely to start with a dot.
'.' and '..' are already skipped by virDirRead.
 2016-06-23 21:58:38 +02:00
Ján Tomko 70a033ab42 Do not ignore hidden files in /sys and /proc 
The directories we iterate over are unlikely to contain any entries
starting with a dot, other than '.' and '..' which is already skipped
by virDirRead.
 2016-06-23 21:58:38 +02:00
Ján Tomko 852cd39830 Fix comment in virStorageBackendFileSystemRefresh 
'.' and '..' are now skipped by virDirRead, there's no need to mention
them in the comment.
 2016-06-23 21:58:38 +02:00
Ján Tomko fe79c3f2c1 Do not check for '.' and '..' after virDirRead 
It skips those directory entries.
 2016-06-23 21:58:38 +02:00
Ján Tomko 7cecfba139 Skip '.' and '..' in virDirRead 
All of the callers either skip these explicitly, skip all entries
starting with a dot or match the entry name against stricter patterns.
 2016-06-23 21:58:38 +02:00
Ján Tomko a4e6f1eb9c Introduce VIR_DIR_CLOSE 
Introduce a helper that only calls closedir if DIR* is non-NULL
and sets it to NULL afterwards.
 2016-06-23 21:58:33 +02:00
Ján Tomko 44f5b3f869 Do not check the return value of closedir 
The only possible error is EBADFD.
Since we only use the directory stream returned by opendir,
this should never happen.
 2016-06-23 21:57:45 +02:00
Ján Tomko b914530d62 Do not save errno in virUSBDeviceSearch 
The virUSBDeviceFind* callers do not check errno after calling
this function.
 2016-06-23 21:37:32 +02:00
Ján Tomko 43d2b6f2aa prohibit-duplicate-header: print file name and line 
This way :make syntax-check in ViM will point you at the offending line.
 2016-06-23 12:48:40 +02:00
Ján Tomko a9179d78bf syntax-check: rewrite prohibit-duplicate-header in perl 
Invoke the script only once instead of once for every file.
 2016-06-23 12:48:40 +02:00
Ján Tomko 21b56a6055 Do not ignore perl scripts in build-aux 
Also remove the duplicate build-aux entry from .gitignore.
 2016-06-23 09:38:13 +02:00
Ján Tomko 8b04ce598d Add newDomain parameter to qemuDomainAssignAddresses 
Pass 'true' if we are not dealing with a migration.
 2016-06-23 07:45:31 +02:00
Ján Tomko b3ee621e94 Add a USB hub to controller order test 
The test has too many USB devices.
 2016-06-23 07:45:31 +02:00
Ján Tomko a921699ad9 Use for instead of code duplication when parsing USB port 
We are done if the string ends and move to another nesting
level if we find a dot.
 2016-06-22 21:33:57 +02:00
Ján Tomko 0956d9b2a3 Split out USB port parsing 
Make rewriting it easier.
 2016-06-22 21:33:57 +02:00
Ján Tomko e9843279cc Add a test for long USB port paths 
We support up to four levels of nested USB devices in the guest.

Add a test for a domain using all four and a negative test for a domain
using five.
 2016-06-22 21:33:57 +02:00
Ján Tomko 8b3f0b767e Do not call postParse with ABI_UPDATE when parsing cmdline 
So far this is only useful for recalculating NUMA memory size,
which this function cannot parse.

This will let us generate USB addresses based on this flag.
 2016-06-21 18:23:56 +02:00
Ján Tomko f17a49564a Fix USB port in input-usbmouse test 
The default USB controller only has two ports.
 2016-06-21 18:23:56 +02:00
Ján Tomko c9c03ea24d test-wrap-argv: add --check parameter 
This script can already operate on a list of files.
Add a --check parameter to check if multiple files are wrapped
correctly with a single invocation of the script.
 2016-06-21 18:13:07 +02:00
Ján Tomko f46fb819a9 test-wrap-argv: add --in-place parameter 
If --in-place is supplied as the first argument to the script,
replace the file in-place instead of printing to stdout.
 2016-06-21 18:13:07 +02:00
Ján Tomko b0590a53a5 test-wrap-argv: hold a copy of the original file in an array 
This will be useful to check if the file is wrapped already.
 2016-06-21 18:13:07 +02:00
Ján Tomko 80880fd4af test-wrap-argv: return a string in rewrap_line 
Leave the printing up to &rewrap.
 2016-06-21 18:13:07 +02:00
Ján Tomko c8da1cbf13 test-wrap-argv: use map and join instead of a for cycle 
We have a list of parameters in @args, that need to be rewrapped
and separated by a space and escaped newline: " \\\n", with the
exception of the last one, which only needs a newline.

Instead of a for cycle, rewrap the individual arguments using map,
and interleave them with escaped newlines by using join.
 2016-06-21 18:13:07 +02:00
Ján Tomko 2f071f1fca test-wrap-argv: return a string in rewrap_arg 
Do not print anything, let the caller take care of it.
 2016-06-21 18:13:07 +02:00
Ján Tomko 5e6185eee6 test-wrap-argv: split out rewrap_arg 
Split out the code wrapping the single argument.
 2016-06-21 18:13:07 +02:00
Ján Tomko a615a2fa58 test-wrap-argv: split out rewrap_line 
Shorten the rewrap subroutine by splitting out the code
dealing with a single line.

Also remove $file from the warning.
 2016-06-21 18:13:07 +02:00
Ján Tomko 8ebf780e08 vsh: remove namespace poisoning 
We already have a syntax-check to prohibit direct use of these
allocation functions.
 2016-06-21 18:07:25 +02:00
Ján Tomko d0e5dd376f vbox: remove duplicate macros 
There is a definiton of VIR_FROM_THIS just two lines above.

The rest is defined in vbox_common.h.
 2016-06-21 18:07:25 +02:00
Ján Tomko 8ddf58f5a1 Remove unused SOL_NETLINK macro 
Introduced by commit d575679, unused at the time.
 2016-06-21 18:07:11 +02:00
Ján Tomko a1e1679c8a Mark virsh-optparse as expensive 2016-06-20 18:16:50 +02:00
Ján Tomko 031b477b16 Drop virrandomtest 
This test only checks if mocking of virRandomBytes works correctly.

Drop it to avoid infinite recursion by testing the test suite.
 2016-06-20 18:16:50 +02:00
Ján Tomko 79d3fc855c Remove virsh-synopsis 
This tests checks that the first word after SYNOPSIS
in virsh help ${command} output is ${command}.

This was only good to check that the command option structures
are valid, which is now served by 'virsh self-test'.
 2016-06-20 18:16:50 +02:00
Ján Tomko 920ab8bdce Introduce virsh self-test 
A new hidden command for virsh that will iterate over
all command groups and commands and print help for every single one.

This involves running vshCmddefOptParse so we can get an error if
one of the command's option structure is invalid.
 2016-06-20 18:16:33 +02:00
Ján Tomko 743bda062b tests: mock gnutls_dh_params_generate2 
This function generates some big random numbers.

Cache the result and supply it to any subsequent generate2 calls.
 2016-06-20 18:12:53 +02:00
Ján Tomko 9f95593d60 Remove virsh-all 
Since e8ac4a7 this test wastes some CPU cycles by blindly trying to
run almost every virsh command, blindly throwing away the output
and the return value and returning success if 'virsh help' successfully
returned at least one command.

Drop it completely.
 2016-06-20 18:04:44 +02:00
Ján Tomko 0cd5a726e3 Allow disjunct ranges in VIR_TEST_RANGE 
Use virBitmapParseUnlimited to parse the env variable.
 2016-06-20 12:09:52 +02:00
Ján Tomko dc56b3a7ce Introduce virBitmapParseUnlimited 
For parsing a bitmap of an unknown size.
 2016-06-20 12:09:52 +02:00
Ján Tomko ff52e9d43a Remove separator argument from virBitmapParse 
Most the callers pass 0 in one form or another, including
vircapstest which used VIR_ARCH_NONE.
 2016-06-20 12:09:52 +02:00
Ján Tomko d728689d9b Introduce virBitmapParseSeparator 
This will be used for the caller that needs to specify a separator.
Currently identical to virBitmapParse.

Also change one test case to use the new function.
 2016-06-20 12:09:39 +02:00
Ján Tomko ba7c026dab Do not return number of set bits in virBitmapParse 
This is only used by one caller.
 2016-06-20 12:07:16 +02:00
Ján Tomko 22d262c9b0 qemu: restore non-pci hostdev labels after detach 
Commit 409de00 changed the logic to only match PCI devices
while moving this before Remove*HostDevice calls.

https://bugzilla.redhat.com/show_bug.cgi?id=1342874
 2016-06-17 19:43:22 +02:00
Ján Tomko d41d18bcdc Remove stray space in cmdHelp 2016-06-17 19:39:25 +02:00
Ján Tomko b7c70a0ba0 configure: remove definition of HAVE_GLIBC_RPCGEN 
Unused since commit fb1e8d9 in May 2011.
 2016-06-17 15:35:46 +02:00
Ján Tomko c5be15ef42 configure: error out when asked for mpath on non-Linux 2016-06-17 15:35:46 +02:00
Ján Tomko 7303e7079c configure: define preprocessor macros for SCSI and MPATH 
This fixes building these backends when explicitly enabled
on the command line.

Exposed by commit a659559 which started adding
--with-storage-mpath in the spec file.

https://bugzilla.redhat.com/show_bug.cgi?id=1346724
 2016-06-17 15:35:46 +02:00
Ján Tomko 3a9d1f3701 syntax-check: drop prohibit_undesirable_word_seq 
This checks forbids using "can not" and checks the placement
of some texinfo tags.

Drop it since we do not use texinfo and the check takes almost
twice as much as the rest of the checks.
 2016-06-16 07:57:53 +02:00
Ján Tomko 3cc13e005d check-spacing: fix error message 
The check for whitespace before comma or semicolon referred
to comma as colon.
 2016-06-15 16:05:08 +02:00
Ján Tomko cab2b44d8b check-spacing: use non-capturing groups 2016-06-15 15:48:33 +02:00
Ján Tomko 633daa4c57 check-spacing: remove virAssertCmpInt exception 
The macro is now called testAssertEq and no longer
takes an operator as its argument.
 2016-06-15 15:48:33 +02:00
Ján Tomko a2762b93fd check-spacing: simplify keyword spacing check 
We do not need a separate check forbidding whitespace
after the opening parenthesis after a keyword -
we forbid it after all of them.

The only allowed whitespace after an opening parenthesis
is a newline, tune the regex to reflect that.
 2016-06-15 15:48:32 +02:00
Ján Tomko cdf84bf1a8 check-spacing: rewrite regex for checking the closing parenthesis 
Instead of matching multiple characters before the parenthesis,
only check for a single whitespace, which is much less cpu-intensive.

This only matches a few dozen of places where they are on an separate
line, filter out those with a separate regex.
 2016-06-15 15:47:32 +02:00
Ján Tomko b953e163ad check-spacing: rewrite whitespace check before (semi)colon 
Instead of matching multiple characters, match any occurrence
preceded by a single whitespace and handle the exceptions
later.
 2016-06-15 15:07:47 +02:00
Ján Tomko 4e1a7dbb31 Rename bracket-spacing.pl to check-spacing.pl 
We test whitespace with lots of other characters now.
 2016-06-15 15:07:47 +02:00
Ján Tomko b918d76fd6 Rename virAssertCmpInt to testAssertEq 
Drop the op parameter, we only use equality.
Drop the vir prefix since it's only used in the tests.
 2016-06-15 15:07:47 +02:00
Ján Tomko b9df355592 maint: remove whitespace from closing parentheses 
To allow tightening syntax check.
 2016-06-15 15:07:47 +02:00
Ján Tomko ca773b2fe2 vbox: reformat multi-line error reports 
Put the comma on the first line.
 2016-06-15 15:07:47 +02:00
Ján Tomko e26098a1f4 cfg.mk: use a single regex for all non-reentrant functions 
The prohibit_nonreentrant syntax-check rule spawns a new shell
for every non-reentrant function we know, to make it easier
to mention the function name in the error message, with the _r
appended.

Since the line with the offending function is already printed
and some of the functions on our list do not have a _r counterpart,
compile them into one big regex and use a more generic error message
to save time.
 2016-06-15 15:00:56 +02:00
Ján Tomko e347e732bb docs: document rng backend path restrictions of older libvirt 
Commit 67f2b72 removed the path restrictions for rng backend,
along with the documentation of the restriction.

Restore the documentation for users still using older libvirt.

https://bugzilla.redhat.com/show_bug.cgi?id=1074464
 2016-06-15 12:36:53 +02:00
Ján Tomko 378ef3df57 Fix typo in virNetDevGetEthtoolGFeatures stub 
s/ATTRIBUGE/ATTRIBUTE/

Reported-by: Olaf Hering <olaf@aepfle.de>
 2016-06-09 08:45:14 +02:00
Ján Tomko 09b406a756 virschematest: call va_end even on OOM 
Jump to cleanup if virAsprintf fails.
 2016-06-08 16:33:26 +02:00
Ján Tomko e4fd42d87b lxc: simplify lxcDomainGetBlkioParameters 
Replace all the repetitive code by using
virDomainGetBlkioParametersAssignFromDef, similar to what commit 9f50f6e
did in the qemu driver.
 2016-06-08 15:25:35 +02:00
Ján Tomko 32e6339c19 Export virDomainGetBlkioParametersAssignFromDef 
Move qemuDomainGetBlkioParametersAssignFromDef into domain_conf
and export it, to allow reuse in the LXC driver.
 2016-06-08 15:23:44 +02:00