NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2026-09-03 20:53:04 -05:00
Code Issues Packages Projects Releases Wiki Activity
26,246 Commits 67 Branches 733 Tags
4b9af8625a642339526b47eff718fab12c4b7cea
Commit Graph
14 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Wang King 81bbdafb96 util: Drop unused var @errbuf from virPCIGetDeviceAddressFromSysfsLink 
Commit @a7035662 forgot to remove it when doing a refactor.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
 2017-04-27 12:21:17 +02:00
Wang King 0023cc039d daemon: Remove unnecessary goto error 
Freeing the dst is unnecessary if the VIR_STRDUP fails, and therefore
we need to remove the error label as well.
 2017-04-25 11:30:41 +02:00
Wang King f69340472c daemon: Fix domain name leak in error path 
Domain name is duplicated in make_nonnull_domain, but not freed when
virTypedParamsSerialize returns error.
 2017-04-25 11:30:26 +02:00
Wang King 123770cd4e util: Fix resource leak 
The virRotatingFileWriterAppend method leaks the file->entry
on the virRotatingFileWriterEntryNew failing path.
 2017-04-13 08:14:54 -04:00
Wang King 9db0a63b7e tools: remove unused assignment statement in virshStorageVolListCollect 
Assigning value true to @success if there is no volumes, that stored value is not used.
 2017-04-13 08:14:54 -04:00
Wang King b2641b4392 test: Remove unused variate @maxcpu in testDomainGetVcpus 
Since refactoring by commit id '3dd859c0', @maxcpu is no longer used.
 2017-04-13 08:14:54 -04:00
Wang King d76267b2e4 esx: Fix memory leak 
Variable def going out of scope leaks the storage def.source.hosts points to.
 2017-04-13 08:14:54 -04:00
Wang King 77cc51a482 esx: Fix incorrect memory compare size in esxStoragePoolLookupByUUID 
Use MD5_DIGEST_SIZE or VIR_UUID_BUFLEN rather than VIR_UUID_STRING_BUFLEN
when compare @uuid with @md5.
 2017-04-13 08:14:54 -04:00
Wang King 05b3846caf conf: remove unused assignment statement in virSysinfoBaseBoardParseXML 
Assigning value 0 to @nboards in success path, that stored value is not used.
 2017-04-13 08:14:54 -04:00
Wang King c5ca209f58 util: systemd: Don't strlen a possibly NULL string 
Coverity complains about virBufferCurrentContent might be return null
when calling strlen, so check virBufferError first before calling
strlen.
 2017-04-12 10:55:42 +02:00
Wang King 1b1b045915 interface: Fix resource leak in netcfConnectListAllInterfaces error path 
On virGetInterface failure, call virInterfaceDefFree for the @def.
 2017-04-12 10:38:24 +02:00
Wang King b1aa4613a7 virsh: don't leak @cpumap in virshVcpuPinQuery 
==18591== 16 bytes in 1 blocks are definitely lost in loss record 41 of 183
==18591==    at 0x4C2B934: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==18591==    by 0x54EBB1C: virAllocN (viralloc.c:191)
==18591==    by 0x1628CA: _vshMalloc (vsh.c:136)
==18591==    by 0x1344C4: virshVcpuPinQuery (virsh-domain.c:6603)
==18591==    by 0x1344C4: cmdVcpuPin (virsh-domain.c:6707)
==18591==    by 0x1631BF: vshCommandRun (vsh.c:1312)
==18591==    by 0x12DBB1: main (virsh.c:961)
 2017-04-12 09:49:47 +02:00
Wang King a563451e2b util: unlock closeCallbacks if get callbacks for connect fail 
Avoid return with the closeCallbacks locked when get callbacks list for connect fail.

Signed-off-by: Wang King <king.wang@huawei.com>
Signed-off-by: John Ferlan <jferlan@redhat.com>
 2017-01-21 12:39:52 -05:00
Wangjing (King, Euler) 3afaae4984 qemu: snapshot: restart CPUs when recover from interrupted snapshot job 
If we restart libvirtd while VM was doing external memory snapshot, VM's
state be updated to paused as a result of running a migration-to-file
operation, and then VM will be left as paused state. In this case we must
restart the VM's CPUs to resume it.

Signed-off-by: Wang King <king.wang@huawei.com>
 2017-01-05 10:47:03 +01:00