NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2026-09-03 20:53:04 -05:00
Code Issues Packages Projects Releases Wiki Activity
35,012 Commits 67 Branches 733 Tags
85394f676dc4f580d29db7b7a8c3a898a8cc225b
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Ján Tomko 8e09cf1d5a docs: hacking: fix typo 
s/verca/versa/

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
 2019-10-22 22:15:02 +02:00
Ján Tomko 71aadcd764 docs: hacking: amend push-without-review rules 
Include the 'semi-automatic' updates in the list of patches pushed
at maintainers' discretion to match current practice.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
 2019-10-22 22:15:02 +02:00
Ján Tomko 5516311426 docs: hacking: extend goto documentation 
Replace reference to VIR_FREE with g_free and mention the use
of g_auto cleanup attributes that eliminate most of label use.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
 2019-10-22 22:15:02 +02:00
Ján Tomko 6cc9b74e0e docs: hacking: remove reference to ATTRIBUTE_FORMAT 
Prefer G_GNUC_PRINTF.

Also, pick another example than virAsprintf since it may get
removed in the future.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
 2019-10-22 22:15:02 +02:00
Ján Tomko 2d0b8560ce docs: hacking: document string concatenations 
Recommend GString for generic strings and virBuffer for strings
that need helpers for other uses, like XML or command line
formatting.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
 2019-10-22 22:15:02 +02:00
Ján Tomko da5c733524 docs: hacking: document preferred strdup alternatives 
Recommend g_str(n)dup instead of VIR_STRDUP.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
 2019-10-22 22:15:02 +02:00
Ján Tomko 95f3a1fe3c docs: hacking: mention GLib alternatives of libvirt string allocation macros 
Document the preferred alternatives to existing libvirt macros for
allocating strings. These cannot be deleted just yet because
converting them will require a lot of work.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
 2019-10-22 22:15:02 +02:00
Ján Tomko 48f48b27af docs: hacking: mention GLib alternatives of libvirt allocation macros 
Document the preferred alternatives to existing libvirt macros for
memory allocation. These cannot be deleted just yet because
converting them will require a lot of work.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
 2019-10-22 22:09:48 +02:00
Ján Tomko e30c787a0c docs: hacking: mention compiler annotations 
Mention all the __attribute__ annotations we use to make the compiler
and/or the static analysis tools understand the code better.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
 2019-10-22 22:09:14 +02:00
Ján Tomko 16eed88666 docs: hacking: extend the table of removed libvirt macros 
Mention the various ATTRIBUTE* macros and ARRAY_CARDINALITY
that were removed earlier.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
 2019-10-22 22:09:14 +02:00
Ján Tomko fe9b3e1cdc docs: hacking: demonstrate the powers of VIR_TEST_RANGE 
Mention a more complex example.

Invoke the test without 'make' since the mentioned example
does not seem to be working anymore.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
 2019-10-22 22:09:13 +02:00
Ján Tomko 1e8446024a docs: hacking: remove notes about -Werror 
Our HACKING file is clear about requiring submission from a git
checkout, which automatically enables -Werror.

Remove the mentions of explicitly enabling it to alleviate
the collective cognitive encumbrance.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
 2019-10-22 22:09:13 +02:00
Ján Tomko 136d907ff6 docs: hacking: emphasize some sections 
Namely:
* holding up the first-time patch submissions for moderation,
  which might cause first-time submitters to question the process
* not CC-ing individual developers

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
 2019-10-22 22:09:13 +02:00
Ján Tomko 2825803477 docs: hacking: mention git-publish prominently 
This tool takes care of many of the tedious parts of submitting
a patch. Mention it first, above the "manual" way using
git send-email.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
 2019-10-22 22:09:13 +02:00
Ján Tomko fd082e16c9 docs: hacking: remove note about rename detection 
It has been enabled by default for over three years now:

commit 5d2a30d7d8777319c745804f040fa405d02169ce
Author:     Junio C Hamano <gitster@pobox.com>
CommitDate: 2016-04-03 10:29:22 -0700

    Merge branch 'mm/diff-renames-default'

https://github.com/git/git/commit/5d2a30d7d8777319c745804f040fa405d02169ce

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
 2019-10-22 22:09:13 +02:00
Ján Tomko d63f91648e Use g_strdup instead of VIR_STRDUP everywhere 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:59 +02:00
Ján Tomko 506d313fa1 tools: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:59 +02:00
Ján Tomko 29b1e859e3 tests: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:59 +02:00
Ján Tomko ddb99ca516 vbox: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:59 +02:00
Ján Tomko 18f377178a util: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:59 +02:00
Ján Tomko 8212e5e4ab vircgroup: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:58 +02:00
Ján Tomko 5a101469fc virstorage: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:58 +02:00
Ján Tomko 7d9f7e1731 test: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:58 +02:00
Ján Tomko a7fb30e358 storage: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:58 +02:00
Ján Tomko 25d3fc7ada security: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:58 +02:00
Ján Tomko 45bf10ba1d rpc: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:58 +02:00
Ján Tomko b2d079c113 remote: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:58 +02:00
Ján Tomko ce36e33c10 qemu: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:57 +02:00
Ján Tomko a0bb136929 nwfilter: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:57 +02:00
Ján Tomko 7f1f0453fc node_device: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:57 +02:00
Ján Tomko 4d81b800e2 network: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:57 +02:00
Ján Tomko 380bc1bec7 lxc: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:57 +02:00
Ján Tomko 620cd4d0c8 logging: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:57 +02:00
Ján Tomko 9e96101d40 locking: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:57 +02:00
Ján Tomko b11457158e libxl: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:56 +02:00
Ján Tomko 2f3b7a5555 interface: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:56 +02:00
Ján Tomko 07ef88935a esx: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:56 +02:00
Ján Tomko 923ab677b2 datatypes: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:56 +02:00
Ján Tomko df753c85db cpu: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:56 +02:00
Ján Tomko 17561eb362 conf: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:56 +02:00
Ján Tomko 652cdbe364 bhyve: use g_strdup instead of VIR_STRDUP 
Replace all occurrences of
  if (VIR_STRDUP(a, b) < 0)
     /* effectively dead code */
with:
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:56 +02:00
Ján Tomko 7b48bb8ca0 Use g_strdup to fill in default values 
Replace:
  if (!s && VIR_STRDUP(s, str) < 0)
    goto;
with:
  if (!s)
    s = g_strdup(str);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:55 +02:00
Ján Tomko 3cbd4351de Use g_strdup where VIR_STRDUP's return value was propagated 
All the callers of these functions only check for a negative
return value.

However, virNetDevOpenvswitchGetVhostuserIfname is documented
as returning 1 for openvswitch interfaces so preserve that.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:55 +02:00
Ján Tomko 94c98eb550 drivers: use g_strdup in probe functions 
The callers expect '1' on a successful probe,
so return 1 just like VIR_STRDUP would.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:55 +02:00
Ján Tomko ea5bb994cb Use g_strdup instead of ignoring VIR_STRDUP_QUIET's value 
Replace all the occurrences of
  ignore_value(VIR_STRDUP_QUIET(a, b));
with
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:55 +02:00
Ján Tomko 64023f6d21 Use g_strdup instead of ignoring VIR_STRDUP's value 
Replace all the occurrences of
  ignore_value(VIR_STRDUP(a, b));
with
  a = g_strdup(b);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:55 +02:00
Ján Tomko d74067c07b conf: use g_strdup in virDomainDiskSet 
Use a temporary variable to allow copying from the
currently set source.

Always return 0 since none of the callers distinguishes
between 0 and 1 propagated from VIR_STRDUP.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:54 +02:00
Ján Tomko cb756a9914 util: fix check for iscsi initiator copy 
virStorageSourceInitiatorCopy propagates the return
value from VIR_STRDUP, which returns 1 on a successful
copy.

Only error out on < 0, not non-zero values.

Fixes: 9ea3fdc6e9

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:54 +02:00
Ján Tomko 5f9c062546 scripts: introduce a macro file for coccinelle 
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-21 12:51:54 +02:00
Ján Tomko fbc5a15372 vsh: mark ctl as unused in vshReadline 
My commit removed the last use in the version for platforms
without readline.

Fixes: c937c1d23d

Signed-off-by: Ján Tomko <jtomko@redhat.com>
 2019-10-21 11:11:04 +02:00
Ján Tomko f31bdc7ced tools: delete vshStrdup 
Now that we use g_strdup everywhere, delete vshStrdup.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
 2019-10-20 14:37:17 +02:00
Ján Tomko c937c1d23d tools: prefer g_strdup to vshStrdup 
Remove all the uses of vshStrdup in favor of GLib's g_strdup.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
 2019-10-20 14:37:16 +02:00
Ján Tomko 7863f1547a tools: vshCommandArgvGetArg: prefer g_strdup 
Remove the use of vshStrdup.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
 2019-10-20 14:37:16 +02:00
Ján Tomko df329e94cb tools: vshCommandArgvGetArg: one parameter per line 
Split the parameters to make changes more readable.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
 2019-10-20 14:37:16 +02:00
Ján Tomko fc941b2c54 virsh: getSignalNumber: use g_strdup 
Eliminate the use of vshStrdup.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
 2019-10-20 14:37:16 +02:00
Ján Tomko 5c808a09a7 virsh: getSignalNumber: use g_autofree 
Mark the 'str' variable as g_autofree and avoid the need for
a separate cleanup label.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
 2019-10-20 14:37:16 +02:00
Ján Tomko b6a8c9df4d virsh: getSignalNumber: rename variables 
Use 'str' for the allocated copy of the string and 'p'
for the pointer into that string.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
 2019-10-20 14:37:16 +02:00
Ján Tomko 76b4cd88f5 virsh: use g_strdup in virshDomainGetEditMetadata 
Prefer GLib's g_strdup to vshStrdup.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
 2019-10-20 14:37:16 +02:00
Ján Tomko d20f55c0f3 virsh: use g_strdup in cmdDomblkinfoGet 
Prefer GLib's g_strdup to vshStrdup.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
 2019-10-20 14:37:16 +02:00
Ján Tomko 4e66c38655 tools: cmdDomblkinfoGet: reindent parameters 
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
 2019-10-20 14:37:16 +02:00
Ján Tomko 813510f95c docs: hacking: add a conversion table for removed libvirt macros 
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-17 12:45:32 +02:00
Ján Tomko 6a73c8f2c1 docs: hacking: use <code> for functions/names 
Use the <code> element more in the GLib section.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-17 12:45:32 +02:00
Ján Tomko e4943fce3b docs: hacking: separate section about already deleted macros 
Move the recently deleted libvirt macros into a separate section.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-17 12:44:55 +02:00
Ján Tomko be2d71f325 qemu: remove unused cfg variables 
These functions got a reference to the driver config
without actually using it:
  processNicRxFilterChangedEvent
  qemuConnectDomainXMLToNative

Signed-off-by: Ján Tomko <jtomko@redhat.com>
 2019-10-17 10:04:10 +02:00
Ján Tomko 8d42211881 internal: delete VIR_STEAL_PTR 
Delete the macro to prevent its usage in new code.

The GLib version should be used instead:
    p = g_steal_pointer(&ptr);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 15:59:42 +02:00
Ján Tomko b6108a04ea Use g_steal_pointer instead of VIR_STEAL_PTR everywhere 
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 15:59:42 +02:00
Ján Tomko a3931b4996 util: use g_steal_pointer instead of VIR_STEAL_PTR 
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 15:59:42 +02:00
Ján Tomko 4f7c65da27 tools: use g_steal_pointer instead of VIR_STEAL_PTR 
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 15:59:42 +02:00
Ján Tomko 72a1bb8e4c qemu: use g_steal_pointer instead of VIR_STEAL_PTR 
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 15:59:42 +02:00
Ján Tomko efc266883f conf: use g_steal_pointer instead of VIR_STEAL_PTR 
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 15:59:42 +02:00
Ján Tomko 636b8a4b5f internal: delete VIR_RETURN_PTR 
Remove the macro definition to prevent its usage in new code.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 15:59:41 +02:00
Ján Tomko 483a14f871 Remove all usage of VIR_RETURN_PTR 
Prefer:
    return g_steal_pointer(&ptr);

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 15:59:41 +02:00
Ján Tomko d402e71901 util: delete VIR_AUTOFREE 
Commit 1e2ae2e311 deleted the last use
of VIR_AUTOFREE but forgot to delete the macro definition.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 15:59:41 +02:00
Ján Tomko 68fb03c7c0 Remove virautoclean.h 
Now that we no longer use any of the macros from this file, remove it.

This also removes a typo.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 12:06:44 +02:00
Ján Tomko 9665fbb22a Delete virObjectAutoUnref 
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 12:06:44 +02:00
Ján Tomko 2b390b97b4 Use g_autoptr instead of VIR_AUTOUNREF 
Now that all the types using VIR_AUTOUNREF have a cleanup func defined
to virObjectUnref, use g_autoptr instead of VIR_AUTOUNREF.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 12:06:44 +02:00
Ján Tomko df4986b51b Define G_DEFINE_AUTOPTR_CLEANUP_FUNC for virDomainCheckpointDef 
Allow g_autoptr to be used instead of VIR_AUTOUNREF.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 12:06:44 +02:00
Ján Tomko 45678bd70a Use g_autoptr instead of VIR_AUTOPTR 
Since commit 44e7f02915
    util: rewrite auto cleanup macros to use glib's equivalent

VIR_AUTOPTR aliases to g_autoptr. Replace all of its use by the GLib
macro version.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 12:06:43 +02:00
Ján Tomko 8334203f91 Use G_DEFINE_AUTOPTR_CLEANUP_FUNC instead of VIR_DEFINE_AUTOPTR_FUNC 
Since commit 44e7f02915
    util: rewrite auto cleanup macros to use glib's equivalent

VIR_AUTOPTR aliases to g_autoptr. Replace all uses of VIR_DEFINE_AUTOPTR_FUNC
with G_DEFINE_AUTOPTR_CLEANUP_FUNC in preparation for replacing the
rest.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 12:06:43 +02:00
Ján Tomko 1e2ae2e311 Use g_autofree instead of VIR_AUTOFREE 
Since commit 44e7f02915
    util: rewrite auto cleanup macros to use glib's equivalent

VIR_AUTOFREE is just an alias for g_autofree. Use the GLib macros
directly instead of our custom aliases.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 12:06:43 +02:00
Ján Tomko 2b2c67b401 virbuffer: use g_auto directly for virBuffer 
Since commit 44e7f02915
    util: rewrite auto cleanup macros to use glib's equivalent

VIR_AUTOCLEAN is just an alias for g_auto. Use the GLib macros
directly instead of our custom aliases.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 12:06:43 +02:00
Ján Tomko 3372c16aa5 util: xml: use g_auto directly for VIR_XPATH_NODE_AUTORESTORE 
Since commit 44e7f02915
    util: rewrite auto cleanup macros to use glib's equivalent

VIR_AUTOCLEAN is just an alias for g_auto. Use the GLib macros
directly instead of our custom aliases.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-16 12:06:43 +02:00
Ján Tomko 67e72053c1 Use G_N_ELEMENTS instead of ARRAY_CARDINALITY 
Prefer the GLib version of the macro.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 16:14:19 +02:00
Ján Tomko d99f17a502 examples: Use G_N_ELEMENTS instead of ARRAY_CARDINALITY 
We try to keep the example programs independent of libraries
other than libvirt.

Rename the locally defined ARRAY_CARDINALITY macro to G_N_ELEMENTS
which GLib provides, even though we don't actually include GLib.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 16:14:19 +02:00
Ján Tomko 88131931b8 Use G_GNUC_FALLTHROUGH instead of ATTRIBUTE_FALLTHROUGH 
Also define the macro for building with GLib older than 2.60

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 16:14:19 +02:00
Ján Tomko dd3738acc4 Document the ATTRIBUTE_FALLTHROUGH macro 
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 16:14:19 +02:00
Ján Tomko da367c0f9b Use G_GNUC_PRINTF instead of ATTRIBUTE_FMT_PRINTF 
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 16:14:18 +02:00
Ján Tomko d54153fde3 Use G_GNUC_NO_INLINE instead of ATTRIBUTE_NOINLINE 
Define the macro for older GLib versions.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 16:14:18 +02:00
Ján Tomko ec96b74041 syntax-check: prohibit_attribute_macros: generalize error 
Instead of enumerating every single macro variant, just emit
a more generic error.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 16:14:18 +02:00
Ján Tomko 81077d6e8a syntax-check: mock-noinline: fix after G_GNUC attribute invocations 
We started using G_GNUC macros instead of ATTRIBUTE for some attributes.
Adjust this syntax-check accordingly.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 16:14:18 +02:00
Ján Tomko a4f979c06e syntax-check: forbid ATTRIBUTE macros with a GLib replacement 
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 11:25:26 +02:00
Ján Tomko bda2cced34 internal: remove no longer used ATTRIBUTE macros 
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 11:25:26 +02:00
Ján Tomko 9415a072c2 gendispatch: generate G_GNUC_UNUSED instead of ATTRIBUTE_UNUSED 
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 11:25:26 +02:00
Ján Tomko 6afbb7cf5c syntax-check: check for G_GNUC_UNUSED instead of ATTRIBUTE_UNUSED 
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 11:25:26 +02:00
Ján Tomko 059cf394ce Use G_GNUC_UNUSED everywhere 
Use G_GNUC_UNUSED from GLib instead of ATTRIBUTE_UNUSED.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 11:25:25 +02:00
Ján Tomko adfa096bf2 vz: use G_GNUC_UNUSED 
Use G_GNUC_UNUSED from GLib instead of ATTRIBUTE_UNUSED.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 11:25:25 +02:00
Ján Tomko b2060e2942 vbox: use G_GNUC_UNUSED 
Use G_GNUC_UNUSED from GLib instead of ATTRIBUTE_UNUSED.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 11:25:25 +02:00
Ján Tomko 679f8b3994 util: use G_GNUC_UNUSED 
Use G_GNUC_UNUSED from GLib instead of ATTRIBUTE_UNUSED.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 11:25:25 +02:00
Ján Tomko 123196aa05 tools: use G_GNUC_UNUSED 
Use G_GNUC_UNUSED from GLib instead of ATTRIBUTE_UNUSED.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 11:25:25 +02:00
Ján Tomko 0d94f02455 tests: use G_GNUC_UNUSED 
Use G_GNUC_UNUSED from GLib instead of ATTRIBUTE_UNUSED.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2019-10-15 11:25:25 +02:00