Support running tests in parallel (#1667)

To allow for faster execution of the unit tests locally, allow running
them in parallel.

Gemfile

@@ -51,3 +51,5 @@ group :test do
   gem "ruby-prof", ">= 0.17.0", require: false
   gem 'stackprof', '>= 0.2.9', require: false
 end
+
+gem 'parallel_tests', group: [:development, :test], require: false

lib/vagrant-libvirt/action/create_domain_volume.rb

@@ -2,6 +2,9 @@
 
 require 'log4r'
 
+require 'vagrant-libvirt/util/erb_template'
+require 'vagrant-libvirt/util/storage_util'
+
 module VagrantPlugins
   module ProviderLibvirt
     module Action

spec/acceptance/additional_storage_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../spec_helper'
 
 describe 'additional storage configured', acceptance: true do
   include_context 'libvirt_acceptance'

spec/acceptance/networking_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../spec_helper'
 
 describe 'package domain', acceptance: true do
   include_context 'libvirt_acceptance'

spec/acceptance/package_domain_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../spec_helper'
 
 describe 'package domain', acceptance: true do
   include_context 'libvirt_acceptance'

spec/acceptance/provider_settings_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../spec_helper'
 
 describe 'provider settings', acceptance: true do
   include_context 'libvirt_acceptance'

spec/acceptance/simple_vm_provision_via_shell_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../spec_helper'
 
 describe 'simple vm provision via shell', acceptance: true do
   include_context 'libvirt_acceptance'

spec/acceptance/snapshots_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../spec_helper'
 
 describe 'snapshots', acceptance: true do
   include_context 'libvirt_acceptance'

spec/acceptance/two_disks_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../spec_helper'
 
 describe 'handle two disk machine', acceptance: true do
   include_context 'libvirt_acceptance'

spec/acceptance/use_qemu_agent_for_connectivity_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../spec_helper'
 
 describe 'use qemu agent to determine machine private address', acceptance: true do
   include_context 'libvirt_acceptance'

spec/spec_helper.rb

@@ -38,6 +38,8 @@ rescue LoadError
   end
 end
 
+require 'rspec'
+
 RSpec.configure do |config|
   require 'tmpdir'
 

spec/support/unit_context.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../spec_helper'
 
 shared_context 'unit' do
   include_context 'vagrant-unit'

spec/unit/action/clean_machine_folder_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/action/clean_machine_folder'
 

spec/unit/action/cleanup_on_failure_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant/action/runner'
 

spec/unit/action/create_domain_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'fog/libvirt/models/compute/volume'
 

spec/unit/action/create_domain_volume_spec.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'fog/libvirt/models/compute/volume'
 
-require 'vagrant-libvirt/action/destroy_domain'
+require 'vagrant-libvirt/action/create_domain_volume'
 require 'vagrant-libvirt/util/byte_number'
 
 

spec/unit/action/destroy_domain_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/action/destroy_domain'
 

spec/unit/action/forward_ports_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/errors'
 require 'vagrant-libvirt/action/forward_ports'

spec/unit/action/halt_domain_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/action/halt_domain'
 

spec/unit/action/handle_box_image_spec.rb

@@ -1,9 +1,10 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
+
 require 'json'
 
-require 'vagrant-libvirt/action/destroy_domain'
+require 'vagrant-libvirt/action/handle_box_image'
 require 'vagrant-libvirt/util/byte_number'
 
 

spec/unit/action/package_domain_spec.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
-require 'vagrant-libvirt/action/clean_machine_folder'
+require 'vagrant-libvirt/action/package_domain'
 
 describe VagrantPlugins::ProviderLibvirt::Action::PackageDomain do
   subject { described_class.new(app, env) }

spec/unit/action/prepare_nfs_settings_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/action/prepare_nfs_settings'
 

spec/unit/action/remove_libvirt_image_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/action/remove_libvirt_image'
 

spec/unit/action/resolve_disk_settings_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'fog/libvirt/models/compute/volume'
 

spec/unit/action/set_boot_order_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/action/set_boot_order'
 

spec/unit/action/set_name_of_domain_spec.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
+
+require 'vagrant-libvirt/action/set_name_of_domain'
 
 describe VagrantPlugins::ProviderLibvirt::Action::SetNameOfDomain do
   before :each do

spec/unit/action/shutdown_domain_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/action/shutdown_domain'
 

spec/unit/action/start_domain_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/errors'
 require 'vagrant-libvirt/action/start_domain'

spec/unit/action/wait_till_up_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/action/wait_till_up'
 require 'vagrant-libvirt/errors'

spec/unit/action_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../spec_helper'
 
 require 'vagrant/action/runner'
 

spec/unit/cap/mount_9p_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt'
 

spec/unit/cap/synced_folder_9p_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/cap/synced_folder_9p'
 require 'vagrant-libvirt/util/unindent'

spec/unit/cap/synced_folder_virtiofs_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/cap/synced_folder_virtiofs'
 require 'vagrant-libvirt/util/unindent'

spec/unit/config_spec.rb

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
 
-require 'support/binding_proc'
-
-require 'spec_helper'
+require_relative '../spec_helper'
+require_relative '../support/binding_proc'
 
 require 'vagrant-libvirt/config'
 

spec/unit/driver_spec.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-require 'fog/libvirt/requests/compute/dhcp_leases'
+require_relative '../spec_helper'
+require_relative '../support/binding_proc'
 
-require 'spec_helper'
-require 'support/binding_proc'
+require 'fog/libvirt/requests/compute/dhcp_leases'
 
 require 'vagrant-libvirt/driver'
 

spec/unit/plugin_spec.rb

@@ -1,9 +1,11 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../spec_helper'
 
 require 'vagrant-libvirt'
 require 'vagrant-libvirt/plugin'
+require 'vagrant-libvirt/action'
+require 'vagrant-libvirt/action/remove_libvirt_image'
 
 
 describe VagrantPlugins::ProviderLibvirt::Plugin do
@@ -24,7 +26,9 @@ describe VagrantPlugins::ProviderLibvirt::Plugin do
     end
 
     it 'should call the action hook after box remove' do
-      expect(VagrantPlugins::ProviderLibvirt::Action).to receive(:remove_libvirt_image).and_return(Vagrant::Action::Builder.new)
+      expect_any_instance_of(VagrantPlugins::ProviderLibvirt::Action::RemoveLibvirtImage).to receive(:call) do |cls, env|
+        cls.instance_variable_get(:@app).call(env)
+      end
       expect {
         env[:env].action_runner.run(
           Vagrant::Action.action_box_remove, {

spec/unit/templates/domain_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/config'
 require 'vagrant-libvirt/util/erb_template'

spec/unit/util/byte_number_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/util/byte_number'
 

spec/unit/util/network_util_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/util/network_util'
 

spec/unit/util/resolvers_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require_relative '../../spec_helper'
 
 require 'vagrant-libvirt/util/resolvers'