NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-25 18:55:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

createvol: Always generate a default name

Browse Source 
Let's users just quickly click through, gives more testing
to the name_hint path
This commit is contained in:
Cole Robinson
2019-05-04 16:26:15 -04:00
parent bad894ad8c
commit 1b6b6b10e3
1 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
virtManager/createvol.py
View File

@@ -113,15 +113,15 @@ class vmmCreateVolume(vmmGObjectUI):
def _reset_state(self):
vol = self._make_stub_vol()
self.widget("vol-name").set_text(self._default_vol_name() or "")
self.widget("vol-name").grab_focus()
self.widget("vol-name").emit("changed")
hasformat = vol.supports_property("format")
uiutil.set_grid_row_visible(self.widget("vol-format"), hasformat)
uiutil.set_list_selection(self.widget("vol-format"),
self.conn.get_default_storage_format())
self.widget("vol-name").set_text(self._default_vol_name() or "")
self.widget("vol-name").grab_focus()
self.widget("vol-name").emit("changed")
default_alloc = 0
default_cap = 20
@@ -155,15 +155,15 @@ class vmmCreateVolume(vmmGObjectUI):
return uiutil.get_list_selection(self.widget("vol-format"))
def _default_vol_name(self):
if not self._name_hint:
return ""
hint = self._name_hint or "vol"
suffix = self._default_suffix()
ret = ""
try:
ret = StorageVolume.find_free_name(
self._parent_pool.get_backend(),
self._name_hint, suffix=suffix)
hint, suffix=suffix)
if ret and suffix:
ret = ret.rsplit(".", 1)[0]
except Exception:
logging.exception("Error finding a default vol name")
@@ -355,7 +355,6 @@ class vmmCreateVolume(vmmGObjectUI):
if "." in text:
suffix = ""
self.widget("vol-name-suffix").set_text(suffix)
self.widget("vol-create").set_sensitive(bool(text))
def _browse_backing_clicked_cb(self, src):
self._browse_file()