NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-25 18:55:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

engine: Always stop close conn if polling error encountered

Browse Source 
We handle a lot of errors in the conn tick function, anything unhandled
should be fatal. For errors that aren't libvirtd restarting/crashing,
report them to the user.
This commit is contained in:
Cole Robinson 2011-07-25 13:31:36 -04:00
parent 5f22897f94
commit 6024065be3
1 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/virtManager/engine.py
View File

@ -69,6 +69,11 @@ DETAILS_PERF = 1
DETAILS_CONFIG = 2
DETAILS_CONSOLE = 3
def _safe_getattr(obj, name):
if not hasattr(obj, name):
return None
return getattr(obj, name)
#############################
# PackageKit lookup helpers #
#############################
@ -436,14 +441,24 @@ class vmmEngine(vmmGObject):
except KeyboardInterrupt:
raise
except libvirt.libvirtError, e:
if (e.get_error_domain() == libvirt.VIR_FROM_REMOTE and
e.get_error_code() == libvirt.VIR_ERR_SYSTEM_ERROR):
from_remote = _safe_getattr(libvirt, "VIR_FROM_REMOTE")
from_rpc = _safe_getattr(libvirt, "VIR_FROM_RPC")
sys_error = _safe_getattr(libvirt, "VIR_ERR_SYSTEM_ERROR")
dom = e.get_error_domain()
code = e.get_error_code()
if (dom in [from_remote, from_rpc] and
code in [sys_error]):
logging.exception("Could not refresh connection %s." % uri)
logging.debug("Closing connection since libvirtd "
"appears to have stopped.")
self.safe_idle_add(conn.close)
else:
raise
self.err.show_err(_("Error polling connection '%s': %s") %
(conn.get_uri(), e))
self.safe_idle_add(conn.close)
return 1
def change_timer_interval(self, ignore1, ignore2, ignore3, ignore4):