NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-25 18:55:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

devices: interface: Cache default bridge lookup for process lifetime

Browse Source 
Saves us possibly hammering the logs if this goes wrong. We are
about to start using it more in virt-manager

Signed-off-by: Cole Robinson <crobinso@redhat.com>
This commit is contained in:
Cole Robinson 2020-01-25 19:17:23 -05:00
parent 9a72df3128
commit 869eb2dc8f
1 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
virtinst/devices/interface.py
View File

@ -85,14 +85,28 @@ def _host_default_bridge():
return None
# Cache the host default bridge lookup. It can change over the lifetime
# of a virt-manager run, but that should be rare, and this saves us
# possibly spamming logs if host lookup goes wrong
_HOST_DEFAULT_BRIDGE = -1
def _default_bridge(conn):
if conn.is_remote():
return None
ret = _host_default_bridge()
global _HOST_DEFAULT_BRIDGE
if _HOST_DEFAULT_BRIDGE == -1:
try:
ret = _host_default_bridge()
except Exception:
log.debug("Error getting host default bridge", exc_info=True)
ret = None
_HOST_DEFAULT_BRIDGE = ret
if conn.in_testsuite():
ret = "testsuitebr0"
return ret
return "testsuitebr0"
return _HOST_DEFAULT_BRIDGE
class _VirtualPort(XMLBuilder):