NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-25 18:55:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

test_xmlconfig.py: use single quote strings in testDiskNumbers

Browse Source 
codespell complains that one of the asserts is a typo:

tests/test_xmlconfig.py:92: ba  ==> by, be

Using single quote strings in that assert will make codespell
pass. For consistency, let's change all the strings in the
test to be single quoted.

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
This commit is contained in:
Daniel Henrique Barboza 2020-06-03 10:14:34 -03:00 committed by Cole Robinson
parent 21f1c90c2b
commit ec87485852
1 changed files with 26 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
tests/test_xmlconfig.py
View File

@ -83,35 +83,38 @@ class TestXMLMisc(unittest.TestCase):
def testDiskNumbers(self):
# Various testing our target generation
self.assertEqual("a", DeviceDisk.num_to_target(1))
self.assertEqual("b", DeviceDisk.num_to_target(2))
self.assertEqual("z", DeviceDisk.num_to_target(26))
self.assertEqual("aa", DeviceDisk.num_to_target(27))
self.assertEqual("ab", DeviceDisk.num_to_target(28))
self.assertEqual("az", DeviceDisk.num_to_target(52))
self.assertEqual("ba", DeviceDisk.num_to_target(53))
self.assertEqual("zz", DeviceDisk.num_to_target(27 * 26))
self.assertEqual("aaa", DeviceDisk.num_to_target(27 * 26 + 1))
#
# Note: using single quotes in strings to avoid
# codespell flagging the 'ba' assert
self.assertEqual('a', DeviceDisk.num_to_target(1))
self.assertEqual('b', DeviceDisk.num_to_target(2))
self.assertEqual('z', DeviceDisk.num_to_target(26))
self.assertEqual('aa', DeviceDisk.num_to_target(27))
self.assertEqual('ab', DeviceDisk.num_to_target(28))
self.assertEqual('az', DeviceDisk.num_to_target(52))
self.assertEqual('ba', DeviceDisk.num_to_target(53))
self.assertEqual('zz', DeviceDisk.num_to_target(27 * 26))
self.assertEqual('aaa', DeviceDisk.num_to_target(27 * 26 + 1))
self.assertEqual(DeviceDisk.target_to_num("hda"), 0)
self.assertEqual(DeviceDisk.target_to_num("hdb"), 1)
self.assertEqual(DeviceDisk.target_to_num("sdz"), 25)
self.assertEqual(DeviceDisk.target_to_num("sdaa"), 26)
self.assertEqual(DeviceDisk.target_to_num("vdab"), 27)
self.assertEqual(DeviceDisk.target_to_num("vdaz"), 51)
self.assertEqual(DeviceDisk.target_to_num("xvdba"), 52)
self.assertEqual(DeviceDisk.target_to_num("xvdzz"),
self.assertEqual(DeviceDisk.target_to_num('hda'), 0)
self.assertEqual(DeviceDisk.target_to_num('hdb'), 1)
self.assertEqual(DeviceDisk.target_to_num('sdz'), 25)
self.assertEqual(DeviceDisk.target_to_num('sdaa'), 26)
self.assertEqual(DeviceDisk.target_to_num('vdab'), 27)
self.assertEqual(DeviceDisk.target_to_num('vdaz'), 51)
self.assertEqual(DeviceDisk.target_to_num('xvdba'), 52)
self.assertEqual(DeviceDisk.target_to_num('xvdzz'),
26 * (25 + 1) + 25)
self.assertEqual(DeviceDisk.target_to_num("xvdaaa"),
self.assertEqual(DeviceDisk.target_to_num('xvdaaa'),
26 * 26 * 1 + 26 * 1 + 0)
disk = virtinst.DeviceDisk(self.conn)
disk.bus = "ide"
disk.bus = 'ide'
self.assertEqual("hda", disk.generate_target([]))
self.assertEqual("hdb", disk.generate_target(["hda"]))
self.assertEqual("hdc", disk.generate_target(["hdb", "sda"]))
self.assertEqual("hdb", disk.generate_target(["hda", "hdd"]))
self.assertEqual('hda', disk.generate_target([]))
self.assertEqual('hdb', disk.generate_target(['hda']))
self.assertEqual('hdc', disk.generate_target(['hdb', 'sda']))
self.assertEqual('hdb', disk.generate_target(['hda', 'hdd']))
def testQuickTreeinfo(self):
# Simple sanity test to make sure detect_distro works. test-urls