Use enumerate instead of range and len

This commit is contained in:
Radostin Stoyanov
2017-10-20 13:18:31 -04:00
committed by Cole Robinson
parent 37ea520773
commit f41aafc721
4 changed files with 6 additions and 9 deletions
+2 -4
View File
@@ -594,9 +594,8 @@ class vmmAddHardware(vmmGObjectUI):
vmmAddHardware.populate_smartcard_mode_combo(vm, combo)
idx = -1
for rowid in range(len(combo.get_model())):
for rowid, row in enumerate(combo.get_model()):
idx = 0
row = combo.get_model()[rowid]
if row[0] == virtinst.VirtualSmartCardDevice.MODE_DEFAULT:
idx = rowid
break
@@ -641,9 +640,8 @@ class vmmAddHardware(vmmGObjectUI):
vmmAddHardware.populate_tpm_type_combo(vm, combo)
idx = -1
for rowid in range(len(combo.get_model())):
for rowid, row in enumerate(combo.get_model()):
idx = 0
row = combo.get_model()[rowid]
if row[0] == virtinst.VirtualTPMDevice.TYPE_DEFAULT:
idx = rowid
break
+2 -2
View File
@@ -288,8 +288,8 @@ class vmmNetworkList(vmmGObjectUI):
model.insert(0, row)
default = 0
elif label:
default = [idx for idx in range(len(model)) if
model[idx][2] == label][0]
default = [idx for idx, model_label in enumerate(model) if
model_label[2] == label][0]
_add_manual_bridge_row()
return default
+1 -1
View File
@@ -274,7 +274,7 @@ class vmmSystray(vmmGObject):
vm_submenu.insert(menu_item, 0)
return
for i in range(0, len(vm_names)):
for i, name in enumerate(vm_names):
name = vm_names[i]
connkey = vm_mappings[name]
if connkey in self.conn_vm_menuitems[uri]:
+1 -2
View File
@@ -430,8 +430,7 @@ class Cloner(object):
iface.macaddr = mac
# Changing storage XML
for i in range(len(self._original_disks)):
orig_disk = self._original_disks[i]
for i, orig_disk in enumerate(self._original_disks):
clone_disk = self._clone_disks[i]
for disk in self._guest.get_devices("disk"):