Commit Graph

2103 Commits

Author SHA1 Message Date
Cole Robinson
2fa12ffa15 Move bind_escape_key_close helper to baseclass 2011-04-18 11:25:28 -04:00
Cole Robinson
de8c901d7b Move idle wrappers to baseclass
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2011-04-18 11:13:33 -04:00
Cole Robinson
b7de618897 Move connect helpers from util to baseclass
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2011-04-18 11:13:33 -04:00
Cole Robinson
ad8060d191 baseclass: Fix early error reporting before we setup running_config 2011-04-15 18:38:29 -04:00
Cole Robinson
50c8d9559c uihelpers: Tweak 'no networking' label 2011-04-15 15:34:54 -04:00
Cole Robinson
9b26e093e9 create: Warn about PXE and 'no networking' 2011-04-15 15:34:24 -04:00
Cole Robinson
33162f20b9 create: Don't overwrite net warnings in reset_state 2011-04-15 15:33:56 -04:00
Cole Robinson
450f88cf66 Make all start/stop/delete operations run async
Applies for domains, nets, pools, volumes, interfaces. Domain pause, unpause
save and restore all run async as well.
2011-04-15 15:23:13 -04:00
Cole Robinson
7e211aa151 More pause button state fixes
Make sure we reset the pause button state _before_ we invoke the
operation, otherwise we might overwrite the already updated state
2011-04-15 14:56:24 -04:00
Cole Robinson
6590233b7e prefs: Remove console popup option
This was originally requested when the console window didn't have option to
start/stop a VM (see https://bugzilla.redhat.com/show_bug.cgi?id=211385).
That hasn't been valid for a long time. The option was pretty unclear in
the prefs dialog anyways, and had weird behavior like 'open the domain for
all running vms when we start virt-manager'

Just always use the current default of opening the console for VMs that
we create with New VM.
2011-04-15 14:43:52 -04:00
Cole Robinson
46e28f0b1d manager: Instantly update VM state after pause/unpause 2011-04-15 14:14:12 -04:00
Cole Robinson
8b576f4b2a connection: Remove unneeded vm-started signal
We are already notified of vm state change by it's own state-changed signal
2011-04-15 14:13:05 -04:00
Cole Robinson
ac7d5f3825 console: Cleanup VNC auth callback 2011-04-15 14:12:50 -04:00
Cole Robinson
888d7dba0e manager: Remove obsolete comment 2011-04-15 13:34:13 -04:00
Cole Robinson
28e2677944 Break out helper for prompting user before performing an op 2011-04-14 16:45:18 -04:00
Cole Robinson
a29c25bcce config: Globally cache support_threading
It's specific to libvirt client library version, so won't change from
under us. Use it in simple async to preserve behavior for old libvirt clients
2011-04-14 15:43:31 -04:00
Cole Robinson
682c1d233b asyncjob: Simplify interface for simple_async 2011-04-14 15:28:22 -04:00
Cole Robinson
6ebf751299 storagebrowse: Fix createvol sensitivity for media browsing 2011-04-14 14:07:42 -04:00
Cole Robinson
b2cd36eb50 systray: Don't leak when vm is removed 2011-04-14 13:26:44 -04:00
Cole Robinson
fa250a76ef create: Make sure we properly cleanup customize window 2011-04-14 13:22:05 -04:00
Cole Robinson
2c98bc6788 clone: Fix cleanup when repopulating the UI 2011-04-14 13:12:24 -04:00
Cole Robinson
cc8e930613 clone: Fix some UI resizing issues 2011-04-14 13:07:52 -04:00
Cole Robinson
4a4d5ebaa6 domain: Fix stats_memory stubs 2011-04-14 12:57:09 -04:00
Cole Robinson
fc6814d186 baseclass: Use logging for logtrace 2011-04-14 12:51:52 -04:00
Cole Robinson
3a3057b52b details: Make sure aborted pause op doesn't leave UI inconsistent 2011-04-14 12:51:52 -04:00
Cole Robinson
845e6aa57e connection: Better organize stats methods 2011-04-14 12:51:52 -04:00
Cole Robinson
c6dcde8288 domain: Make forced status update more explicit 2011-04-14 12:51:52 -04:00
Cole Robinson
07018e2eda engine: Slightly reorganize leak debugging 2011-04-14 11:26:53 -04:00
Cole Robinson
e799d101de Don't show virt-manager.py in --help usage: 2011-04-14 10:49:37 -04:00
Cole Robinson
3d8e6a9398 Set parent for all dialogs 2011-04-14 08:47:42 -04:00
Cole Robinson
fd755f99d5 engine: Use signals for incrementing window counter 2011-04-13 10:47:31 -04:00
Cole Robinson
b76804a8a5 console: Properly implement cleanup() 2011-04-13 10:47:03 -04:00
Cole Robinson
a3fd17575c conn: Remove debugging cruft that was disabling domain update! 2011-04-13 10:21:00 -04:00
Cole Robinson
f2781ee62a Properly cleanup all dialogs
On app close, all dialogs are properly cleaned up so there are no
dangling references and python can garbage collect.

While this isn't that important when the app shuts down, it ensures that
lifecycle changes while the app is running (vm start/stop/remove, conn
start/stop/remove) have the infrastructure to properly release resources.
2011-04-13 10:20:47 -04:00
Cole Robinson
ff3606e740 clone: Remove unused right click menus
Left over from an old design. Also move all attribute init above
child dialog init for clarity
2011-04-13 09:20:59 -04:00
Cole Robinson
8618278fe1 config: Return handle for all notifier functions
Assists callers in doing proper cleanup
2011-04-12 14:57:32 -04:00
Cole Robinson
681b508490 engine: Remove unused refresh-console signal 2011-04-12 12:06:44 -04:00
Cole Robinson
0c72663fa7 connection: Fix cleaning up removed iface + nodedevs 2011-04-12 12:05:36 -04:00
Cole Robinson
8845447a98 engine: connection-removed signal should only send URI
Since that's all that's really needed, and sending conn can interfere
with cleanup
2011-04-12 11:50:10 -04:00
Cole Robinson
f8cbb6fc75 systray: Fix connection removal callback 2011-04-12 11:47:51 -04:00
Cole Robinson
efee2bf7b2 uihelpers: Don't store network objs in combo model
Causes issues with trying to reap virConnect values
2011-04-11 19:42:17 -04:00
Cole Robinson
a52ad2eb37 details: Properly cleanup when VM/conn disappears
Make sure we are properly freeing all our state, so python can reap domains
and conn instances
2011-04-11 18:35:21 -04:00
Cole Robinson
87ebc2d46a serialcon: Subclass vmmGObject 2011-04-11 17:48:21 -04:00
Cole Robinson
a83fe73b1e error: Subclass vmmGObject
Gives us lifecycle tracking and useful helpers like refcount
2011-04-11 16:26:41 -04:00
Cole Robinson
3833aa8e3a details: Remove some unwanted debugging 2011-04-11 16:20:46 -04:00
Cole Robinson
b7730a96ab connection: Cleanup libvirt objects when they disappear
Call the new cleanup() function to ensure python actually reaps the objects
2011-04-11 16:19:47 -04:00
Cole Robinson
4d4717d5e8 delete: Drop VM reference on close
Also, simplify the interface for launching
2011-04-11 16:16:31 -04:00
Cole Robinson
1180c9c4e3 asyncjob: Do some cleanup to allow object to be garbage collected
Also ensure we don't carry around references to other objects
2011-04-11 16:16:29 -04:00
Cole Robinson
d74066da21 baseclass: Simplify cleaning up gobject signals
Just add a custom connect/disconnect to keep track of the signals for us.
2011-04-11 16:16:07 -04:00
Cole Robinson
85340ca491 baseclass: Track object lifetime to help debug ref leaks 2011-04-11 12:54:47 -04:00