Commit Graph

3315 Commits

Author SHA1 Message Date
Cole Robinson
6043a88a0c snapshots: Add some specific UI for external snapshots
We sort them separately in the snapshot list, explicitly mention that
they are 'external', and add a UI field listing the memory/disk
details.

In general mixing internal and external snapshots is a recipe for
confusion and disaster, so I think the best thing to do is at least
acknowledge their presence in the UI but not make any attempt to
predict what will or will not work.
2013-09-30 19:55:21 -04:00
Cole Robinson
6f469d7947 snapshots: List VM status in 'new snapshot' window 2013-09-30 17:40:01 -04:00
Cole Robinson
e72944d171 snapshots: Make the list entries a bit prettier 2013-09-30 17:36:38 -04:00
Cole Robinson
45e84d46ec snapshots: Make state type/icon UI match other usage 2013-09-30 17:12:24 -04:00
Cole Robinson
3629dabeb0 snapshots: new: Add default and escape action 2013-09-30 16:37:46 -04:00
Cole Robinson
b3e2d26337 snapshots: new: Automatically generate a snapshot name 2013-09-30 16:33:45 -04:00
Cole Robinson
34c502560f storage: Drop unused static function
This allows us to simplify the parameters for find_free_name
2013-09-30 16:22:12 -04:00
Cole Robinson
01577d3d88 snapshots: Desensitize 'finish' if no name entered 2013-09-30 16:22:12 -04:00
Cole Robinson
36837fd3af snapshots: Drop reporting of 'current' snapshot
It's a useless distinction in our UI
2013-09-30 16:22:12 -04:00
Cole Robinson
85ec41c3c9 snapshots: Fix initial UI state when guest has no snapshots 2013-09-30 15:52:37 -04:00
Cole Robinson
b1d3987aaa domain: Fix deleting a VM that has snapshots (bz 821518) 2013-09-30 15:38:35 -04:00
Cole Robinson
844a567e7b details: Don't silently drop managed save when renaming VM
Instead just error about it. Until there's an actual libvirt 'rename'
API we can't do much better than that.
2013-09-30 15:38:35 -04:00
Cole Robinson
5f34e7d885 details: Use 'clone' icon for snapshot button
Better than the 'new' icon since people see that one much more and
likely already have an association with it. Better would be a
distinct icon though.
2013-09-30 15:38:34 -04:00
Cole Robinson
98a95b2e2d network: Add install() command, remove function from vmmConnection
This is the pattern used by other virtinst objects
2013-09-30 15:38:34 -04:00
Cole Robinson
b9bcc84d35 libvirtobject: Remove no longer needed sanitize_xml helper 2013-09-30 15:38:34 -04:00
Cole Robinson
2b74c46909 snapshots: Pretty up the 'new snapshot' dialog 2013-09-30 15:38:12 -04:00
Cole Robinson
ccb96e9e4a VirtualDisk: Add cache modes 'directsync' and 'unsafe' (bz 844907) 2013-09-30 14:30:50 -04:00
Cole Robinson
9de21be907 virt-manager: Drop --experimental-snapshot-ui
We are just sticking with internal snapshots only
2013-09-30 14:30:50 -04:00
Cole Robinson
b3c5d123ca testdriver: Add bits for status, transient, managed save, snapshots
No unit tests for any of these, just for UI testing at the moment.
These require some non-upstream libvirt patches, but it doesn't
hurt in the interim while they are reviewed.
2013-09-30 14:30:25 -04:00
Cole Robinson
8f0bfb1ad6 host: Allow renaming a storage pool 2013-09-29 12:28:01 -04:00
Cole Robinson
369a17160a host: Allow renaming virtual networks 2013-09-29 12:14:00 -04:00
Cole Robinson
74e8fff069 clone: Fix a few misc issues 2013-09-29 11:31:03 -04:00
Cole Robinson
86a98f0d39 virt-install: Add --disk backing_store option 2013-09-29 11:23:59 -04:00
Cole Robinson
b6adf48e56 createvol: Add UI for specifying backing store 2013-09-29 10:53:37 -04:00
Cole Robinson
cd7837bc4b domain: Clean up some support checks
We don't need to cache things since virtinst/connection does it for
us.
2013-09-29 09:58:31 -04:00
Cole Robinson
66f71262f0 clitest: Add case to verify collision check via backing store 2013-09-29 09:43:39 -04:00
Cole Robinson
ddba6098f6 pollhelpers: Support nodedev listAllDevices 2013-09-29 09:39:55 -04:00
Cole Robinson
52e4976462 pollhelpers: Add fetch_volumes helper
That does the listAllVolumes support check to speed us up a bit.
2013-09-29 09:33:17 -04:00
Cole Robinson
ce9f8ee24e pollhelpers: Clarify some variable names and docs 2013-09-29 09:28:42 -04:00
Cole Robinson
07ea05365d connection: Cache _all_ support checks
This could cause issues if something like a domain support check
returns NOSUPPORT for one domain on a connection but not for another
domain, but honestly I'd call that a libvirt bug since NOSUPPORT should
be usable like we want it.
2013-09-29 09:26:03 -04:00
Cole Robinson
a9a085340b support: Rename SUPPORT_STORAGE to SUPPORT_POOL
It's more accurate. And fix up comments about back compat which no
longer apply.
2013-09-29 09:21:42 -04:00
Cole Robinson
72058f2bbf support: Remove unused nodedev support checks 2013-09-29 09:19:56 -04:00
Cole Robinson
0ffdbb13fe pollhelpers: Re-enable list-all-interfaces
Was just transient F19 breakage
2013-09-29 08:33:45 -04:00
Cole Robinson
40870dbcd8 tests: Add extra caching to speed up tests 2013-09-28 21:07:22 -04:00
Cole Robinson
7a5dc7c544 devicedisk: path_in_use_by: Check backing stores as well
Plumb through a fetch_all_vols helper for this, and do all the
caching bits.
2013-09-28 21:07:18 -04:00
Cole Robinson
bc34df1dc7 storage: Parse volume backingstore 2013-09-28 19:21:58 -04:00
Cole Robinson
7664e5762d virt-manager: Remove hotshot --profile command
Much easier to just do python -m cProfile -s time virt-manager.py --debug,
and its way faster.
2013-09-28 17:25:41 -04:00
Cole Robinson
4822e6478f clitest: Don't fork rm for every test
Speeds up the tests quite a bit
2013-09-28 17:23:23 -04:00
Cole Robinson
4f59c24b40 tests: Add test_initrd_inject command
This is a standalone test like test_urls, and requires interraction. It
pulls down a bunch of kernels from public URL trees, inject known
kickstarts that induce quick failure. User inspects the output to
ensure initrd inject is working as expected.
2013-09-28 16:50:08 -04:00
Cole Robinson
375790075d details: Drop combo_or_label paradigm, use combobox entries
So we can handle unknown XML values and give users more flexibility
for things we can't predict.
2013-09-28 14:25:37 -04:00
Cole Robinson
d414beb3a9 Warn that --prompt mode will likely be removed in the future. 2013-09-28 11:34:03 -04:00
Cole Robinson
4c15da439b cli: Combine registering a bunch of common options 2013-09-28 11:27:26 -04:00
Cole Robinson
b1fb6c2567 cli: Pass key name to set_param convert_cb for error handling 2013-09-28 10:58:27 -04:00
Cole Robinson
5329a9afc9 virt-install: Add --tpm /dev/tpm convenience option 2013-09-28 10:28:04 -04:00
Cole Robinson
b3719f25ac cli: s/yes_or_no/yes_no/g 2013-09-28 10:06:52 -04:00
Cole Robinson
b3a72bcb95 cli: Remove unneeded parameter to optparse.add_option 2013-09-28 10:03:08 -04:00
Cole Robinson
eca87838fb virt-install: Add --features option
And hide docs about old --noacpi/--noacpi options. I don't think
anyone really uses them anyways, but if anyone complains we should
just implement --features for the other CLI commands.
2013-09-28 09:58:57 -04:00
Cole Robinson
16a190a0dc cli: Add some consistency to deprecated option handling
Take all the old options and convert them to new style, so the rest
of the app only needs to deal with new style bits.
2013-09-27 22:31:52 -04:00
Cole Robinson
40a9e61ba2 details: Fix looking up nodedev mapping for usb devices 2013-09-27 18:40:00 -04:00
Cole Robinson
fd00ad74e2 devicehostdev: Drop device creation helper
Goes against other device paradigms, and is cleaner when we unwind it.
2013-09-27 18:28:28 -04:00