Commit Graph
100 Commits
Author SHA1 Message Date
Cole Robinson 79ce0dcdc5 details: Fix changing media for two different cdroms
We weren't updating the target device of the choosecd dialog, so only
the first targetted device was ever updated.
2014-01-14 17:18:02 -05:00
Cole Robinson 66096a7eeb choosecd: Check path-in-use collision (bz 1028197) 2014-01-14 17:11:51 -05:00
Cole Robinson 765b1ed7d6 Track kernel/initrd/dtb in 'path in use by' UI 2014-01-14 16:57:32 -05:00
Cole Robinson 6dd41e6944 create: Disable 'fully allocate' if qcow2 is the default
Since it doesn't support full allocation
2014-01-14 16:03:58 -05:00
Cole Robinson 6db30432a5 domain: Use support infra to check if memory stats supported 2014-01-12 17:53:53 -05:00
Cole Robinson 55d6b7f377 prefs: Allow disabling all memorystats polling
Similar to how we allow disabling disk/net polling, not sure yet what
effect it might have on remote connections, so best to add this option
just to be safe.

Unlike disk/net stats, we enable this checking by default.
2014-01-12 17:39:21 -05:00
Cole Robinson 2dffdff328 addhw: disk: Split bus and device into two combo boxes
Prior to this we had them in the same combo box, which had grown quite
large.
2014-01-12 16:52:26 -05:00
Cole Robinson 44bad869ae addhw: Stick disk format and cache under 'advanced options' 2014-01-12 16:09:14 -05:00
Cole Robinson bd111d411c addhw: Only allow panic device if libvirt supports it 2014-01-12 15:16:06 -05:00
Cole Robinson f02b85d913 guest: Don't add qemu-ga on ARM where virtio slots are limited 2014-01-12 14:58:43 -05:00
Cole Robinson 52bb0f6067 nodedev: Include PCI vendor in pretty name
Pretty important if trying to distinguish between devices
2014-01-12 14:52:33 -05:00
Cole Robinson cad64c0dc1 nodedev: Remove subdev for pretty_name, it's pointless 2014-01-12 14:52:15 -05:00
Cole Robinson dd57f2f221 create: Don't reset method choice when arch changes if it's still valid 2014-01-12 14:41:25 -05:00
Cole Robinson d12c986b98 Use BUTTON size for all status icons 2014-01-12 14:36:03 -05:00
Cole Robinson 0b8ba7760e details: Fix status icon shrinking on state change.
No idea why this is happening or what is causing it, but
forcing the icon width fixes things...
2014-01-12 14:35:35 -05:00
Cole Robinson a70077172e urlfetcher: Don't mandate boot.iso in treeinfo for Generic distro
Hit this if doing --location /path/to/mounted/RHS.iso

https://bugzilla.redhat.com/show_bug.cgi?id=1039456
2014-01-11 16:24:13 -05:00
Cole Robinson d38d019aeb distroinstaller: Make each media type explicit 2014-01-11 16:10:38 -05:00
Cole Robinson 02d07996b0 addhw: Fix a pep8 error 2014-01-11 16:08:42 -05:00
Cole Robinson 0c80c69918 installer: Drop needless property redirection 2014-01-11 15:28:21 -05:00
Cole Robinson f055b07a61 details: Couple mini 'panic' UI cleanups 2014-01-11 15:08:00 -05:00
Cole Robinson 95170e8892 virt-install: Support --network source, source_mode, target
The latter two bits are needed for macvtap configuration.
2014-01-06 15:17:32 -05:00
Cole Robinson 5c1ed03b89 Fix some pylint 2013-12-18 16:34:10 -05:00
Cole Robinson febd8bf4e5 Disable accelerators when serial console has focus (bz 1018822) 2013-12-18 16:31:48 -05:00
Cole Robinson c9680b34a1 ppc64 pseries guests use vga graphics, not qxl (bz 1034693) 2013-12-18 16:17:01 -05:00
Cole Robinson 9ce582c364 packageutils: Let packagekit front end show the error for us (bz 1034728) 2013-12-18 15:45:02 -05:00
Cole Robinson c20cb13173 Add forgotten po files 2013-12-18 15:42:24 -05:00
Cole Robinson 3ac0cb06ac error: Make sure labels aren't overly large 2013-12-18 15:42:02 -05:00
Cole Robinson 8bba6b5772 Update translations from RH translators 2013-12-16 19:50:24 -05:00
Cole Robinson 284cbe0000 Pull translations from transifex 2013-12-16 15:53:51 -05:00
Cole Robinson bd5b285eea virt-install: Drop inaccurate comment, update copyright date 2013-12-14 18:28:27 -05:00
Cole Robinson e57cd46904 spec: Require dbus-x11 (bz 1039803)
virt-manager is one of those tools that people will often install when
no traditional desktop is present. dbus-x11 is pulled in by desktop
environments, but not by gtk3 for (presumably) legitimate reasons.
But we need it to do anything worthwhile with dbus.
2013-12-14 12:02:47 -05:00
Cole Robinson 2a25c8d37d host: Print iscsi volume key as well in volume list
Suggested here: http://www.redhat.com/archives/virt-tools-list/2013-December/msg00014.html
2013-12-05 09:17:29 -05:00
Cole Robinson 70f1f8df1e storage: Parse volume key 2013-12-05 09:17:12 -05:00
Cole Robinson c351c8963a storage: Merge duplicate vol list populating 2013-12-04 19:01:52 -05:00
Cole Robinson 02f3546e02 testdriver: Add <filesystem> examples 2013-12-02 13:47:09 -05:00
Cole Robinson a9c42724cd tests: Limit recent clone changes to only very recent libvirt 2013-12-02 13:41:52 -05:00
Cole Robinson 6430065bde virt-manager: Drop semi incorrect comment about dropping stdio/stderr 2013-11-20 14:41:37 -05:00
Cole Robinson e7ed161f5a support: Use libvirt daemon version correctly
It should be the reference version for all libvirt checks if it exists.

Fixes AUTOSOCKET check for a remote RHEL6 hypervisor for example.
2013-11-19 17:02:51 -05:00
Cole Robinson 1ffcc0cced urlfetcher: Fix breakage after kernel err report fix 2013-11-10 11:35:22 -05:00
Cole Robinson bd782d5757 snapshots: Another s/State/VM State/ change 2013-11-10 11:17:12 -05:00
Cole Robinson de7144d216 create: Don't ask about changing perms if qemu is 'root' user 2013-11-10 11:09:22 -05:00
Cole Robinson 8b42bca801 urlfetcher: Fix error reporting if fetching kernel fails (bz 1017419) 2013-11-09 18:56:09 -05:00
Cole Robinson 8dcb65bd50 create: Fix default qemu-ga setup (bz 1016613)
We were adding default devices before setting the OS value, which qemu_ga
setup depends on.
2013-11-09 18:52:05 -05:00
Cole Robinson eb33bd34e7 Misc improvements to some debug messages 2013-11-09 18:17:29 -05:00
Cole Robinson fb3b5a277b snapshots: s/State/VM State/ (bz 1016604) 2013-11-09 18:00:00 -05:00
Cole Robinson bcfa8d287f serialcon: Release the text console when the VM window is closed (bz 1016445) 2013-11-09 17:54:47 -05:00
Cole Robinson 395a20edd8 virt-manager: Yet more fixes for DISPLAY unset error
Since these days we have to import Gtk _after_ forking, _and_ Gtk
doesn't raise a nice error for us, we need to postpone dropping stdio
so the user has any chance of seeing the error. Also try to add an
explicit error about DISPLAY again, since we don't get it from Gtk
these days.
2013-11-01 09:48:08 -04:00
Cole Robinson 2b564f524e Fix a string typo 2013-10-24 14:07:06 +01:00
Cole Robinson 1a88cef3af altlinux doesn't have installable URLs, clarify 2013-10-15 11:21:53 -04:00
Cole Robinson 6673123185 nodedev: Parse PCI iommuGroup 2013-10-10 09:41:49 -04:00
Cole Robinson 2301f19e4b asyncjob: Fix simple error callback 2013-10-09 17:41:08 -04:00
Cole Robinson 64b501cdc0 cliconfig: Fix parsing the configuration file 2013-10-08 14:42:59 -04:00
Cole Robinson cea22b17d7 storagebrowse: Fix signal cleanup after multiple runs 2013-10-08 10:23:15 -04:00
Cole Robinson a991c21d08 details: Fix reporting current VM cpus 2013-10-07 18:12:12 -04:00
Cole Robinson 79196cdfcf console: Fix console_active() logic 2013-10-06 15:30:01 -04:00
Cole Robinson 3f532fe263 VirtualDisk: Handle the blktap default
And cache the blktap lookup once for the localhost
2013-10-06 13:17:35 -04:00
Cole Robinson ef878a5d49 addhw: Fix a few issues with char dev combinations 2013-10-06 13:04:21 -04:00
Cole Robinson 102417ca0c addhw: Make sure to set device defaults 2013-10-06 13:00:30 -04:00
Cole Robinson 5945b8c4a1 connection: Drop redundant XML sanitizing 2013-10-06 13:00:30 -04:00
Cole Robinson 56b9f6187b Streamline support checks
Just use one function check_support
2013-10-06 10:08:04 -04:00
Cole Robinson d4103eac26 virt-install: Add '--console none' and '--channel none'
For skipping the default channel and default console behavior
2013-10-06 09:43:56 -04:00
Cole Robinson 18fa751059 Add qemu-guest-agent channel automatically for supported OS 2013-10-06 09:19:59 -04:00
Cole Robinson f44ad5ae05 Default to virtio console for supported OS
This could cause issues for people trying unattended non-graphical
kickstart installs and expecting ttyS0 in the guest to be hooked
up to the default console. So to get back the default behavior, you
can do:

  --console pty
2013-10-06 08:53:05 -04:00
Cole Robinson dae3678d26 guest: Absorb more default device checks 2013-10-06 08:30:33 -04:00
Cole Robinson 4911cb990e tests: Fix a rogue failure after last commits 2013-10-06 08:23:22 -04:00
Cole Robinson eede884554 guest: Set more involved clock defaults for qemu
The XML we use is:

  <clock offset="utc">
    <timer name="rtc" tickpolicy="catchup"/>
    <timer name="pit" tickpolicy="delay"/>
    <timer name="hpet" present="no"/>
  </clock>

Which translates to the qemu commands:

    -no-hpet -no-kvm-pit-reinjection -rtc driftfix=slew

The latter two bits are already used by openstack and gnome boxes by
default.

On RHEL hpet is compiled out so -no-hpet is the default,
but not everywhere else. Though recently the RH guys confirmed that
for regular usage it should be turned off because a) qemu support
is not that good, b) most users don't need it anyways c) it has
a performance penalty.

This default can be overridden from a virt-install command like

  --clock rtc_tickpolicy=delay

When Guest() sees that a timer has already been defined, it won't
set the new defaults, and that setting above is the old implied
default rtc setting.
2013-10-05 17:12:11 -04:00
Cole Robinson d0b067f2fc virt-install: Add --clock option 2013-10-05 16:48:07 -04:00
Cole Robinson a163f44a27 clock: Add timer parsing 2013-10-05 16:05:31 -04:00
Cole Robinson fdb79b9832 snapshots: Add a right click menu for start/stop 2013-10-05 14:57:58 -04:00
Cole Robinson 111f4353a3 snapshots: new: Grab name focus, make activate create the snapshot 2013-10-05 14:47:10 -04:00
Cole Robinson 89646fe841 addhw: Filter root hubs out of USB device list 2013-10-05 14:40:38 -04:00
Cole Robinson c5b5df8db2 storagebrowse: Select default pool on first run 2013-10-05 14:15:11 -04:00
Cole Robinson ff73f1119e details: If we know the channel target name, pretty list it 2013-10-05 14:04:49 -04:00
Cole Robinson 0366589812 Rip out all support for local RHEL6 version checks
These bits only apply if virt-manager is running directly on a RHEL6.
Since latest virt-manager can't do that thanks to GTK3 conversion,
just drop it all.
2013-10-05 13:57:55 -04:00
Cole Robinson 34f23165b6 addhw: Add channel option for auto socket allocation 2013-10-05 13:54:28 -04:00
Cole Robinson 5f1187e4c3 addhw: Don't show target_type for every char device 2013-10-05 13:33:55 -04:00
Cole Robinson 9d21d2bb02 addhw: List known channel names in a comboboxentry 2013-10-05 13:27:11 -04:00
Cole Robinson 24137cdfe9 addhw: Add 'console' option for adding virtio consoles 2013-10-05 13:22:53 -04:00
Cole Robinson f9fcac27a0 addhw: Don't advertise unused char types
Like vc, stdio, etc. They don't really have much use
2013-10-05 11:07:32 -04:00
Cole Robinson a3493c8a50 testdriver: Add some <console> devices 2013-10-05 11:07:05 -04:00
Cole Robinson 8e460dce1d create: Hide arch expander if there aren't any connections 2013-10-05 10:31:02 -04:00
Cole Robinson ca5e849ec6 create: Reset distro detection labels after each run 2013-10-05 10:29:16 -04:00
Cole Robinson 98187eb4b7 util: Fix generate_name start_num logic
We would start at start_num+1 which was confusing, fix it to do
the right thing.
2013-10-05 10:22:27 -04:00
Cole Robinson 20dfebeda3 clitest: Fix pylint, drop a few overkill tests 2013-10-05 10:22:11 -04:00
Cole Robinson 97f5717ef7 snapshots: Fix showing async dialogs for revert/delete 2013-10-05 10:03:56 -04:00
Cole Robinson 7c3c70d3d0 Remove gconf dep, Require dconf 2013-10-04 16:34:32 -04:00
Cole Robinson e7e97a8088 domain: If title present, print only it
Forcing the name to be in the picture reduces the usefulness IMO
2013-10-04 11:50:19 -04:00
Cole Robinson 3756235a72 testdriver: Fix snapshot metadata 2013-10-04 08:54:31 -04:00
Cole Robinson 6de06778d3 details: Convert disk UI from table to grid 2013-10-04 08:01:18 -04:00
Cole Robinson d83b2c02fa virt-manager: Add USB3 convenience option to the controller UI
and a --controller usb3 option to virt-install
2013-10-03 16:34:28 -04:00
Cole Robinson db6ef91b0b console: spice: don't set port=None
Can happen if defaultMode=secure, only a tlsport is allocated
2013-10-03 15:54:15 -04:00
Cole Robinson 5efd7c6d96 Add copyright to appdata file
http://blogs.gnome.org/hughsie/2013/10/01/copyright-in-appdata-files/
2013-10-03 14:18:23 -04:00
Cole Robinson 0bd2f97bda VirtualDisk: Try to append targets, not just use first free (bz #905439)
This used to happen:

- create VM with cdrom, cdrom gets hdc
- customize before install
- add new cdrom, gets target hda or hdb (first free target)
- new cdrom now has priority in the boot order

Change the logic to try to append targets first, and if there isn't
any space left, use the first free one. This may cause other issues
but we'll just have to wait and see.
2013-10-03 08:48:15 -04:00
Cole Robinson 5860b132dc tests: Add focused unit test for device numbering 2013-10-03 08:48:11 -04:00
Cole Robinson 0614e490c8 VirtualDisk: Don't try to force cdrom target=hdc
It was required a long long time ago, before qemu supported -drive
and possibly ancient xen. Nowadays it should be pointless, and contributes
to some issues like bz 905439
2013-10-02 20:31:57 -04:00
Cole Robinson e6cebd04ca virt-install: Fix launching console (after graphics rework) 2013-10-02 20:20:52 -04:00
Cole Robinson 475ec1252e virt-install: Allow --disk target
Shouldn't be needed often, but just in case
2013-10-02 20:15:49 -04:00
Cole Robinson 27298c8a80 addhw: Fix disk naming from 'customize' dialog (bz 744137) 2013-10-02 19:58:21 -04:00
Cole Robinson 2954995a28 domain: Fix deleting VM in test driver 2013-10-02 19:57:50 -04:00
Cole Robinson cda621548b Fix last remnants of default_graphics=vnc 2013-10-02 18:51:27 -04:00