Set the connection used by vmmCreateVolume everytime the window is made
visible. This fixes a case where volumes could be added to the wrong
pool if the same vmmCreateVolume window was already used on a different
connection.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
The commit b044dd renamed vmmStoragePool.uuid to vmmStoragePool._uuid,
causing this error:
Traceback (most recent call last):
File "virtManager/storagebrowse.py", line 280, in refresh_current_pool
self.refresh_storage_pool(None, cp.get_uuid())
File "virtManager/storagebrowse.py", line 243, in refresh_storage_pool
if curpool.uuid != uuid:
AttributeError: 'vmmStoragePool' object has no attribute 'uuid'
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
_close_serial_tab triggers the switch-page event and that can provoke a
refresh of the window. This causes an error everytime the details window
is pointing to a domain that was just deleted.
Solves: https://bugzilla.redhat.com/show_bug.cgi?id=985291
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
- Unify looking up osdict values
- Have Guest.py pass in its defaults, not encoding them in osdict
- Explicitly specify every device parameter that osdict handles, rather
than have some psuedo magic dictionary format to handle it
Once upon a time solaris entries has typename="unix", but were moved to
typename="solaris". We maintained a link to the unix type for back compat,
but now the distinction doesn't matter at all, so drop it.
In case of connection failure, the user can either maintain the connection
or modify it.
Split up `add_connection_to_ui' into `make_conn' and `register_conn'
to handle separately the object creation and its registration in the
list of connections (ui and conf).
Solves: https://bugzilla.redhat.com/show_bug.cgi?id=617386
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Currently, virt-manager supports adding spicevmc channel, and cannot add
channels with char device backends like pty or unix, which is often used by
guest agents. On the other hand, spicevmc shows up for serial and parallel
devices, that causes an error if chosen.
This enables virt-manager to add channels with a char device backend other
than spicevmc, and hides spicevmc from non-channel devices.
Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Due to all the negations for 'hide-unsupported-rhel-options' option in
configuration, there was missing 'not' in virt-manager when setting
relevant self.config variable. This patch changes it the same way as
in 'virtinst/__init__.py', which is right.
Now when a password is used a check box must be explicitely selected.
This enable the possibility to set an empty password "".
Solves: https://bugzilla.redhat.com/show_bug.cgi?id=749718
Signed-off-by: Giuseppe Scrivano <gscrivano@gnu.org>
(crobinso: fix minor pylint violation)
Our scheme for not unlinking a root node would cause issues if trying
to clear a @domain property when the root node was <domain>, even
if they are unrelated.
The commit efab27afbf02743a3a2582e9a111eb1b7d985b26 in libvirt uses
/dev/%s for logical pools, change the tests to accommodate it.
(crobinso: additional fix to work with older libvirt)
Commit 665375db was meant to fix the progress bar problems, but as
I've found out just made one race (which still persisted) a little
less probable. The real problem was in the upper code which meant to
finish the progress bar properly, however this was not done thanks to
'finally' statement being not executed when the function returned in
the 'try' part. This patch makes the upper caller wait for the
updating thread to finish and then properly end()s the progress bar's
output.
