Commit Graph

51 Commits

Author SHA1 Message Date
Cole Robinson
103c2e0da1 Convert UI files from glade to gtkbuilder
Glade is long since deprecated, and the 'glade' tool in F15 and up doesn't
even handle glade format files!

This effectively drops support for running virt-manager on a RHEL5 host,
which has a GTK that is too old to support gtkbuilder.

The process here was:
- On RHEL6, open all glade files with glade3, use Edit->Preferences to
  change format to gtk builder. (the gtk-builder-convert tool
  produced all sorts of brokenness, and f16 glade3 can't even open
  old glade files).
- Open these new files in glade on f16 and resave (since glade is
  notorious for reformatting files over new versions, saves churn
  the first time someone goes to patch the UI using a modern glade)
2012-02-02 14:17:50 -05:00
Cole Robinson
f42f3afe42 Add some debugging on dialog open/close 2012-01-31 18:16:54 -05:00
Cole Robinson
e863c0554d asyncjob: Some cleanups and simplifications 2012-01-27 21:46:12 -05:00
Cole Robinson
a1689d8873 asyncjob: Try and organize code layout a bit 2012-01-27 21:03:42 -05:00
Cole Robinson
235de4e398 asyncjob: Only register UI timer if we are showing dialog
Also fix some indentation
2012-01-27 20:51:46 -05:00
Cole Robinson
1de4c49f7a asyncjob: Rename run_main parameter to async
More clear what it's generally doing
2012-01-27 20:48:08 -05:00
Cole Robinson
5efe079158 Top level windows shouldn't be visible by default
Causes first run of dialogs to fail with a flicker on F16 KDE at least.

Choosecd also was using 'show' instead of 'present', which combined
with the first run fail meant that the dialog couldn't be displayed on
KDE :(

Also, the progress dialog was unconditionally shown, so this should fix
random flicker for quick operations, even in gnome.
2012-01-25 10:38:42 -05:00
Cole Robinson
5f22897f94 baseclass: Centralize exception reporting
Also add some checks to make sure subclasses always specify a proper
cleanup method
2011-07-23 21:16:54 -04:00
Cole Robinson
a84d10cee8 Add a smaller helper for self.window.get_widget
Saves us from having crazy long lines in a few places, and less characters
to type!
2011-07-14 13:13:13 -04:00
Cole Robinson
de8c901d7b Move idle wrappers to baseclass
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2011-04-18 11:13:33 -04:00
Cole Robinson
a29c25bcce config: Globally cache support_threading
It's specific to libvirt client library version, so won't change from
under us. Use it in simple async to preserve behavior for old libvirt clients
2011-04-14 15:43:31 -04:00
Cole Robinson
682c1d233b asyncjob: Simplify interface for simple_async 2011-04-14 15:28:22 -04:00
Cole Robinson
3d8e6a9398 Set parent for all dialogs 2011-04-14 08:47:42 -04:00
Cole Robinson
1180c9c4e3 asyncjob: Do some cleanup to allow object to be garbage collected
Also ensure we don't carry around references to other objects
2011-04-11 16:16:29 -04:00
Cole Robinson
f1c41b0866 error: Use more consistent details reporting
Always try and report summary + "\n\n" + details
2011-04-06 11:52:26 -04:00
Cole Robinson
e0bc2563c7 error: Simplify basic show_err call
If no error details are specified, use the traceback from the most recent
exception. We were doing this in numerous callers anyways.
2011-04-06 11:22:03 -04:00
Cole Robinson
f6868918fc Simplify asyncjob cancel callbacks
Have the async class check for a cancel exception and handle it
2010-12-10 14:59:24 -05:00
Cole Robinson
ec56a33f7c Run domain startup asynchronously
Sometimes startup is actually a domain restore, which can take a while, so
run it all async
2010-12-10 14:40:08 -05:00
Cole Robinson
677f73fca7 Run pep8 with check-pylint, fix the fallout 2010-12-10 11:47:07 -05:00
Cole Robinson
d0d20148f7 asyncjob: Simplify error reporting 2010-12-10 09:57:42 -05:00
Cole Robinson
e78e2da3f5 Use the a base class for all libvirt object classes 2010-12-09 12:37:48 -05:00
Cole Robinson
2dd81900fa Have UI classes share a baseclass 2010-12-08 17:26:19 -05:00
Cole Robinson
1608a08227 progress: Don't show busy pointer if we can cancel a job 2010-12-08 15:23:40 -05:00
Cole Robinson
41605b2d6f progress: Show cancel errors in the progress dialog 2010-12-08 14:14:38 -05:00
Wen Congyang
45fab0153f Support job cancellation for migration, save functions 2010-12-08 12:52:33 -05:00
Cole Robinson
1c3e7a1ea3 Remove some unneeded imports and old pylint workarounds 2010-11-30 15:01:02 -05:00
Cole Robinson
779dcdd824 Don't use old style __gobject_init__() 2010-11-30 14:40:49 -05:00
Cole Robinson
716bec3e56 Enable some more basic pylint checks and clean the code 2010-11-29 14:06:43 -05:00
Cole Robinson
fa876ac6ea progress: Allow storing return data with the async class 2010-03-03 11:14:59 -05:00
Cole Robinson
320eb9a3e1 progress: Allow running a thread which calls its own gtk.main() 2010-03-03 10:51:09 -05:00
Cole Robinson
dfb8f8666a Make sure all idle and timeout routines are thread safe.
Unbeknownst to me, these functions are not run thread safe:

http://library.gnome.org/devel/gdk/unstable/gdk-Threads.html

However since they are run from the main loop, the chance of them conflicting
with another running thread is slim, since we have very few threads that
actually update the UI.
2010-02-11 12:32:00 -05:00
Cole Robinson
9fc947a314 A few more small UI tweaks
- Actually make console border black
- Don't set overly large progress bar values in asyncjob
- Use larger icon in progress dialog.
2009-12-03 13:36:28 -05:00
Cole Robinson
f9680aa8e0 Store errors in asyncjob instances.
This allows us to remove all the hackish global error reporting variables
whenever we run an async job.
2009-04-03 14:15:15 -04:00
Cole Robinson
7b24154f19 Don't leave app hanging around if user closes it while an async job is in
progress.
2009-04-03 14:15:14 -04:00
Cole Robinson
0187458ba9 Fix up various remaining pylint. 2008-11-18 17:01:22 -05:00
Daniel P. Berrange
847084ab23 Refresh GPL text with latest FSF address & fix spec file license tag 2007-11-20 11:12:20 -05:00
Daniel P. Berrange
25902bfe27 Fixed thread locking in async job callback 2007-04-13 16:01:03 -04:00
Hugh O. Brock
c2c259f2a0 Make console popups work right with inactive domains by adding a 'vm-started' signal thrown by vmmConnection. Also fix another threading bug. 2007-03-14 15:51:26 -04:00
Daniel P. Berrange
0c47d4251c Fixed timer ticks 2007-03-13 11:48:19 -04:00
Daniel P. Berrange
9650bb48b1 Fixed thread locking 2007-03-09 16:22:43 -05:00
Hugh O. Brock
6350cb33ea Split the glade files up into one per window, to make managing merges easier. This changes the makefile, so you'll need to rerun autogen.sh 2007-02-15 15:35:37 -05:00
Daniel P. Berrange
862ca28ea6 Make progress bar display a little prettier. Add support for setting max-memory when creating guests 2007-02-01 14:16:44 -05:00
Hugh O. Brock
4e647f1c17 Change save/restore code to work with new progress bar interface. Also clean up progress bar a bit so it doesn't jump around quite so much. 2007-01-12 15:39:18 -05:00
Hugh O. Brock
c6e5a99343 graphical progress bar hooks for pv guests 2007-01-10 16:11:57 -05:00
Hugh O. Brock
7b2cbb18ad add a radio button for sparse vs. non-sparse viles. Add appropriate cautions and text to the progress dialog. 2006-12-17 16:33:37 -05:00
Daniel P. Berrange
54316cd4f2 Explicitly pass i18n domain into glade constructor because it is failing to pick up default domain 2006-11-07 09:40:34 -05:00
Daniel P. Berrange
6cc3c10a18 Set busy cursor when displaying progress bar 2006-11-06 15:00:39 -05:00
Hugh O. Brock
0a1906936f Added error dialog for domain restore errors 2006-07-24 13:50:11 -04:00
Hugh O. Brock
d4fea88493 Add save feature to console, update save icons 2006-07-20 13:38:37 -04:00
Daniel P. Berrange
caecbc5ebc Fix timer callback return value to ensure it fires many times rather than just once 2006-07-20 12:52:00 -04:00