feat(vm/host/pools/sr): add tooltips. Fixes #1568

src/common/intl/messages.js

@@ -435,6 +435,9 @@ var messages = {
   pdbStatus: 'Status',
   pbdStatusConnected: 'Connected',
   pbdStatusDisconnected: 'Disconnected',
+  pbdConnect: 'Connect',
+  pbdDisconnect: 'Disconnect',
+  pbdForget: 'Forget',
   srShared: 'Shared',
   srNotShared: 'Not shared',
   pbdNoSr: 'No storage detected',
@@ -560,12 +563,16 @@ var messages = {
   vifStatusLabel: 'Status',
   vifStatusConnected: 'Connected',
   vifStatusDisconnected: 'Disconnected',
+  vifConnect: 'Connect',
+  vifDisconnect: 'Disconnect',
+  vifRemove: 'Remove',
   vifIpAddresses: 'IP addresses',
   vifMacAutoGenerate: 'Auto-generated if empty',
   vifAllowedIps: 'Allowed IPs',
   vifNoIps: 'No IPs',
-  vifLockedNetwork: 'Network is locked',
-  vifLockedNetworkNoIps: 'Network is locked and no IPs are allowed for this interface',
+  vifLockedNetwork: 'Network locked',
+  vifLockedNetworkNoIps: 'Network locked and no IPs are allowed for this interface',
+  vifUnLockedNetwork: 'Network not locked',
 
   // ----- VM snapshot tab -----
   noSnapshots: 'No snapshots',

src/xo-app/host/tab-network.js

@@ -101,16 +101,18 @@ export default connectStore(() => ({
                       <ActionRowButton
                         btnStyle='default'
                         disabled={pif.attached && (pif.management || pif.disallowUnplug)}
-                        icon={pif.attached ? 'disconnect' : 'connect'}
                         handler={pif.attached ? disconnectPif : connectPif}
                         handlerParam={pif}
+                        icon={pif.attached ? 'disconnect' : 'connect'}
+                        tooltip={pif.attached ? _('disconnectPif') : _('connectPif')}
                       />
                       <ActionRowButton
                         btnStyle='default'
                         disabled={pif.physical || pif.disallowUnplug || pif.management}
-                        icon='delete'
                         handler={deletePif}
                         handlerParam={{ pif }}
+                        icon='delete'
+                        tooltip={_('deletePif')}
                       />
                     </ButtonGroup>
                   </td>

src/xo-app/host/tab-storage.js

@@ -72,9 +72,10 @@ export default ({
                         <ButtonGroup className='pull-xs-right'>
                           <ActionRowButton
                             btnStyle='default'
-                            icon='disconnect'
                             handler={disconnectPbd}
                             handlerParam={pbd}
+                            icon='disconnect'
+                            tooltip={_('pbdDisconnect')}
                           />
                         </ButtonGroup>
                       </span>
@@ -85,15 +86,17 @@ export default ({
                         <ButtonGroup className='pull-xs-right'>
                           <ActionRowButton
                             btnStyle='default'
-                            icon='connect'
                             handler={connectPbd}
                             handlerParam={pbd}
+                            icon='connect'
+                            tooltip={_('pbdConnect')}
                           />
                           <ActionRowButton
                             btnStyle='default'
-                            icon='sr-forget'
                             handler={deletePbd}
                             handlerParam={pbd}
+                            icon='sr-forget'
+                            tooltip={_('pbdForget')}
                           />
                         </ButtonGroup>
                       </span>

src/xo-app/pool/tab-network.js

@@ -75,9 +75,10 @@ class PifItem extends Component {
           <ActionRowButton
             btnStyle='default'
             disabled={disableUnplug(pif)}
-            icon={pif.attached ? 'disconnect' : 'connect'}
             handler={pif.attached ? disconnectPif : connectPif}
             handlerParam={pif}
+            icon={pif.attached ? 'disconnect' : 'connect'}
+            tooltip={pif.attached ? _('disconnectPif') : _('connectPif')}
           />
         </ButtonGroup>
       </td>
@@ -163,6 +164,7 @@ const NETWORKS_COLUMNS = [
         handler={deleteNetwork}
         handlerParam={network}
         icon='delete'
+        tooltip={_('deleteNetwork')}
       />
     </ButtonGroup>
   }

src/xo-app/sr/tab-host.js

@@ -44,9 +44,10 @@ const HOST_COLUMNS = [
             <ButtonGroup className='pull-xs-right'>
               <ActionRowButton
                 btnStyle='warning'
-                icon='disconnect'
                 handler={disconnectPbd}
                 handlerParam={pbd}
+                icon='disconnect'
+                tooltip={_('pbdDisconnect')}
               />
             </ButtonGroup>
           </span>
@@ -61,15 +62,17 @@ const HOST_COLUMNS = [
           <ButtonGroup className='pull-xs-right'>
             <ActionRowButton
               btnStyle='default'
-              icon='connect'
               handler={connectPbd}
               handlerParam={pbd}
+              icon='connect'
+              tooltip={_('pbdConnect')}
             />
             <ActionRowButton
               btnStyle='default'
-              icon='sr-forget'
               handler={deletePbd}
               handlerParam={pbd}
+              icon='sr-forget'
+              tooltip={_('pbdForget')}
             />
           </ButtonGroup>
         </span>

src/xo-app/vm/tab-network.js

@@ -311,9 +311,10 @@ export default class TabNetwork extends Component {
                             </span>
                             <ButtonGroup className='pull-xs-right'>
                               <ActionRowButton
-                                icon='disconnect'
                                 handler={disconnectVif}
                                 handlerParam={vif}
+                                icon='disconnect'
+                                tooltip={_('vifDisconnect')}
                               />
                             </ButtonGroup>
                           </span>
@@ -324,15 +325,17 @@ export default class TabNetwork extends Component {
                             <ButtonGroup className='pull-xs-right'>
                               {isVmRunning(vm) &&
                                 <ActionRowButton
-                                  icon='connect'
                                   handler={connectVif}
                                   handlerParam={vif}
+                                  icon='connect'
+                                  tooltip={_('vifConnect')}
                                 />
                               }
                               <ActionRowButton
-                                icon='remove'
                                 handler={deleteVif}
                                 handlerParam={vif}
+                                icon='remove'
+                                tooltip={_('vifRemove')}
                               />
                             </ButtonGroup>
                           </span>
@@ -347,7 +350,9 @@ export default class TabNetwork extends Component {
                           : <Tooltip content={_('vifLockedNetwork')}>
                             <Icon icon='lock' />
                           </Tooltip>
-                        ) : <Icon icon='unlock' />}
+                        ) : <Tooltip content={_('vifUnLockedNetwork')}>
+                          <Icon icon='unlock' />
+                        </Tooltip>}
                       </td>
                     </tr>
                   })}