fix(xo-web/network): fix inability to create bonded network (#4489)

Fixes xoa-support#1725

CHANGELOG.unreleased.md

@@ -15,6 +15,7 @@
 - [PBD] Obfuscate cifs password from device config [#4384](https://github.com/vatesfr/xen-orchestra/issues/4384) (PR [#4401](https://github.com/vatesfr/xen-orchestra/pull/4401))
 - [XOSAN] Fix "invalid parameters" error on creating a SR (PR [#4478](https://github.com/vatesfr/xen-orchestra/pull/4478))
 - [Patching] Avoid overloading XCP-ng by reducing the frequency of yum update checks [#4358](https://github.com/vatesfr/xen-orchestra/issues/4358) (PR [#4477](https://github.com/vatesfr/xen-orchestra/pull/4477))
+- [Network] Fix inability to create a bonded network (PR [#4489](https://github.com/vatesfr/xen-orchestra/pull/4489))
 
 > Users must be able to say: “I had this issue, happy to know it's fixed”
 

packages/xo-web/src/xo-app/new/network/index.js

@@ -188,12 +188,6 @@ const NewNetwork = decorate([
         pifs,
         vlan,
       } = state
-      const poolIds = [pool.id]
-      const pifIds = [pif.id]
-      for (const network of networks) {
-        poolIds.push(network.pool.id)
-        pifIds.push(network.pif.id)
-      }
       return bonded
         ? createBondedNetwork({
             bondMode: bondMode.value,
@@ -205,13 +199,21 @@ const NewNetwork = decorate([
           })
         : isPrivate
         ? networks.length > 0
-          ? createCrossPoolPrivateNetwork({
-              xoPoolIds: poolIds,
-              networkName: name,
-              networkDescription: description,
-              encapsulation: encapsulation,
-              xoPifIds: pifIds,
-            })
+          ? (() => {
+              const poolIds = [pool.id]
+              const pifIds = [pif.id]
+              for (const network of networks) {
+                poolIds.push(network.pool.id)
+                pifIds.push(network.pif.id)
+              }
+              return createCrossPoolPrivateNetwork({
+                xoPoolIds: poolIds,
+                networkName: name,
+                networkDescription: description,
+                encapsulation: encapsulation,
+                xoPifIds: pifIds,
+              })
+            })()
           : createPrivateNetwork({
               poolId: pool.id,
               networkName: name,