fix(xo-server/network.set): missing param definition (#4510)

Fixes #4514

See https://xcp-ng.org/forum/topic/962/why-are-you-using-xcp-ng-center/96

CHANGELOG.unreleased.md

@@ -19,6 +19,7 @@
 - [VM/Advanced] Fix `"vm.set_domain_type" is not a function` error on switching virtualization mode (PV/HVM) [#4348](https://github.com/vatesfr/xen-orchestra/issues/4348) (PR [#4504](https://github.com/vatesfr/xen-orchestra/pull/4504))
 - [Backup NG/logs] Show warning when zstd compression is selected but not supported [#3892](https://github.com/vatesfr/xen-orchestra/issues/3892) (PR [#4375](https://github.com/vatesfr/xen-orchestra/pull/4375)
 - [Patches] Fix patches installation for CH 8.0 (PR [#4511](https://github.com/vatesfr/xen-orchestra/pull/4511))
+- [Network] Fix inability to set a network name [#4514](https://github.com/vatesfr/xen-orchestra/issues/4514) (PR [4510](https://github.com/vatesfr/xen-orchestra/pull/4510))
 
 ### Released packages
 

packages/xo-server-test/src/_xoConnection.js

@@ -116,6 +116,16 @@ class XoConnection extends Xo {
     return job
   }
 
+  async createTempNetwork(params) {
+    const id = await this.call('network.create', {
+      name: 'XO Test',
+      pool: config.pools.default,
+      ...params,
+    })
+    this._tempResourceDisposers.push('network.delete', { id })
+    return this.getOrWaitObject(id)
+  }
+
   async createTempVm(params) {
     const id = await this.call('vm.create', {
       name_label: 'XO Test',

packages/xo-server-test/src/issues/index.spec.js

@@ -25,6 +25,20 @@ describe('issue', () => {
     })
   })
 
+  test('4514', async () => {
+    await xo.createTempServer(config.servers.default)
+
+    const oldName = 'Old XO Test name'
+    const { id, name_label } = await xo.createTempNetwork({ name: oldName })
+    expect(name_label).toBe(oldName)
+
+    const newName = 'New XO Test name'
+    await xo.call('network.set', { id, name_label: newName })
+    await xo.waitObjectState(id, ({ name_label }) => {
+      expect(name_label).toBe(newName)
+    })
+  })
+
   test('4523', async () => {
     const id = await xo.call('network.create', {
       name: 'XO Test',

packages/xo-server/src/api/network.js

@@ -119,6 +119,9 @@ set.params = {
     type: 'boolean',
     optional: true,
   },
+  id: {
+    type: 'string',
+  },
   name_description: {
     type: 'string',
     optional: true,