update implementation

Fixes #3195

This PR removes subtasks from markdown

docs/manage_infrastructure.md

@@ -320,6 +320,7 @@ You can learn more about XenServer [resource management on the Citrix Website](h
 :::tip
 XCP-ng doesn't limit VMs to 32 vCPU
 :::
+
 ### VDI live migration
 
 Thanks to Xen Storage Motion, it's easy to move a VM disk from one storage location to another, while the VM is running! This feature can help you migrate from your local storage to a SAN, or just upgrade your SAN without any downtime.
@@ -492,9 +493,11 @@ If you are behind a proxy, please update your `xo-server` configuration to add a
 As specified in the [documentation](https://xcp-ng.org/docs/requirements.html#pool-requirements) your pool shouldn't consist of hosts from different CPU vendors.
 :::
 ::: warning
+
 - Even with matching CPU vendors, in the case of different CPU models XCP-ng will scale the pool CPU ability to the CPU having the least instructions.
 - All the hosts in a pool must run the same XCP-ng version.
-:::
+  :::
+
 ### Creating a pool
 
 First you should add your new host to XOA by going to New > Server as described in [the relevant chapter](manage_infrastructure.md#add-a-host).

packages/xo-server-backup-reports/src/index.js

@@ -375,10 +375,22 @@ class BackupReportsXoPlugin {
       })
     }
 
-    const failedTasksText = []
-    const skippedVmsText = []
-    const successfulVmsText = []
-    const interruptedVmsText = []
+    const failedVmsText = {
+      default: [],
+      compact: [],
+    }
+    const skippedVmsText = {
+      default: [],
+      compact: [],
+    }
+    const successfulVmsText = {
+      default: [],
+      compact: [],
+    }
+    const interruptedVmsText = {
+      default: [],
+      compact: [],
+    }
     const nagiosText = []
 
     let globalMergeSize = 0
@@ -393,8 +405,10 @@ class BackupReportsXoPlugin {
 
       const { type, id } = taskLog.data ?? {}
       if (taskLog.message === 'get SR record' || taskLog.message === 'get remote adapter') {
+        const text = []
+
         ++nFailures
-        failedTasksText.push(
+        text.push(
           // It will ensure that it will never be in a nested list
           ''
         )
@@ -402,25 +416,29 @@ class BackupReportsXoPlugin {
         try {
           if (type === 'SR') {
             const { name_label: name, uuid } = xo.getObject(id)
-            failedTasksText.push(`### ${name}`, '', `- **UUID**: ${uuid}`)
+            text.push(`### ${name}`, '', `- **UUID**: ${uuid}`)
             nagiosText.push(`[(${type} failed) ${name} : ${taskLog.result.message} ]`)
           } else {
             const { name } = await xo.getRemote(id)
-            failedTasksText.push(`### ${name}`, '', `- **UUID**: ${id}`)
+            text.push(`### ${name}`, '', `- **UUID**: ${id}`)
             nagiosText.push(`[(${type} failed) ${name} : ${taskLog.result.message} ]`)
           }
         } catch (error) {
           logger.warn(error)
-          failedTasksText.push(`### ${UNKNOWN_ITEM}`, '', `- **UUID**: ${id}`)
+          text.push(`### ${UNKNOWN_ITEM}`, '', `- **UUID**: ${id}`)
           nagiosText.push(`[(${type} failed) ${id} : ${taskLog.result.message} ]`)
         }
 
-        failedTasksText.push(
+        text.push(
           `- **Type**: ${type}`,
           ...getTemporalDataMarkdown(taskLog.end, taskLog.start, formatDate),
           ...getWarningsMarkdown(taskLog.warnings),
           `- **Error**: ${taskLog.result.message}`
         )
+
+        failedVmsText.default.push(...text)
+        failedVmsText.compact.push(...text)
+
         continue
       }
 
@@ -537,32 +555,39 @@ class BackupReportsXoPlugin {
       if (taskLog.result !== undefined) {
         if (taskLog.status === 'skipped') {
           ++nSkipped
-          skippedVmsText.push(
+          const common = [
             ...text,
             `- **Reason**: ${
               taskLog.result.message === UNHEALTHY_VDI_CHAIN_ERROR
                 ? UNHEALTHY_VDI_CHAIN_MESSAGE
                 : taskLog.result.message
-            }`
-          )
+            }`,
+          ]
+          skippedVmsText.default.push(...common)
+          skippedVmsText.compact.push(...common)
           nagiosText.push(`[(Skipped) ${vm !== undefined ? vm.name_label : 'undefined'} : ${taskLog.result.message} ]`)
         } else {
           ++nFailures
-          failedTasksText.push(...text, `- **Error**: ${taskLog.result.message}`)
+          const common = [...text, `- **Error**: ${taskLog.result.message}`]
+          failedVmsText.default.push(...common)
+          failedVmsText.compact.push(...common)
 
           nagiosText.push(`[(Failed) ${vm !== undefined ? vm.name_label : 'undefined'} : ${taskLog.result.message} ]`)
         }
       } else {
         if (taskLog.status === 'failure') {
           ++nFailures
-          failedTasksText.push(...text, ...subText)
+          failedVmsText.default.push(...text, ...subText)
+          failedVmsText.compact.push(...text)
           nagiosText.push(`[${vm !== undefined ? vm.name_label : 'undefined'}: (failed)[${failedSubTasks.toString()}]]`)
         } else if (taskLog.status === 'interrupted') {
           ++nInterrupted
-          interruptedVmsText.push(...text, ...subText)
+          interruptedVmsText.default.push(...text, ...subText)
+          interruptedVmsText.compact.push(...text)
           nagiosText.push(`[(Interrupted) ${vm !== undefined ? vm.name_label : 'undefined'}]`)
         } else {
-          successfulVmsText.push(...text, ...subText)
+          successfulVmsText.default.push(...text, ...subText)
+          successfulVmsText.compact.push(...text)
         }
       }
     }
@@ -582,27 +607,37 @@ class BackupReportsXoPlugin {
       ...getWarningsMarkdown(log.warnings),
       '',
     ]
+    const slackMarkdown = [...markdown]
 
     if (nFailures !== 0) {
-      markdown.push('---', '', `## ${nFailures} Failure${nFailures === 1 ? '' : 's'}`, '', ...failedTasksText)
+      const common = ['---', '', `## ${nFailures} Failure${nFailures === 1 ? '' : 's'}`, '']
+      markdown.push(...common, ...failedVmsText.default)
+      slackMarkdown.push(...common, ...failedVmsText.compact)
     }
 
     if (nSkipped !== 0) {
-      markdown.push('---', '', `## ${nSkipped} Skipped`, '', ...skippedVmsText)
+      const common = ['---', '', `## ${nSkipped} Skipped`, '']
+      markdown.push(...common, ...skippedVmsText.default)
+      slackMarkdown.push(...common, ...skippedVmsText.compact)
     }
 
     if (nInterrupted !== 0) {
-      markdown.push('---', '', `## ${nInterrupted} Interrupted`, '', ...interruptedVmsText)
+      const common = ['---', '', `## ${nInterrupted} Interrupted`, '']
+      markdown.push(...common, ...interruptedVmsText.default)
+      slackMarkdown.push(...common, ...interruptedVmsText.compact)
     }
 
     if (nSuccesses !== 0 && (force || reportWhen !== 'failure')) {
-      markdown.push('---', '', `## ${nSuccesses} Success${nSuccesses === 1 ? '' : 'es'}`, '', ...successfulVmsText)
+      const common = ['---', '', `## ${nSuccesses} Success${nSuccesses === 1 ? '' : 'es'}`, '']
+      markdown.push(...common, ...successfulVmsText.default)
+      slackMarkdown.push(...common, ...successfulVmsText.compact)
     }
 
     markdown.push('---', '', `*${pkg.name} v${pkg.version}*`)
     return this._sendReport({
       mailReceivers,
       markdown: toMarkdown(markdown),
+      slackMarkdown: toMarkdown(slackMarkdown),
       subject: `[Xen Orchestra] ${log.status} − Backup report for ${jobName} ${STATUS_ICON[log.status]}`,
       success: log.status === 'success',
       nagiosMarkdown:
@@ -614,7 +649,7 @@ class BackupReportsXoPlugin {
     })
   }
 
-  _sendReport({ mailReceivers, markdown, nagiosMarkdown, subject, success }) {
+  _sendReport({ mailReceivers, markdown, slackMarkdown = markdown, nagiosMarkdown, subject, success }) {
     if (mailReceivers === undefined || mailReceivers.length === 0) {
       mailReceivers = this._mailsReceivers
     }
@@ -634,7 +669,7 @@ class BackupReportsXoPlugin {
         }),
       xo.sendSlackMessage !== undefined &&
         xo.sendSlackMessage({
-          message: markdown,
+          message: slackMarkdown,
         }),
       xo.sendPassiveCheck !== undefined &&
         xo.sendPassiveCheck({