fix(backups): better detection of looped vhd chain

2024-02-09 16:36:28 +00:00
2 changed files with 8 additions and 0 deletions
--- a/@xen-orchestra/backups/_cleanVm.mjs
+++ b/@xen-orchestra/backups/_cleanVm.mjs
@@ -432,6 +432,13 @@ export async function cleanVm(
      if (child !== undefined) {
        const chain = getUsedChildChainOrDelete(child)
        if (chain !== undefined) {
+          if (chain.includes(vhd)) {
+            logWarn('loop vhd chain', { path: vhd })
+            // keep  the current chain
+            // note that a VHD can't have two children, that means that
+            // a looped one is always the last of a chain
+            return chain
+          }
          chain.unshift(vhd)
          return chain
        }
--- a/CHANGELOG.unreleased.md
+++ b/CHANGELOG.unreleased.md
@@ -29,6 +29,7 @@

 <!--packages-start-->

+- @xen-orchestra/backups patch
 - xo-server patch

 <!--packages-end-->