fix(s3): retry upload even on error 400

2022-09-22 16:08:02 +02:00
2 changed files with 3 additions and 1 deletions
--- a/@xen-orchestra/fs/src/s3.js
+++ b/@xen-orchestra/fs/src/s3.js
@@ -223,7 +223,7 @@ export default class S3Handler extends RemoteHandlerAbstract {
  // https://www.backblaze.com/b2/docs/calling.html#error_handling
  @decorateWith(pRetry.wrap, {
    delays: [100, 200, 500, 1000, 2000],
-    when: e => e.$metadata?.httpStatusCode === 500,
+    when: e => [500, 400].includes(e.$metadata?.httpStatusCode),
    onRetry(error) {
      warn('retrying writing file', {
        attemptNumber: this.attemptNumber,
--- a/CHANGELOG.unreleased.md
+++ b/CHANGELOG.unreleased.md
@@ -21,6 +21,7 @@
 - [Tasks] Fix the pool filter that did not display tasks even if they existed (PR [#6424](https://github.com/vatesfr/xen-orchestra/pull/6424))
 - [Tasks] Fix tasks being displayed for all users (PR [#6422](https://github.com/vatesfr/xen-orchestra/pull/6422))
 - [Storage/advanced] Fix the display of VDI to coalesce [#6334](https://xcp-ng.org/forum/topic/6334/coalesce-not-showing-anymore) (PR [#6429](https://github.com/vatesfr/xen-orchestra/pull/6429))
+- [Backup/S3] Retry upload when receiving a error 400 from remote (PR [#6433](https://github.com/vatesfr/xen-orchestra/pull/6433))

 ### Packages to release

@@ -40,6 +41,7 @@

 - @vates/fuse-vhd major
 - @xen-orchestra/backups minor
+- @xen-orchestra/fs patch
 - vhd-lib minor
 - xo-server-auth-saml patch
 - xo-server minor