0.3.2

nodemailer 2.7.0 breaks Node 4 compatibility

packages/xo-server-transport-email/.editorconfig

@@ -11,7 +11,7 @@ root = true
 charset = utf-8
 end_of_line = lf
 insert_final_newline = true
-trim_trailing_whitespaces = true
+trim_trailing_whitespace = true
 
 # CoffeeScript
 #
@@ -28,12 +28,12 @@ indent_style = space
 # Package.json
 #
 # This indentation style is the one used by npm.
-[/package.json]
+[package.json]
 indent_size = 2
 indent_style = space
 
-# Jade
-[*.jade]
+# Pug (Jade)
+[*.{jade,pug}]
 indent_size = 2
 indent_style = space
 
@@ -41,7 +41,7 @@ indent_style = space
 #
 # Two spaces seems to be the standard most common style, at least in
 # Node.js (http://nodeguide.com/style.html#tabs-vs-spaces).
-[*.js]
+[*.{js,jsx,ts,tsx}]
 indent_size = 2
 indent_style = space
 

packages/xo-server-transport-email/.gitignore

@@ -1,6 +1,9 @@
-/.nyc_output/
+/coverage/
 /dist/
 /node_modules/
 
 npm-debug.log
 npm-debug.log.*
+pnpm-debug.log
+pnpm-debug.log.*
+yarn-error.log

packages/xo-server-transport-email/.npmignore

@@ -1,10 +1,24 @@
+/benchmark/
+/benchmarks/
+*.bench.js
+*.bench.js.map
+
 /examples/
 example.js
 example.js.map
 *.example.js
 *.example.js.map
 
+/fixture/
+/fixtures/
+*.fixture.js
+*.fixture.js.map
+*.fixtures.js
+*.fixtures.js.map
+
 /test/
 /tests/
 *.spec.js
 *.spec.js.map
+
+__snapshots__/

packages/xo-server-transport-email/.travis.yml

@@ -1,8 +1,8 @@
 language: node_js
 node_js:
-  - 'stable'
-  - '4'
-  - '0.12'
+  - stable
+  - 6
+  - 4
 
 # Use containers.
 # http://docs.travis-ci.com/user/workers/container-based-infrastructure/

packages/xo-server-transport-email/README.md

@@ -1,13 +1,13 @@
 # xo-server-transport-email [![Build Status](https://travis-ci.org/vatesfr/xo-server-transport-email.png?branch=master)](https://travis-ci.org/vatesfr/xo-server-transport-email)
 
-> ${pkg.description}
+> xo-server plugin to send emails
 
 ## Install
 
 Installation of the [npm package](https://npmjs.org/package/xo-server-transport-email):
 
 ```
-> npm install --global xo-server-auth-email
+> npm install --global xo-server-transport-email
 ```
 
 ## Usage
@@ -17,24 +17,21 @@ the web iterface, see [the plugin documentation](https://xen-orchestra.com/docs/
 
 ## Development
 
-### Installing dependencies
-
 ```
+# Install dependencies
 > npm install
-```
 
-### Compilation
+# Run the tests
+> npm test
 
-The sources files are watched and automatically recompiled on changes.
-
-```
+# Continuously compile
 > npm run dev
-```
 
-### Tests
+# Continuously run the tests
+> npm run dev-test
 
-```
-> npm run test-dev
+# Build for production (automatically called by npm install)
+> npm run build
 ```
 
 ## Contributions
@@ -44,7 +41,7 @@ the code.
 
 You may:
 
-- report any [issue](https://google.com/vatesfr/xo-server-transport-email/issues)
+- report any [issue](https://github.com/vatesfr/xo-server-transport-email/issues)
   you've encountered;
 - fork and create a pull request.
 

packages/xo-server-transport-email/package.json

@@ -1,18 +1,21 @@
 {
   "name": "xo-server-transport-email",
-  "version": "0.1.0",
+  "version": "0.3.2",
   "license": "AGPL-3.0",
-  "description": "",
+  "description": "xo-server plugin to send emails",
   "keywords": [
-    "xo-server",
     "email",
-    "mail"
+    "mail",
+    "orchestra",
+    "xen",
+    "xen-orchestra",
+    "xo-server"
   ],
-  "homepage": "https://google.com/vatesfr/xo-server-transport-email",
-  "bugs": "https://google.com/vatesfr/xo-server-transport-email/issues",
+  "homepage": "https://github.com/vatesfr/xo-server-transport-email",
+  "bugs": "https://github.com/vatesfr/xo-server-transport-email/issues",
   "repository": {
     "type": "git",
-    "url": "https://google.com/vatesfr/xo-server-transport-email"
+    "url": "https://github.com/vatesfr/xo-server-transport-email"
   },
   "author": {
     "name": "Julien Fontanet",
@@ -25,45 +28,64 @@
     "dist/"
   ],
   "engines": {
-    "node": ">=0.12"
+    "node": ">=4"
   },
   "dependencies": {
-    "nodemailer": "^2.4.2",
-    "nodemailer-markdown": "^1.0.0",
-    "promise-toolbox": "^0.4.0"
+    "lodash": "^4.17.4",
+    "nodemailer": "2.6.4",
+    "nodemailer-markdown": "^1.0.1",
+    "promise-toolbox": "^0.8.0"
   },
   "devDependencies": {
-    "babel-cli": "^6.10.1",
-    "babel-eslint": "^6.1.0",
-    "babel-preset-es2015": "^6.9.0",
-    "babel-preset-stage-0": "^6.5.0",
-    "dependency-check": "^2.5.1",
-    "ghooks": "^1.2.4",
-    "standard": "^7.1.2"
+    "babel-cli": "^6.18.0",
+    "babel-eslint": "^7.1.1",
+    "babel-plugin-lodash": "^3.2.11",
+    "babel-preset-env": "^1.1.8",
+    "babel-preset-stage-3": "^6.17.0",
+    "cross-env": "^3.1.4",
+    "dependency-check": "^2.7.0",
+    "husky": "^0.12.0",
+    "jest": "^18.1.0",
+    "rimraf": "^2.5.4",
+    "standard": "^8.6.0"
   },
   "scripts": {
-    "build": "NODE_ENV=production babel --source-maps --out-dir=dist/ src/",
-    "depcheck": "dependency-check ./package.json",
-    "dev": "babel --watch --source-maps --out-dir=dist/ src/",
-    "lint": "standard",
-    "posttest": "npm run lint && npm run depcheck",
-    "prepublish": "npm run build"
+    "build": "cross-env NODE_ENV=production babel --source-maps --out-dir=dist/ src/",
+    "commit-msg": "npm test",
+    "dev": "cross-env NODE_ENV=development babel --watch --source-maps --out-dir=dist/ src/",
+    "dev-test": "jest --bail --watch",
+    "posttest": "standard && dependency-check ./package.json",
+    "prebuild": "rimraf dist/",
+    "predev": "npm run prebuild",
+    "prepublish": "npm run build",
+    "test": "jest"
   },
   "babel": {
+    "plugins": [
+      "lodash"
+    ],
     "presets": [
-      "stage-0",
-      "es2015"
+      [
+        "env",
+        {
+          "targets": {
+            "node": 4
+          }
+        }
+      ],
+      "stage-3"
     ]
   },
+  "jest": {
+    "testPathDirs": [
+      "<rootDir>/src"
+    ],
+    "testRegex": "\\.spec\\.js$"
+  },
   "standard": {
     "ignore": [
       "dist"
     ],
     "parser": "babel-eslint"
-  },
-  "config": {
-    "ghooks": {
-      "commit-msg": "npm test"
-    }
   }
 }

packages/xo-server-transport-email/src/index.js

@@ -1,3 +1,4 @@
+import { bind } from 'lodash'
 import { createTransport } from 'nodemailer'
 import { markdown as nodemailerMarkdown } from 'nodemailer-markdown'
 import { promisify } from 'promise-toolbox'
@@ -23,10 +24,12 @@ export const configurationSchema = {
 
       properties: {
         name: {
-          type: 'string'
+          type: 'string',
+          description: 'human readable name of the sender'
         },
         address: {
-          type: 'string'
+          type: 'string',
+          description: 'email address of the sender'
         }
       },
 
@@ -93,12 +96,26 @@ export const configurationSchema = {
   required: ['from', 'transport']
 }
 
+export const testSchema = {
+  type: 'object',
+
+  properties: {
+    to: {
+      type: 'string',
+      description: 'recipient of the test mail'
+    }
+  },
+
+  additionalProperties: false,
+  required: ['to']
+}
+
 // ===================================================================
 
 class TransportEmailPlugin {
-  constructor (xo) {
-    this._sendEmail = ::this._sendEmail
-    this._set = ::xo.defineProperty
+  constructor ({ xo }) {
+    this._sendEmail = bind(this._sendEmail, this)
+    this._set = bind(xo.defineProperty, xo)
     this._unset = null
 
     // Defined in configure().
@@ -130,7 +147,7 @@ class TransportEmailPlugin {
     transport.use('compile', markdownCompiler)
 
     this._conf = conf
-    this._send = transport.sendMail::promisify(transport)
+    this._send = promisify(transport.sendMail, transport)
   }
 
   load () {
@@ -141,22 +158,36 @@ class TransportEmailPlugin {
     this._unset()
   }
 
+  test ({to}) {
+    return this._sendEmail({
+      to,
+      subject: '[Xen Orchestra] Test of transport-email plugin',
+      markdown: `Hi there,
+
+The transport-email plugin for Xen Orchestra server seems to be working fine, nicely done :)`
+    })
+  }
+
   _sendEmail ({
     from = this._conf.from,
     to, cc, bcc,
     subject,
-    markdown
+    markdown,
+    attachments
   }) {
     // TODO: handle errors
     return this._send({
       from,
-      to, cc, bcc,
+      to,
+      cc,
+      bcc,
       subject,
-      markdown
+      markdown,
+      attachments
     }).catch(logAndRethrow)
   }
 }
 
 // ===================================================================
 
-export default ({ xo }) => new TransportEmailPlugin(xo)
+export default opts => new TransportEmailPlugin(opts)