OilfieldToolsNet/ResInsight
4
0
Fork 0
mirror of https://github.com/OPM/ResInsight.git synced 2025-01-26 16:26:48 -06:00
Code Issues Packages Projects Releases Wiki Activity

Use const reference and use empty()

Browse Source
This commit is contained in:
Magne Sjaastad 2018-05-11 19:49:47 +02:00
parent 4bd7b1eeb6
commit 2cb123474b
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ApplicationCode/ProjectDataModel/Summary/RimEnsembleCurveSet.cpp
View File

@ -276,7 +276,7 @@ std::vector<RimSummaryCurve*> RimEnsembleCurveSet::visibleCurves() const
{
std::vector<RimSummaryCurve*> visible;
for (auto c : m_curves)
for (const auto& c : m_curves)
{
if (c->isCurveVisible())
{
@ -447,7 +447,7 @@ void RimEnsembleCurveSet::fieldChangedByUi(const caf::PdmFieldHandle* changedFie
if (dlg.exec() == QDialog::Accepted)
{
auto curveSelection = dlg.curveSelection();
if (curveSelection.size() > 0)
if (!curveSelection.empty())
{
m_yValuesSummaryGroup = curveSelection[0].ensemble();
m_yValuesCurveVariable->setAddress(curveSelection[0].summaryAddress());
@ -603,7 +603,7 @@ QList<caf::PdmOptionItemInfo> RimEnsembleCurveSet::calculateValueOptions(const c
}
else if (fieldNeedingOptions == &m_ensembleParameter)
{
for (auto param : ensembleParameters())
for (const auto& param : ensembleParameters())
{
options.push_back(caf::PdmOptionItemInfo(param, param));
}
@ -628,9 +628,7 @@ void RimEnsembleCurveSet::getOptionsForSummaryAddresses(std::map<QString, RifEcl
RifSummaryReaderInterface* reader = summaryCase->summaryReader();
if (reader)
{
const std::vector<RifEclipseSummaryAddress> allAddresses = reader->allResultAddresses();
for (auto& address : allAddresses)
for (const auto& address : reader->allResultAddresses())
{
if (summaryFilter && !summaryFilter->isIncludedByFilter(address)) continue;