Refactor: forward-declare element type in collection headers

Move the element-type include from each migrated collection header into
its .cpp, leaving only a forward declaration in the header. Follows the
pattern from 9e4d79159 for RimJobCollection, made possible by the
constructor-time PdmObject base check.

ApplicationLibCode/ProjectDataModel/AnalysisPlots/RimPlotDataFilterCollection.cpp

@@ -18,6 +18,8 @@
 
 #include "RimPlotDataFilterCollection.h"
 
+#include "RimPlotDataFilterItem.h"
+
 CAF_PDM_SOURCE_INIT( RimPlotDataFilterCollection, "PlotDataFilterCollection" );
 
 //--------------------------------------------------------------------------------------------------

ApplicationLibCode/ProjectDataModel/AnalysisPlots/RimPlotDataFilterCollection.h

@@ -17,12 +17,12 @@
 /////////////////////////////////////////////////////////////////////////////////
 #pragma once
 
-#include "RimPlotDataFilterItem.h"
-
 #include "cafPdmField.h"
 #include "cafPdmObjectCollection.h"
 #include "cafSignal.h"
 
+class RimPlotDataFilterItem;
+
 //==================================================================================================
 ///
 //==================================================================================================

ApplicationLibCode/ProjectDataModel/Completions/RimEnsembleFractureStatisticsCollection.cpp

@@ -18,6 +18,8 @@
 
 #include "RimEnsembleFractureStatisticsCollection.h"
 
+#include "RimEnsembleFractureStatistics.h"
+
 CAF_PDM_SOURCE_INIT( RimEnsembleFractureStatisticsCollection, "FractureGroupStatisticsCollection" );
 
 //--------------------------------------------------------------------------------------------------

ApplicationLibCode/ProjectDataModel/Completions/RimEnsembleFractureStatisticsCollection.h

@@ -18,10 +18,10 @@
 
 #pragma once
 
-#include "RimEnsembleFractureStatistics.h"
-
 #include "cafPdmObjectCollection.h"
 
+class RimEnsembleFractureStatistics;
+
 //==================================================================================================
 ///
 ///

ApplicationLibCode/ProjectDataModel/Completions/RimFractureTemplateCollection.h

@@ -20,12 +20,11 @@
 
 #include "RiaDefines.h"
 
-#include "RimFractureTemplate.h"
-
 #include "cafPdmField.h"
 #include "cafPdmObjectCollection.h"
 
 class RimEllipseFractureTemplate;
+class RimFractureTemplate;
 
 //==================================================================================================
 ///

ApplicationLibCode/ProjectDataModel/ContourMap/RimEclipseContourMapViewCollection.h

@@ -18,10 +18,10 @@
 
 #pragma once
 
-#include "RimEclipseContourMapView.h"
-
 #include "cafPdmObjectCollection.h"
 
+class RimEclipseContourMapView;
+
 class RimEclipseContourMapViewCollection : public caf::PdmObjectCollection<RimEclipseContourMapView>
 {
     CAF_PDM_HEADER_INIT;

ApplicationLibCode/ProjectDataModel/EnsembleFileSet/RimEnsembleFileSetCollection.cpp

@@ -18,6 +18,7 @@
 
 #include "RimEnsembleFileSetCollection.h"
 
+#include "RimEnsembleFileSet.h"
 #include "RimTools.h"
 
 #include "cafCmdFeatureMenuBuilder.h"

ApplicationLibCode/ProjectDataModel/EnsembleFileSet/RimEnsembleFileSetCollection.h

@@ -18,10 +18,10 @@
 
 #pragma once
 
-#include "RimEnsembleFileSet.h"
-
 #include "cafPdmObjectCollection.h"
 
+class RimEnsembleFileSet;
+
 //==================================================================================================
 ///
 /// Class to manage a collection of ensemble filesets

ApplicationLibCode/ProjectDataModel/GeoMech/RimGeoMechContourMapViewCollection.cpp

@@ -1,6 +1,7 @@
 #include "RimGeoMechContourMapViewCollection.h"
 
 #include "RimCase.h"
+#include "RimGeoMechContourMapView.h"
 
 CAF_PDM_SOURCE_INIT( RimGeoMechContourMapViewCollection, "GeoMech2dViewCollection" );
 

ApplicationLibCode/ProjectDataModel/GeoMech/RimGeoMechContourMapViewCollection.h

@@ -18,10 +18,10 @@
 
 #pragma once
 
-#include "RimGeoMechContourMapView.h"
-
 #include "cafPdmObjectCollection.h"
 
+class RimGeoMechContourMapView;
+
 class RimGeoMechContourMapViewCollection : public caf::PdmObjectCollection<RimGeoMechContourMapView>
 {
     CAF_PDM_HEADER_INIT;

ApplicationLibCode/ProjectDataModel/Intersections/RimIntersectionResultsDefinitionCollection.h

@@ -17,11 +17,11 @@
 /////////////////////////////////////////////////////////////////////////////////
 #pragma once
 
-#include "RimIntersectionResultDefinition.h"
-
 #include "cafPdmField.h"
 #include "cafPdmObjectCollection.h"
 
+class RimIntersectionResultDefinition;
+
 class RimIntersectionResultsDefinitionCollection : public caf::PdmObjectCollection<RimIntersectionResultDefinition>
 {
     CAF_PDM_HEADER_INIT;

ApplicationLibCode/ProjectDataModel/QuickAccess/RimQuickAccessCollection.h

@@ -18,11 +18,10 @@
 
 #pragma once
 
-#include "RimFieldQuickAccessGroup.h"
-
 #include "cafPdmObjectCollection.h"
 
 class RimFieldQuickAccess;
+class RimFieldQuickAccessGroup;
 class RimFieldReference;
 
 //==================================================================================================

ApplicationLibCode/ProjectDataModel/RimCustomObjectiveFunctionCollection.h

@@ -18,13 +18,13 @@
 
 #pragma once
 
-#include "RimCustomObjectiveFunction.h"
-
 #include "cafPdmObjectCollection.h"
 #include "cafSignal.h"
 
 #include <QString>
 
+class RimCustomObjectiveFunction;
+
 //==================================================================================================
 ///
 //==================================================================================================

ApplicationLibCode/ProjectDataModel/RimEclipseInputPropertyCollection.cpp

@@ -20,6 +20,8 @@
 
 #include "RimEclipseInputPropertyCollection.h"
 
+#include "RimEclipseInputProperty.h"
+
 #include <QFileInfo>
 
 CAF_PDM_SOURCE_INIT( RimEclipseInputPropertyCollection, "RimInputPropertyCollection" );

ApplicationLibCode/ProjectDataModel/RimEclipseInputPropertyCollection.h

@@ -20,10 +20,10 @@
 
 #pragma once
 
-#include "RimEclipseInputProperty.h"
-
 #include "cafPdmObjectCollection.h"
 
+class RimEclipseInputProperty;
+
 //==================================================================================================
 //
 //

ApplicationLibCode/ProjectDataModel/RimEclipseStatisticsCaseCollection.cpp

@@ -20,6 +20,7 @@
 
 #include "RimEclipseStatisticsCaseCollection.h"
 
+#include "RimEclipseStatisticsCase.h"
 #include "RimIdenticalGridCaseGroup.h"
 
 CAF_PDM_SOURCE_INIT( RimEclipseStatisticsCaseCollection, "RimStatisticalCollection" );

ApplicationLibCode/ProjectDataModel/RimEclipseStatisticsCaseCollection.h

@@ -20,10 +20,9 @@
 
 #pragma once
 
-#include "RimEclipseStatisticsCase.h"
-
 #include "cafPdmObjectCollection.h"
 
+class RimEclipseStatisticsCase;
 class RimIdenticalGridCaseGroup;
 
 //==================================================================================================

ApplicationLibCode/ProjectDataModel/RimRefinementRegionCollection.h

@@ -18,8 +18,6 @@
 
 #pragma once
 
-#include "RimRefinementRegion.h"
-
 #include "cafPdmField.h"
 #include "cafPdmObjectCollection.h"
 #include "cafVecIjk.h"
@@ -33,6 +31,7 @@
 
 class RigRefinement;
 class RimEclipseCase;
+class RimRefinementRegion;
 
 //==================================================================================================
 ///

ApplicationLibCode/ProjectDataModel/Seismic/RimSeismicViewCollection.cpp

@@ -23,6 +23,7 @@
 #include "Rim3dView.h"
 #include "RimGridView.h"
 #include "RimProject.h"
+#include "RimSeismicView.h"
 
 CAF_PDM_SOURCE_INIT( RimSeismicViewCollection, "SeismicViewCollection", "SeismicViewCollection" );
 

ApplicationLibCode/ProjectDataModel/Seismic/RimSeismicViewCollection.h

@@ -19,13 +19,12 @@
 
 #include "RiaSeismicDefines.h"
 
-#include "RimSeismicView.h"
-
 #include "cafPdmObjectCollection.h"
 
 #include <QString>
 
 class RimSeismicDataInterface;
+class RimSeismicView;
 
 class RimSeismicViewCollection : public caf::PdmObjectCollection<RimSeismicView>
 {

ApplicationLibCode/ProjectDataModel/StimPlanModel/RimStimPlanModelTemplateCollection.h

@@ -18,11 +18,11 @@
 
 #pragma once
 
-#include "RimStimPlanModelTemplate.h"
-
 #include "cafPdmField.h"
 #include "cafPdmObjectCollection.h"
 
+class RimStimPlanModelTemplate;
+
 //==================================================================================================
 ///
 ///

ApplicationLibCode/ProjectDataModel/VerticalFlowPerformance/RimVfpDataCollection.h

@@ -17,11 +17,10 @@
 /////////////////////////////////////////////////////////////////////////////////
 #pragma once
 
-#include "RimVfpTableData.h"
-
 #include "cafPdmObjectCollection.h"
 
 class RimVfpTable;
+class RimVfpTableData;
 
 //==================================================================================================
 ///

ApplicationLibCode/ProjectDataModel/WellLog/RimEnsembleWellLogsCollection.cpp

@@ -18,6 +18,8 @@
 
 #include "RimEnsembleWellLogsCollection.h"
 
+#include "RimEnsembleWellLogs.h"
+
 #include "cafProgressInfo.h"
 
 CAF_PDM_SOURCE_INIT( RimEnsembleWellLogsCollection, "EnsembleWellLogsCollection" );

ApplicationLibCode/ProjectDataModel/WellLog/RimEnsembleWellLogsCollection.h

@@ -17,10 +17,10 @@
 /////////////////////////////////////////////////////////////////////////////////
 #pragma once
 
-#include "RimEnsembleWellLogs.h"
-
 #include "cafPdmObjectCollection.h"
 
+class RimEnsembleWellLogs;
+
 //==================================================================================================
 ///
 //==================================================================================================

ApplicationLibCode/ProjectDataModel/WellPath/RimWellIASettingsCollection.h

@@ -17,14 +17,13 @@
 /////////////////////////////////////////////////////////////////////////////////
 #pragma once
 
-#include "RimWellIASettings.h"
-
 #include "cafPdmObjectCollection.h"
 
 #include <QString>
 
-class RimWellPath;
 class RimGeoMechCase;
+class RimWellIASettings;
+class RimWellPath;
 
 class RimWellIASettingsCollection : public caf::PdmObjectCollection<RimWellIASettings>
 {