#4348 System , cppcheck : Remove unused functions

ApplicationCode/Adm/sourceCodeMaintenance/2019-04-21-delete-unused_functions.txt

@@ -16,47 +16,6 @@ WIP
 unchanged	ApplicationCode\UserInterface\RiuGridCrossQwtPlot.cpp	359	style	unusedFunction	false	The function 'contextMenuEvent' is never used.
 unchanged	ApplicationCode\Commands\HoloLensCommands\VdeCachingHashedIdFactory.cpp	233	style	unusedFunction	false	The function 'crc' is never used.
 unchanged	ApplicationCode\Application\Tools\RiaColorTables.cpp	580	style	unusedFunction	false	The function 'createBrightnessBasedColorTable' is never used.
-
-
-Candidate for later use
------------------------
-
-Issue on GitHub
-----
-
-Must be changed
-----------------
-
-Deleted
--------
-unchanged	ApplicationCode\FileInterface\RifEclipseDataTableFormatter.cpp	278	style	unusedFunction	false	The function 'addValueTable' is never used.
-unchanged	ApplicationCode\ReservoirDataModel\Completions\RigEclipseToStimPlanCellTransmissibilityCalculator.cpp	109	style	unusedFunction	false	The function 'aggregatedMatrixTransmissibility' is never used.
-unchanged	ApplicationCode\ProjectDataModel\Annotations\RimAnnotationInViewCollection.cpp	231	style	unusedFunction	false	The function 'annotationsCount' is never used.
-unchanged	ApplicationCode\Commands\ExportCommands\RicExportLgrFeature.cpp	848	style	unusedFunction	false	The function 'appendIntersectedCells' is never used.
-unchanged	ApplicationCode\Application\Tools\RiaQIconTools.cpp	26	style	unusedFunction	false	The function 'appendPixmapUpperLeft' is never used.
-unchanged	ApplicationCode\ReservoirDataModel\RigEclipseResultBinSorter.cpp	48	style	unusedFunction	false	The function 'binRange' is never used.
-unchanged	ApplicationCode\Commands\ExportCommands\RicExportLgrFeature.cpp	684	style	unusedFunction	false	The function 'cellsIntersectingCompletion' is never used.
-unchanged	ApplicationCode\Commands\ExportCommands\RicExportLgrFeature.cpp	702	style	unusedFunction	false	The function 'createOrderedIntersectionList' is never used.
-unchanged	ApplicationCode\Commands\ExportCommands\RicExportLgrFeature.cpp	1129	style	unusedFunction	false	The function 'resetNumbering' is never used.
-unchanged	ApplicationCode\Commands\RicCreateTemporaryLgrFeature.cpp	350	style	unusedFunction	false	The function 'containsAnyNonMainGridCells' is never used.
-unchanged	ApplicationCode\Application\Tools\RiaColorTools.cpp	147	style	unusedFunction	false	The function 'contrastRatio' is never used.
-unchanged	ApplicationCode\ProjectDataModel\Completions\RimPerforationInterval.cpp	105	style	unusedFunction	false	The function 'enableCustomEndDate' is never used.
-unchanged	ApplicationCode\ProjectDataModel\Rim3dView.cpp	1099	style	unusedFunction	false	The function 'enablePerspectiveProjectionField' is never used.
-unchanged	ApplicationCode\ReservoirDataModel\RigMainGrid.cpp	166	style	unusedFunction	false	The function 'findAllReservoirCellIndicesMatching2dPoint' is never used.
-unchanged	ApplicationCode\ProjectDataModel\GridCrossPlots\RimGridCrossPlotDataSet.cpp	400	style	unusedFunction	false	The function 'groupStrings' is never used.
-unchanged	ApplicationCode\ProjectDataModel\RimContourMapProjection.cpp	354	style	unusedFunction	false	The function 'hasResultAtVertex' is never used.
-unchanged	ApplicationCode\ProjectDataModel\RimContourMapProjection.cpp	1417	style	unusedFunction	false	The function 'isSummationResult' is never used.
-unchanged	ApplicationCode\ProjectDataModel\RimContourMapProjection.cpp	223	style	unusedFunction	false	The function 'resultAggregation' is never used.
-unchanged	ApplicationCode\ProjectDataModel\RimContourMapProjection.cpp	255	style	unusedFunction	false	The function 'showContourLabels' is never used.
-unchanged	ApplicationCode\ProjectDataModel\Annotations\RimUserDefinedPolylinesAnnotation.cpp	42	style	unusedFunction	false	The function 'xydToXyzVector' is never used.
-unchanged	ApplicationCode\ProjectDataModel\Completions\RimSimWellFracture.cpp	117	style	unusedFunction	false	The function 'wellDipAtFracturePosition' is never used.
-unchanged	ApplicationCode\ReservoirDataModel\RigLocalGrid.cpp	65	style	unusedFunction	false	The function 'setPositionInParentGrid' is never used.
-unchanged	ApplicationCode\ProjectDataModel\Annotations\RimPolylinesAnnotationInView.cpp	66	style	unusedFunction	false	The function 'setSourceAnnotation' is never used.
-unchanged	ApplicationCode\ProjectDataModel\Annotations\RimAnnotationTextAppearance.cpp	75	style	unusedFunction	false	The function 'setAnchorLineColor' is never used.
-unchanged	ApplicationCode\ProjectDataModel\Annotations\RimAnnotationTextAppearance.cpp	59	style	unusedFunction	false	The function 'setFontColor' is never used.
-
-Backlog
--------
 unchanged	ApplicationCode\GeoMech\GeoMechVisualization\RivFemPartGeometryGenerator.cpp	106	style	unusedFunction	false	The function 'createOutlineMeshDrawable' is never used.
 unchanged	ApplicationCode\ModelVisualization\RivWellConnectionFactorGeometryGenerator.cpp	202	style	unusedFunction	false	The function 'createStarGeometry' is never used.
 unchanged	ApplicationCode\Commands\SummaryPlotCommands\RicSummaryCurveCalculatorEditor.cpp	119	style	unusedFunction	false	The function 'createWidget' is never used.
@@ -100,12 +59,7 @@ unchanged	ApplicationCode\UserInterface\RiuViewer.cpp	345	style	unusedFunction	f
 unchanged	ApplicationCode\ProjectDataModel\RimProject.cpp	1066	style	unusedFunction	false	The function 'polylineAnnotations' is never used.
 unchanged	ApplicationCode\Application\RiaApplication.cpp	326	style	unusedFunction	false	The function 'processNonGuiEvents' is never used.
 unchanged	ApplicationCode\Commands\SummaryPlotCommands\RicSummaryCurveCalculatorEditor.cpp	65	style	unusedFunction	false	The function 'recursivelyConfigureAndUpdateTopLevelUiOrdering' is never used.
-
-unchanged	ApplicationCode\ProjectDataModel\RimScaleLegendConfig.cpp	447	style	unusedFunction	false	The function 'setCurrentScale' is never used.
 unchanged	ApplicationCode\ProjectDataModel\RimEclipseResultDefinition.cpp	755	style	unusedFunction	false	The function 'setFromEclipseResultAddress' is never used.
-unchanged	ApplicationCode\ProjectDataModel\Rim3dOverlayInfoConfig.cpp	278	style	unusedFunction	false	The function 'setIsActive' is never used.
-unchanged	ApplicationCode\FileInterface\RifEclipseDataTableFormatter.cpp	137	style	unusedFunction	false	The function 'setMaxDataRowWidth' is never used.
-unchanged	ApplicationCode\ProjectDataModel\RimRegularLegendConfig.cpp	737	style	unusedFunction	false	The function 'setShowLegend' is never used.
 unchanged	ApplicationCode\ProjectDataModel\Completions\RimWellPathAicdParameters.cpp	189	style	unusedFunction	false	The function 'setUnitLabels' is never used.
 unchanged	ApplicationCode\ProjectDataModel\Flow\RimWellPltPlot.cpp	1067	style	unusedFunction	false	The function 'setupBeforeSave' is never used.
 unchanged	ApplicationCode\UserInterface\RiuWellLogPlot.cpp	519	style	unusedFunction	false	The function 'showEvent' is never used.
@@ -120,3 +74,48 @@ unchanged	ApplicationCode\Commands\HoloLensCommands\RicHoloLensSessionManager.h
 unchanged	ApplicationCode\Commands\HoloLensCommands\VdeVizDataExtractor.h	106	style	unusedPrivateFunction	false	Unused private function: 'VdeVizDataExtractor::debugComparePackets'
 unchanged	ApplicationCode\FileInterface\RifCaseRealizationParametersReader.h	101	style	unusedPrivateFunction	false	Unused private function: 'RifCaseRealizationRunspecificationReader::closeDataStream'
 unchanged	ApplicationCode\ReservoirDataModel\RigSimulationWellCenterLineCalculator.h	52	style	unusedPrivateFunction	false	Unused private function: 'RigSimulationWellCenterLineCalculator::splitIntoBranches'
+
+
+Candidate for later use
+-----------------------
+
+Issue on GitHub
+----
+
+Must be changed
+----------------
+
+Deleted
+-------
+unchanged	ApplicationCode\FileInterface\RifEclipseDataTableFormatter.cpp	278	style	unusedFunction	false	The function 'addValueTable' is never used.
+unchanged	ApplicationCode\ReservoirDataModel\Completions\RigEclipseToStimPlanCellTransmissibilityCalculator.cpp	109	style	unusedFunction	false	The function 'aggregatedMatrixTransmissibility' is never used.
+unchanged	ApplicationCode\ProjectDataModel\Annotations\RimAnnotationInViewCollection.cpp	231	style	unusedFunction	false	The function 'annotationsCount' is never used.
+unchanged	ApplicationCode\Commands\ExportCommands\RicExportLgrFeature.cpp	848	style	unusedFunction	false	The function 'appendIntersectedCells' is never used.
+unchanged	ApplicationCode\Application\Tools\RiaQIconTools.cpp	26	style	unusedFunction	false	The function 'appendPixmapUpperLeft' is never used.
+unchanged	ApplicationCode\ReservoirDataModel\RigEclipseResultBinSorter.cpp	48	style	unusedFunction	false	The function 'binRange' is never used.
+unchanged	ApplicationCode\Commands\ExportCommands\RicExportLgrFeature.cpp	684	style	unusedFunction	false	The function 'cellsIntersectingCompletion' is never used.
+unchanged	ApplicationCode\Commands\ExportCommands\RicExportLgrFeature.cpp	702	style	unusedFunction	false	The function 'createOrderedIntersectionList' is never used.
+unchanged	ApplicationCode\Commands\ExportCommands\RicExportLgrFeature.cpp	1129	style	unusedFunction	false	The function 'resetNumbering' is never used.
+unchanged	ApplicationCode\Commands\RicCreateTemporaryLgrFeature.cpp	350	style	unusedFunction	false	The function 'containsAnyNonMainGridCells' is never used.
+unchanged	ApplicationCode\Application\Tools\RiaColorTools.cpp	147	style	unusedFunction	false	The function 'contrastRatio' is never used.
+unchanged	ApplicationCode\ProjectDataModel\Completions\RimPerforationInterval.cpp	105	style	unusedFunction	false	The function 'enableCustomEndDate' is never used.
+unchanged	ApplicationCode\ProjectDataModel\Rim3dView.cpp	1099	style	unusedFunction	false	The function 'enablePerspectiveProjectionField' is never used.
+unchanged	ApplicationCode\ReservoirDataModel\RigMainGrid.cpp	166	style	unusedFunction	false	The function 'findAllReservoirCellIndicesMatching2dPoint' is never used.
+unchanged	ApplicationCode\ProjectDataModel\GridCrossPlots\RimGridCrossPlotDataSet.cpp	400	style	unusedFunction	false	The function 'groupStrings' is never used.
+unchanged	ApplicationCode\ProjectDataModel\RimContourMapProjection.cpp	354	style	unusedFunction	false	The function 'hasResultAtVertex' is never used.
+unchanged	ApplicationCode\ProjectDataModel\RimContourMapProjection.cpp	1417	style	unusedFunction	false	The function 'isSummationResult' is never used.
+unchanged	ApplicationCode\ProjectDataModel\RimContourMapProjection.cpp	223	style	unusedFunction	false	The function 'resultAggregation' is never used.
+unchanged	ApplicationCode\ProjectDataModel\RimContourMapProjection.cpp	255	style	unusedFunction	false	The function 'showContourLabels' is never used.
+unchanged	ApplicationCode\ProjectDataModel\Annotations\RimUserDefinedPolylinesAnnotation.cpp	42	style	unusedFunction	false	The function 'xydToXyzVector' is never used.
+unchanged	ApplicationCode\ProjectDataModel\Completions\RimSimWellFracture.cpp	117	style	unusedFunction	false	The function 'wellDipAtFracturePosition' is never used.
+unchanged	ApplicationCode\ReservoirDataModel\RigLocalGrid.cpp	65	style	unusedFunction	false	The function 'setPositionInParentGrid' is never used.
+unchanged	ApplicationCode\ProjectDataModel\Annotations\RimPolylinesAnnotationInView.cpp	66	style	unusedFunction	false	The function 'setSourceAnnotation' is never used.
+unchanged	ApplicationCode\ProjectDataModel\Annotations\RimAnnotationTextAppearance.cpp	75	style	unusedFunction	false	The function 'setAnchorLineColor' is never used.
+unchanged	ApplicationCode\ProjectDataModel\Annotations\RimAnnotationTextAppearance.cpp	59	style	unusedFunction	false	The function 'setFontColor' is never used.
+unchanged	ApplicationCode\ProjectDataModel\RimScaleLegendConfig.cpp	447	style	unusedFunction	false	The function 'setCurrentScale' is never used.
+unchanged	ApplicationCode\ProjectDataModel\Rim3dOverlayInfoConfig.cpp	278	style	unusedFunction	false	The function 'setIsActive' is never used.
+unchanged	ApplicationCode\FileInterface\RifEclipseDataTableFormatter.cpp	137	style	unusedFunction	false	The function 'setMaxDataRowWidth' is never used.
+unchanged	ApplicationCode\ProjectDataModel\RimRegularLegendConfig.cpp	737	style	unusedFunction	false	The function 'setShowLegend' is never used.
+
+Backlog
+-------

ApplicationCode/FileInterface/RifEclipseDataTableFormatter.cpp

@@ -131,14 +131,6 @@ void RifEclipseDataTableFormatter::setUnlimitedDataRowWidth()
     m_maxDataRowWidth = std::numeric_limits<int>::max();
 }
 
-//--------------------------------------------------------------------------------------------------
-///
-//--------------------------------------------------------------------------------------------------
-void RifEclipseDataTableFormatter::setMaxDataRowWidth(int maxWidth)
-{
-    m_maxDataRowWidth = maxWidth;
-}
-
 //--------------------------------------------------------------------------------------------------
 ///
 //--------------------------------------------------------------------------------------------------

ApplicationCode/FileInterface/RifEclipseDataTableFormatter.h

@@ -120,7 +120,6 @@ public:
     QString commentPrefix() const;
     void setCommentPrefix(const QString& commentPrefix);
     void setUnlimitedDataRowWidth();
-    void setMaxDataRowWidth(int maxWidth);
     int  maxDataRowWidth() const;
 
     RifEclipseDataTableFormatter& keyword(const QString& keyword);

ApplicationCode/ProjectDataModel/Rim3dOverlayInfoConfig.cpp

@@ -272,14 +272,6 @@ bool Rim3dOverlayInfoConfig::isActive() const
     return m_active;
 }
 
-//--------------------------------------------------------------------------------------------------
-///
-//--------------------------------------------------------------------------------------------------
-void Rim3dOverlayInfoConfig::setIsActive(bool active)
-{
-    m_active = active;
-}
-
 //--------------------------------------------------------------------------------------------------
 ///
 //--------------------------------------------------------------------------------------------------

ApplicationCode/ProjectDataModel/Rim3dOverlayInfoConfig.h

@@ -87,7 +87,6 @@ public:
     bool          showCaseInfo() const;
     bool          showResultInfo() const;
     bool          isActive() const;
-    void          setIsActive(bool active);
 
     bool          showVersionInfo() const;
 

ApplicationCode/ProjectDataModel/RimRegularLegendConfig.cpp

@@ -731,14 +731,6 @@ bool RimRegularLegendConfig::showLegend() const
     return m_showLegend;
 }
 
-//--------------------------------------------------------------------------------------------------
-///
-//--------------------------------------------------------------------------------------------------
-void RimRegularLegendConfig::setShowLegend(bool show)
-{
-    m_showLegend = show;
-}
-
 //--------------------------------------------------------------------------------------------------
 /// 
 //--------------------------------------------------------------------------------------------------

ApplicationCode/ProjectDataModel/RimRegularLegendConfig.h

@@ -123,7 +123,6 @@ public:
 
     cvf::ScalarMapper*                          scalarMapper() { return m_currentScalarMapper.p(); }
     bool                                        showLegend() const;
-    void                                        setShowLegend(bool show);
 
     const caf::TitledOverlayFrame*              titledOverlayFrame() const override;
     caf::TitledOverlayFrame*                    titledOverlayFrame() override;

ApplicationCode/ProjectDataModel/RimScaleLegendConfig.cpp

@@ -441,17 +441,6 @@ RimLegendConfig::RangeModeType RimScaleLegendConfig::rangeMode() const
     return m_rangeMode();
 }
 
-//--------------------------------------------------------------------------------------------------
-///
-//--------------------------------------------------------------------------------------------------
-void RimScaleLegendConfig::setCurrentScale(double scale)
-{
-    m_currentScale = scale;
-
-    // Update legend
-    updateLegend();
-}
-
 //--------------------------------------------------------------------------------------------------
 /// 
 //--------------------------------------------------------------------------------------------------

ApplicationCode/ProjectDataModel/RimScaleLegendConfig.h

@@ -109,8 +109,6 @@ public:
 
     RangeModeType                               rangeMode() const;
 
-    void                                        setCurrentScale(double scale);
-
 private:
     void                                        fieldChangedByUi(const caf::PdmFieldHandle* changedField, const QVariant& oldValue, const QVariant& newValue) override;
     void                                        initAfterRead() override;
@@ -145,6 +143,4 @@ private:
     caf::PdmField<double>                       m_userDefinedMaxValue;
     caf::PdmField<double>                       m_userDefinedMinValue;
     caf::PdmField<caf::AppEnum<ColorRangesType> > m_colorRangeMode;
-
-    double                                      m_currentScale; // [meters/pixel]
 };