#12953 Always check date of all realizations

The date stamp of UNSMRY is compared to date stamp of ESMRY. This takes some time, and a performance improvement was seen when this operation was done only on a single representative realization of an ensemble. This is not stable, as a single realization might crash or have no new data compared to other realizations.

This feature is removed.

ApplicationLibCode/FileInterface/RifEnsembleImportConfig.cpp

@@ -27,14 +27,6 @@
 
 #include <QStringList>
 
-//--------------------------------------------------------------------------------------------------
-///
-//--------------------------------------------------------------------------------------------------
-bool RifEnsembleImportConfig::shouldCreateEsmryFile() const
-{
-    return m_shouldCreateEsmryFile;
-}
-
 //--------------------------------------------------------------------------------------------------
 ///
 //--------------------------------------------------------------------------------------------------
@@ -75,8 +67,6 @@ void RifEnsembleImportConfig::computePatternsFromSummaryFilePaths( const QString
     computeRestartPatternsFromTwoRealizations( restartFileNames1, restartFileNames2 );
     computeParameterFilePathPattern( { paramFilePath1, paramFilePath2 } );
 
-    m_shouldCreateEsmryFile = RifOpmSummaryTools::isEsmryConversionRequired( filePath1 );
-
     m_useConfigValues = true;
 }
 

ApplicationLibCode/FileInterface/RifEnsembleImportConfig.h

@@ -29,7 +29,6 @@ public:
 
     std::vector<QString> restartFilesForRealization( int realizationNumber ) const;
     QString              pathToParameterFile( int realizationNumber ) const;
-    bool                 shouldCreateEsmryFile() const;
     bool                 useConfigValues() const;
 
 private:
@@ -41,8 +40,7 @@ private:
     static QString placeholderText();
 
 private:
-    bool                 m_useConfigValues       = false;
-    bool                 m_shouldCreateEsmryFile = false;
+    bool                 m_useConfigValues = false;
     std::vector<QString> m_restartFileNamePatterns;
     QString              m_parameterFilePathPattern;
 };

ApplicationLibCode/FileInterface/RifOpmCommonSummary.cpp

@@ -132,8 +132,7 @@ bool RifOpmCommonEclipseSummary::open( const QString& fileName, bool includeRest
 
     auto startTime = RiaLogging::currentTime();
 
-    bool isEsmryConversionRequired = m_ensembleImportState.useConfigValues() ? m_ensembleImportState.shouldCreateEsmryFile()
-                                                                             : RifOpmSummaryTools::isEsmryConversionRequired( fileName );
+    bool isEsmryConversionRequired = RifOpmSummaryTools::isEsmryConversionRequired( fileName );
 
     bool isLoggingEnabled = RiaPreferencesSystem::current()->isLoggingActivatedForKeyword( "OpmSummaryImport" );
     if ( isLoggingEnabled ) RiaLogging::logElapsedTime( "Check if conversion from SMSPEC to ESMRY is required", startTime );