OilfieldToolsNet/ResInsight
4
0 Fork 0
mirror of https://github.com/OPM/ResInsight.git synced 2026-10-13 00:42:12 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix hang when editing regression curve degree

Browse Source 
Disable editingFinsished() signal when read-only. Using tab after change of Degree in a regression curve object causes the application to hang.
This commit is contained in:
Magne Sjaastad committed 2023-10-30 11:20:21 +01:00
1 parent b5b9ac00fe
commit 718d40de56
1 file changed
+14 -3
Download Patch File Download Diff File Expand all files Collapse all files
Fwk/AppFwk/cafUserInterface/cafPdmUiTextEditor.cpp
+14 -3
View File
@@ -104,8 +104,8 @@ void PdmUiTextEditor::configureAndUpdateUi( const QString& uiConfigName )
PdmUiFieldEditorHandle::updateLabelFromField( m_label, uiConfigName );
m_textEdit->setReadOnly( uiField()->isUiReadOnly( uiConfigName ) );
// m_textEdit->setEnabled(!field()->isUiReadOnly(uiConfigName)); // Neccesary ?
bool isReadOnly = uiField()->isUiReadOnly( uiConfigName );
m_textEdit->setReadOnly( isReadOnly );
m_textEdit->setToolTip( uiField()->uiToolTip( uiConfigName ) );
PdmUiTextEditorAttribute leab;
@@ -125,7 +125,18 @@ void PdmUiTextEditor::configureAndUpdateUi( const QString& uiConfigName )
}
else
{
connect( m_textEdit, SIGNAL( editingFinished() ), this, SLOT( slotSetValueToField() ) );
if ( isReadOnly )
{
// Disable editingFinished signal when read only
// This can cause recursive update issues in some cases
// https://github.com/OPM/ResInsight/issues/10758
disconnect( m_textEdit, SIGNAL( editingFinished() ), this, SLOT( slotSetValueToField() ) );
}
else
{
connect( m_textEdit, SIGNAL( editingFinished() ), this, SLOT( slotSetValueToField() ) );
}
m_saveButton->hide();
}