OilfieldToolsNet/ResInsight
4
0
Fork 0
mirror of https://github.com/OPM/ResInsight.git synced 2026-08-27 05:37:21 -05:00
Code Issues Packages Projects Releases Wiki Activity

#14274 Fix invalid index range in dataChanged() from table row editor

Browse Source 
Valid Qt column indices are 0..columnCount()-1, but the bottom-right
model index was constructed with column columnCount(). Since
QAbstractItemModel::index() validates its arguments, this produced an
invalid QModelIndex(-1,-1) passed to dataChanged(), causing a console
warning on every table row update, e.g. when adding or moving 3D well
path pick targets. Fix the same off-by-one in modelIndexFromPdmObject().

Fixes #14274.
This commit is contained in:
Kristian Bendiksen
2026-07-27 10:10:25 +02:00
committed by Magne Sjaastad
parent cf5a0c5227
commit 79442c0524
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Fwk/AppFwk/cafUserInterface/cafPdmUiTableRowEditor.cpp
+1 -1
View File
@@ -79,7 +79,7 @@ void PdmUiTableRowEditor::configureAndUpdateUi( const QString& uiConfigName )
if ( m_model )
{
QModelIndex miStart = m_model->index( m_row, 0 );
QModelIndex miEnd = m_model->index( m_row, m_model->columnCount() );
QModelIndex miEnd = m_model->index( m_row, m_model->columnCount() - 1 );
m_model->notifyDataChanged( miStart, miEnd );
}
Fwk/AppFwk/cafUserInterface/cafPdmUiTableViewQModel.cpp
+1 -1
View File
@@ -739,7 +739,7 @@ QItemSelection PdmUiTableViewQModel::modelIndexFromPdmObject( PdmObjectHandle* p
if ( obj == pdmObject )
{
// Select whole row
itemSelection.select( this->createIndex( i, 0 ), this->createIndex( i, this->columnCount() ) );
itemSelection.select( this->createIndex( i, 0 ), this->createIndex( i, this->columnCount() - 1 ) );
}
}