OilfieldToolsNet/ResInsight
4
0
Fork 0
mirror of https://github.com/OPM/ResInsight.git synced 2026-08-27 05:37:21 -05:00
Code Issues Packages Projects Releases Wiki Activity

#14460 Keep MSW cell intersections sorted by measured depth

Browse Source 
The gap intersection inserted when the well path leaves the grid was pushed to
the result vector before the cell it follows, leaving the intersections
unsorted. This produced a non-increasing Length column in the exported WELSEGS
table.
This commit is contained in:
Magne Sjaastad
2026-08-05 14:20:55 +02:00
parent 8b07cee36d
commit b3e7a2b8f2
2 changed files with 48 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ApplicationLibCode/ReservoirDataModel/Well/RigWellPathIntersectionTools.cpp
+4 -2
View File
@@ -163,6 +163,8 @@ std::vector<WellPathCellIntersectionInfo>
const WellPathCellIntersectionInfo& current = originalIntersections[i];
const WellPathCellIntersectionInfo& next = originalIntersections[i + 1];
intersectionsNoGap.push_back( current );
double distance = std::fabs( current.endMD - next.startMD );
double gapInGridThreshold = 0.1;
if ( distance > gapInGridThreshold )
@@ -214,10 +216,10 @@ std::vector<WellPathCellIntersectionInfo>
extraIntersection.intersectedCellFaceOut = cvf::StructGridInterface::oppositeFace( next.intersectedCellFaceIn );
extraIntersection.intersectionLengthsInCellCS = cvf::Vec3d::ZERO;
// The gap spans [current.endMD, next.startMD], and must be inserted after current to keep the
// intersections sorted by measured depth.
intersectionsNoGap.push_back( extraIntersection );
}
intersectionsNoGap.push_back( current );
}
if ( !originalIntersections.empty() )
ApplicationLibCode/UnitTests/RigWellPathIntersectionTools-Test.cpp
+44
View File
@@ -18,10 +18,13 @@
#include "gtest/gtest.h"
#include "Well/RigWellLogExtractor.h"
#include "Well/RigWellPath.h"
#include "Well/RigWellPathIntersectionTools.h"
#include "cvfVector3.h"
#include <limits>
#include <vector>
//--------------------------------------------------------------------------------------------------
@@ -85,3 +88,44 @@ TEST( RigWellPathTest, FindWellPathCoordsIncludingIntersectionPoint )
EXPECT_EQ( 5u, wellPathPoints.size() );
}
}
//--------------------------------------------------------------------------------------------------
///
//--------------------------------------------------------------------------------------------------
TEST( RigWellPathIntersectionToolsTest, BuildContinuousIntersectionsIsSortedByMeasuredDepth )
{
auto createIntersection = []( size_t globCellIndex, double startMD, double endMD )
{
WellPathCellIntersectionInfo intersection;
intersection.globCellIndex = globCellIndex;
intersection.startPoint = cvf::Vec3d( 0.0, 0.0, -startMD );
intersection.endPoint = cvf::Vec3d( 0.0, 0.0, -endMD );
intersection.startMD = startMD;
intersection.endMD = endMD;
intersection.intersectionLengthsInCellCS = cvf::Vec3d::ZERO;
intersection.intersectedCellFaceIn = cvf::StructGridInterface::NEG_K;
intersection.intersectedCellFaceOut = cvf::StructGridInterface::POS_K;
return intersection;
};
// Two cells, then a gap where the well path is outside the grid, then a third cell
std::vector<WellPathCellIntersectionInfo> intersections;
intersections.push_back( createIntersection( 0, 100.0, 110.0 ) );
intersections.push_back( createIntersection( 1, 110.0, 120.0 ) );
intersections.push_back( createIntersection( 2, 200.0, 210.0 ) );
auto continuousIntersections = RigWellPathIntersectionTools::buildContinuousIntersections( intersections, nullptr );
ASSERT_EQ( 4u, continuousIntersections.size() );
// The gap intersection is inserted between the second and third cell
EXPECT_EQ( std::numeric_limits<size_t>::max(), continuousIntersections[2].globCellIndex );
EXPECT_DOUBLE_EQ( 120.0, continuousIntersections[2].startMD );
EXPECT_DOUBLE_EQ( 200.0, continuousIntersections[2].endMD );
for ( size_t i = 1; i < continuousIntersections.size(); i++ )
{
EXPECT_GE( continuousIntersections[i].startMD, continuousIntersections[i - 1].startMD );
EXPECT_GE( continuousIntersections[i].endMD, continuousIntersections[i - 1].endMD );
}
}