OilfieldToolsNet/ResInsight
4
0
Fork 0
mirror of https://github.com/OPM/ResInsight.git synced 2026-08-27 05:37:21 -05:00
Code Issues Packages Projects Releases Wiki Activity

#14372 Crash triage doc: identify fragile call patterns and suggest a fix for all locations

Browse Source
This commit is contained in:
Magne Sjaastad
2026-07-28 11:37:12 +02:00
parent 4a06edea28
commit fb96233cf4
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/agents/crash-triage.md
+7
View File
@@ -68,6 +68,13 @@ code style and preferring a guard pattern that already exists in the same file.
A fix is only "verified" when (a) the root cause is sound and the patch provably
prevents the unsafe operation on the reported path, **and** (b) it builds.
If the root cause is a fragile call pattern rather than a one-off mistake, grep
the codebase for other occurrences of the same pattern and list them in the PR
with a suggested fix for all locations (example: the manual
`resolveReferencesRecursively()` + `initAfterReadRecursively()` pair combined
into `initAfterInsert()`, https://github.com/OPM/ResInsight/issues/14372).
Still patch only the crashing site unless told otherwise.
### 4. Build-verify
Build the affected target with CMake (never call ninja directly):