#14722 Remove object from list before deleting it to avoid crash

RicDeleteItemExec::redo() and RicCloseCaseFeature::deleteEclipseCase()
deleted the pdm object before removing it from the owning
PdmChildArrayField. Destroying the object first could corrupt the
field's internal state before the list removal, causing a crash.

Swap the order so the object is removed from the list before it is
deleted.

ApplicationLibCode/Commands/RicCloseCaseFeature.cpp

@@ -182,8 +182,8 @@ void RicCloseCaseFeature::deleteEclipseCase( RimEclipseCase* eclipseCase )
                     for ( size_t i = children.size(); i-- > 0; )
                     {
                         caf::PdmObjectHandle* obj = children[i];
-                        delete obj;
                         caseGroup->statisticsCaseCollection()->reservoirs.erase( i );
+                        delete obj;
                     }
 
                     caseGroup->statisticsCaseCollection()->uiCapability()->updateConnectedEditors();

ApplicationLibCode/Commands/RicDeleteItemExec.cpp

@@ -62,10 +62,10 @@ void RicDeleteItemExec::redo()
             m_commandData.m_deletedObjectAsXml = xmlObj( obj )->writeObjectToXmlString();
         }
 
-        delete obj;
-
         listField->erase( m_commandData.m_indexToObject );
 
+        delete obj;
+
         caf::PdmObjectHandle* parentObj = listField->ownerObject();
         parentObj->uiCapability()->updateConnectedEditors();
         parentObj->onChildDeleted( listField, referringObjects );