OilfieldToolsNet/ResInsight
4
0 Fork 0
mirror of https://github.com/OPM/ResInsight.git synced 2026-11-13 09:37:29 -06:00
Code Issues Packages Projects Releases Wiki Activity
20,294 Commits 75 Branches 87 Tags
61927dc6de53c0fc83a4403a610d80f249e1ef8a
Commit Graph
24 Commits
Author SHA1 Message Date
Magne Sjaastad 064ac45da0 ResInsight: Migrate project data model to attribute map 2026-10-17 13:23:22 +02:00
Magne Sjaastad 6df07f04f6 Guard streamline update against missing eclipse case 
RimStreamlineInViewCollection::findStartCells() dereferences eclipseCase() unchecked. The collection's case pointer can be null while the view's mainGrid() is valid, e.g. during project load before propagateEclipseCaseToChildObjects().

Return early from updateStreamlines() when the case or its data is missing.

Call stack:
[3] RimEclipseCase::eclipseCaseData() at ResInsight/ApplicationLibCode/ProjectDataModel/RimEclipseCase.cpp:197
[4] RimStreamlineInViewCollection::findStartCells(...) at ResInsight/ApplicationLibCode/ProjectDataModel/Streamlines/RimStreamlineInViewCollection.cpp:394
[5] RimStreamlineInViewCollection::updateStreamlines() at ResInsight/ApplicationLibCode/ProjectDataModel/Streamlines/RimStreamlineInViewCollection.cpp:454
[6] RimEclipseView::onUpdateDisplayModelForCurrentTimeStep() at ResInsight/ApplicationLibCode/ProjectDataModel/RimEclipseView.cpp:932
[7] Rim3dView::updateDisplayModelForCurrentTimeStepAndRedraw() at ResInsight/ApplicationLibCode/ProjectDataModel/Rim3dView.cpp:723
[8] RiuViewer::setCurrentFrame(int) at ResInsight/ApplicationLibCode/UserInterface/RiuViewer.cpp:1059
[9] RimEclipseView::onCreateDisplayModel() at ResInsight/ApplicationLibCode/ProjectDataModel/RimEclipseView.cpp:849
[10] Rim3dView::createDisplayModelAndRedraw() at ResInsight/ApplicationLibCode/ProjectDataModel/Rim3dView.cpp:768
[11] RiaViewRedrawScheduler::updateAndRedrawScheduledViews() at ResInsight/ApplicationLibCode/Application/RiaViewRedrawScheduler.cpp:93
[12] RiaApplication::loadProject(...) at ResInsight/ApplicationLibCode/Application/RiaApplication.cpp:953
 2026-10-12 19:00:45 +02:00
Magne Sjaastad 544e9eedd9 Improve spell checker using codespell 
* Configures automated spell checking with codespell
Adds GitHub workflows and configuration files for automated spell checking using `codespell`.

This includes:
- A workflow for checking pull requests and preventing new typos
- A workflow for automatically fixing typos in the main codebase
- Configuration files for `codespell` to ignore specific terms and file types
- Documentation on how to use and configure the spell checking workflows.

* Corrects minor spelling and grammar errors.
 2025-11-19 10:25:32 +01:00
jonjenssen 540c8c3b36 Use NNC info for well target generation and streamlines (#12279) 
* Add support for NNC when growing clusters
* Trace streamlines through NNCs, too
 2025-03-21 13:00:49 +01:00
jonjenssen da683bed9e Move Rig well related things to subfolder and update include statements 2024-10-31 15:08:59 +01:00
Magne Sjaastad ce513be638 Remove all use of .uiCapability()->setUiTreeHidden( true ); 2024-02-05 10:15:36 +01:00
Kristian Bendiksen 959c9d48fa #10649 ApplicationLibCode: Use collection.empty() instead of comparing with size 2023-09-27 10:16:37 +02:00
Magne Sjaastad 0c90f67dcc Change API for PdmObjectHandle and PdmFieldHandle 
* Refactor interface to PdmObjectHandle and PdmFieldHandle
Return objects instead of passing in structures as parameters

* Add nodiscard to several functions
* Remove redundant this->
* Rename to ptrReferencedObjectsByType
 2023-05-12 21:41:34 +02:00
Jørgen Herje 457dc9080f Refactor classes in RigWellResultPoint.h 
* Move RigWellResultFrame implementation into separate file
Update/correct includes accordingly

* First step of moving attributes from public to private
- Move public members to private and create interface
- Single public member remains due to strong dependency on usage of reference and reference to its object public members

* Second step of moving attributes from public to privatee
- Remove usage of reference directly to attributes. Interface with copy and set.
- Moving attributes in RigWellResultFrame and RigWellResultBranch

* Move class RigWellResultBranch into separate file
 2023-04-14 11:00:45 +02:00
Magne Sjaastadandmagnesj d2f435c00a Improved simulation well visualization 
* Move members to private in RigWellResultPoint
* Create simulation well path geometry using well topology
* Add separate MSW well pipe centerline computations
* Review comments

---------

Co-authored-by: magnesj <magnesj@users.noreply.github.com>
 2023-02-28 16:06:37 +01:00
Magne Sjaastad f8c5cf389f clang-format: Set column width to 140 
* Set column width to 140
* Use c++20
* Remove redundant virtual
 2023-02-26 10:48:40 +01:00
jonjenssen f7dc85ddb6 Avoid recalculating streamlines when a 3d calculation is done. 2022-08-23 01:41:24 +02:00
Magne Sjaastad 6a5b9f7300 Use deleteChildren() when required to avoid memory leak 2022-05-31 15:05:07 +02:00
Magne Sjaastad c74701b687 Rename several child() and children() functions 2022-05-31 15:05:07 +02:00
Magne Sjaastad 3c35244809 #8420 Janitor: Remove empty parameters in initialization macros 2022-01-07 08:31:52 +01:00
Magne Sjaastad 2a65636ba3 #8250 Use variadic macros and remove obsolete parameters 2021-11-14 15:26:09 +01:00
Kristian Bendiksen 75fe73ee64 Refactor: Start using setUiTreeHidden where missing. 2021-10-24 09:11:20 +02:00
Magne Sjaastad 9d58769f89 Janitor : Avoid include of header file in header 2021-05-26 13:28:45 +02:00
Magne Sjaastad 3fca5f15ae Janitor : Use enum class 2021-05-26 13:28:45 +02:00
jonjenssen 1465b179c5 Disable streamlines icon in explorer for eclipse input cases. (#7697) 2021-05-19 18:24:02 +02:00
jonjenssen 766ea6aab2 Streamline improvement (#7435) 
* Use updated generator. Switch to using priority list for seeds. Fix phase reporting and sign issues. Fix step size when growing.
* Reduce memory footprint by simplifying viz. code and filter out unused tracers early
* Remove unused viz. code.
 2021-03-02 01:53:31 +01:00
Magne Sjaastad 916cbb306f Streamlines : Set default max days to 5000 
On large models, the time to compute streamlines can use much memory and be time consuming. Reducing the max number of days will help in some cases.
 2021-02-26 13:47:31 +01:00
Magne Sjaastad bde6fc7d9c Streamlines : Show dominant flow phase velocity 2021-02-26 10:45:30 +01:00
jonjenssenjonjenssenMagne Sjaastad
 		9bd0a9ebac Streamlines: New generator and UI usability improvements (#7424) 
Co-authored-by: jonjenssen <jonjenssen@users.noreply.github.com>
Co-authored-by: Magne Sjaastad <magne.sjaastad@ceetronsolutions.com>
 2021-02-25 16:38:56 +01:00