Commit Graph
120 Commits
Author SHA1 Message Date
JJ 9f17dd81ff Add support for COMPLUMP keyword (#13273)
* Add support for COMPLUMP keyword, both in python interface, file export and opm flow jobs
* Add support for WPIMULT kw in opm flow jobs
* Always provide per connection dFactors in COMPDAT kw (negative value)
* Include LGR support in COMPLUMP file export
2025-12-04 19:25:41 +01:00
Magne Sjaastad a23599cb5d Completion export cleanup
Use MSW as postfix to base name
Drop "Unified" for individual well export
Remove export option Individually/Combined
Remove SPLIT_ON_WELL_AND_COMPLETION_TYPE
2025-12-02 16:03:56 +01:00
Magne Sjaastad 83db509b10 MSW: Make sure extension of custom file name is included 2025-11-25 12:41:20 +01:00
Magne Sjaastad e490d9ef87 Refactors MSW completion data extraction
- redirects export functions to use new MSW extraction code
- removes previous implementation
- fix missing parts of RigMswDataFormatter
2025-11-24 12:47:26 +01:00
Magne Sjaastad 0b74a4accc Removes addOneBasedCellIndex function 2025-11-17 19:45:14 +01:00
Magne Sjaastad 7e299c4841 Add support for more MSW tables in Python
* Use caf::VecIjk0
* Adds MSW tables to the gRPC interface
* Adds unified completion data retrieval
* Add unite tests for MSW data
2025-11-17 11:54:02 +01:00
Magne Sjaastad 9a3b626155 Remove unused parameter 2025-11-14 13:06:32 +01:00
magnesj 562ce12534 Fixes by clang-tidy 2025-11-14 05:52:13 +01:00
Magne Sjaastad ddbef1c7b8 Adds support for all planned MSW tables
* Add test models and projects used to verify experimental MSW export
* Fix text formatting of MSW tables
* Completes porting of all MSW tables

Supported keywords are `WELSEGS COMPSEGS WSEGVALV WSEGAICD`
2025-11-13 14:53:14 +01:00
JJ 6286a34297 Wellplanning: use updated MSW table data api (#13142)
* Update to use new table variable names aligned with opm common naming.
2025-11-07 10:05:53 +01:00
Magne Sjaastad d3cf618f0c Improve MSW variable names
Align MSW variable names with opm-common
2025-11-06 11:39:51 +01:00
Magne Sjaastad fd5bdc96d2 Enables experimental MSW export to new folder
Adds a feature keyword to enable an experimental MSW export
to a separate folder, facilitating testing of a new data
extraction approach.
2025-11-03 13:40:46 +01:00
Magne Sjaastad 88cf84a23a Assign branch number to main branches before completions 2025-11-03 13:40:46 +01:00
Magne Sjaastad ab1f053449 Rename and move Rig files 2025-10-31 08:11:19 +01:00
Magne Sjaastad a88fecdaa4 Adds MSW table data preparation tools
Introduces new classes and functions to prepare MSW table data for export.
2025-10-31 08:11:19 +01:00
Magne Sjaastad 73dd0e0667 Add special handling for TieIn ICVs, and keep default outlet segment for other completion types
* Add special handling for TieIn ICVs, and keep default outlet segment for other completion types(fishbones, fractures, ...)
* Update unit test related to change of tie-in logic
2025-10-27 12:39:22 +01:00
JJ 991e693f4d WELSPECS and COMPDAT export improvements (#13068)
* Generate keywords directly.
* Make sure ensemble settings in duplicated job is reset.
* Use same sort as file export
2025-10-24 11:10:25 +02:00
Magne Sjaastad 901bed8acd #13013 Ensures increasing MD for fishbone laterals
Positions the ICD segment at the end of the fishbone section to ensure that lateral MDs are larger than the ICD segment MDs.

This is required by the simulator and ensures correct flow modeling from laterals into the ICD segment.
2025-10-14 12:51:03 +02:00
JJ d56722782a Well Completion tables - Python interface (#12910) 2025-09-25 12:23:40 +02:00
Kristian Bendiksen b0483172b1 #12718 Add diameter and roughness specification for MD intervals
Implements interval-based diameter and roughness configuration for MSW completions
while maintaining backward compatibility with existing single-value approach.

- Add RimDiameterRoughnessInterval class for individual MD intervals
- Add RimDiameterRoughnessIntervalCollection for managing interval collections
- Extend RimMswCompletionParameters with interval-specific mode support
- Support both metric and field unit systems
- Provide validation and overlap detection for intervals
2025-08-21 08:48:43 +02:00
Magne Sjaastad 91e628da24 #12670 Skip completions with negative or invalid transmissibility 2025-08-05 15:26:46 +02:00
Magne Sjaastad 04dd18389d #12670 Skip completions with negative transmissibility 2025-07-25 15:01:28 +02:00
Magne Sjaastad 37041ad0a6 clang-19-tidy and clang-19-format fixes 2025-05-19 14:31:30 +02:00
Magne Sjaastad ae8446073b Refactors selection handling for improved code clarity
Modernize the interface to selection system. Create and return data instead of populating incoming parameters.
2025-04-09 07:21:54 +02:00
Magne Sjaastad 6b332269b4 Add scripting to fishbones (#12286)
* Improve python code generation tests
* Add setValveLocations
* Move code into RimFishbonesDefines
* Add scripting to fishbones
* Add scripting methods for fishbones
* Add example and test
2025-03-25 08:31:08 +01:00
Kristian Bendiksen afeedb1e22 Janitor: remove unnecessary disabling of clang-format. 2025-03-10 17:58:59 +01:00
Magne Sjaastad 28d3050433 #11871 Remove simulation well fractures and completion export 2025-02-03 18:19:03 +01:00
Magne Sjaastad ca0179d118 Remove obsolete CMake statements
When using modern CMake and Qt6 we can remove obsolete source_group() and QT_MOC_HEADERS
2025-01-28 07:01:42 +01:00
jonjenssen da683bed9e Move Rig well related things to subfolder and update include statements 2024-10-31 15:08:59 +01:00
jonjenssen 88118ee4e1 Privatize grid cell array 2024-10-29 18:17:31 +01:00
Magne Sjaastad df091336e0 Move summary tools into separate folder 2024-10-22 07:28:43 +02:00
Magne Sjaastad a00bfea40b #11663 Make sure non-Darcy data is computed
The computation of non-Darcy properties is expensive, so we cache the results. Make sure that the calling function calls this function before using the properties.
2024-09-05 08:41:06 +02:00
Magne Sjaastad d0b5c8d9cb #11134 Export completions: Call ensureReservoirCaseIsOpen before export
This change will enable export without any open views.
2024-01-30 14:34:33 +01:00
Magne Sjaastad 6922ba22b0 Improve reload and replace of cases
* Move code to from features to helper classes
* Ask user if replace case should also happen for the associated grid or summary file
2024-01-25 10:41:57 +01:00
Magne Sjaastad 68a4d54af2 #10754: Exclude COMPDAT for de-activated laterals 2023-11-13 09:17:30 +01:00
Kristian Bendiksen 8930b5b32d #10728 Fractures: add new conductivity in fracture mode to approximate Reveal behavior 2023-10-18 18:30:18 +02:00
Kristian Bendiksen d177491843 #10648 Refactor summary reader: return std::vector<double> instead of taking ptr. 2023-10-02 09:16:52 +02:00
Kristian Bendiksen 8e5788bb24 Reveal: dump StimPlan XML for debugging thermal completions. 2023-09-25 09:33:37 +02:00
Kristian Bendiksen 1899184a41 Janitor: Remove deprecated method. 2023-09-11 17:39:38 +02:00
Kristian Bendiksen 5bf2c2a89d #10367 Janitor: Remove unneccessary 'this' pointers 2023-08-07 13:38:27 +02:00
Magne Sjaastad 1da509166a Improve CmdFeature base class
Add default implementation of isEnabled() and add const
2023-06-26 14:28:46 +02:00
Magne Sjaastad 59ca0b943c Add readability-simplify-boolean-expr
* Add readability-simplify-boolean-expr
* Fixes based on review
2023-06-26 13:12:41 +02:00
Magne Sjaastad 0c90f67dcc Change API for PdmObjectHandle and PdmFieldHandle
* Refactor interface to PdmObjectHandle and PdmFieldHandle
Return objects instead of passing in structures as parameters

* Add nodiscard to several functions
* Remove redundant this->
* Rename to ptrReferencedObjectsByType
2023-05-12 21:41:34 +02:00
Magne Sjaastad 37e29a0f68 Display all data if multiple fractures crosses a cell
- add the operator<=> for QString
- add operator<=> to fracture report item
2023-05-12 16:23:01 +02:00
Magne Sjaastad 5ee764af48 Refactor result definition 2023-05-11 08:37:58 +02:00
Magne Sjaastad b7f8d0e0f1 Increase warning level
* Set warning level to /W3 for MSVC to catch more warnings
* remove several excluded checks for clang
* removed several unused variables
* Hide warnings qwt
* add missing parentheses in logical expressions
* Remove double check on same logical expression
2023-04-17 15:57:39 +02:00
Magne Sjaastad 6f6dc80bc6 Added more clang-tidy checks
Improved GitHub Action to run clang-format as part of clang-tidy

* Simplify clang-tidy workflow
* Added modernize-use-using, modernize-redundant-void-arg, readability-static-accessed-through-instance
* Add nolint for libecl typedefs
2023-04-14 14:07:45 +02:00
Magne Sjaastad 952e766c2f Update clang-format.yml (#10068)
* Update to clang-format-15
Removed two custom .clang-format files in subfolders of AppFwk

* Fixes by clang-format
2023-04-13 07:05:53 +02:00
Magne Sjaastad 39d011b1e6 #9742 Set default value 1* for KH 2023-03-02 14:16:36 +01:00
Magne Sjaastad f8c5cf389f clang-format: Set column width to 140
* Set column width to 140
* Use c++20
* Remove redundant virtual
2023-02-26 10:48:40 +01:00