Files
ResInsight/ApplicationLibCode/ProjectDataModel
Magne Sjaastad 63eaa1266d Address review feedback on crash-fix batch
- Camera::fitView/computeFitViewEyePosition: derive one corrected, non-parallel up vector and use it consistently for right, upNorm, planeTop and the final setFromLookAt(), instead of only repairing the right vector. Previously the degenerate (parallel dir/up) case still produced a singular view matrix because up itself was never corrected. Added a regression test exercising fitView() end-to-end (not just computeFitViewEyePosition()) that checks the resulting direction/up/right form a valid orthonormal basis.
- RimViewController::updateCameraLink/updateTimeStepLink: guard against ownerViewLinker()->masterView() being null (RimViewLinker::setMasterView(nullptr) is a supported state), not only against a null view linker.
- RicHistogramPlotTools: use RiaGuiApplication::isRunning() before calling RiaGuiApplication::instance(), since instance() itself asserts when there is no running GUI application.
- RimDockWindowController::updateViewerWidget: create the view widget before the dock widget, so a failed view-widget creation does not leave a dock widget allocated without a dock manager (which deleteDockWidget() cannot clean up).
- RimStimPlanModelCalculator::calculateFormation: avoid continue via a small lambda, and reject double values outside the range of int before the static_cast to avoid undefined behavior.
2026-10-05 19:56:10 +02:00
..
2026-09-17 14:03:54 +02:00
2023-05-11 08:37:58 +02:00
2024-11-04 09:54:23 +01:00
2023-06-06 15:45:54 +02:00
2023-04-14 14:07:45 +02:00
2023-04-14 14:07:45 +02:00
2026-06-17 13:55:32 +02:00
2025-01-02 08:06:50 +01:00
2024-11-04 09:54:23 +01:00
2024-03-07 19:45:43 +01:00
2026-09-17 14:03:54 +02:00