mirror of
https://github.com/OPM/ResInsight.git
synced 2026-11-18 03:49:47 -06:00
Four crashes reported from release builds share the same shape: a pointer that is null during teardown or before a view is fully created is dereferenced without a check. RiuViewer::paintOverlayItems() used the owner case of the view and of the comparison view without checking it, and dereferenced the result of a dynamic_cast directly. The owner case is null while a case is being closed. RicIntersectionFeatureImpl::createIntersectionBoxSlize() checked activeMainOrComparisonGridView() but dereferenced activeGridView(), which is a different object and can be null or have no viewer. RimEclipseContourMapView::onCreateDisplayModel() called viewer()->mainCamera() before the viewer exists. RimCorrelationPlotCollection::applyFirstEnsembleFieldAddressesToPlot() called front() on the ensemble parameter vector, which is empty for an ensemble without realization parameters.
61 lines
2.5 KiB
C++
61 lines
2.5 KiB
C++
/////////////////////////////////////////////////////////////////////////////////
|
|
//
|
|
// Copyright (C) 2019- Equinor ASA
|
|
//
|
|
// ResInsight is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// ResInsight is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
// WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
// FITNESS FOR A PARTICULAR PURPOSE.
|
|
//
|
|
// See the GNU General Public License at <http://www.gnu.org/licenses/gpl.html>
|
|
// for more details.
|
|
//
|
|
/////////////////////////////////////////////////////////////////////////////////
|
|
#include "RicIntersectionFeatureImpl.h"
|
|
|
|
#include "RiaApplication.h"
|
|
|
|
#include "RimBoxIntersection.h"
|
|
#include "RimGridView.h"
|
|
#include "RimIntersectionCollection.h"
|
|
|
|
#include "RiuMainWindow.h"
|
|
#include "RiuViewer.h"
|
|
#include "RiuViewerCommands.h"
|
|
|
|
//--------------------------------------------------------------------------------------------------
|
|
///
|
|
//--------------------------------------------------------------------------------------------------
|
|
void RicIntersectionFeatureImpl::createIntersectionBoxSlize( const QString& name, RimBoxIntersection::SinglePlaneState plane )
|
|
{
|
|
RimGridView* activeView = RiaApplication::instance()->activeGridView();
|
|
RimGridView* activeMainOrComparisonView = RiaApplication::instance()->activeMainOrComparisonGridView();
|
|
|
|
// activeGridView() and activeMainOrComparisonGridView() are different objects, both must be checked
|
|
if ( activeMainOrComparisonView && activeView && activeView->viewer() )
|
|
{
|
|
RimIntersectionCollection* coll = activeMainOrComparisonView->intersectionCollection();
|
|
CVF_ASSERT( coll );
|
|
|
|
cvf::Vec3d domainCoord = activeView->viewer()->viewerCommands()->lastPickPositionInDomainCoords();
|
|
|
|
RimBoxIntersection* intersectionBox = new RimBoxIntersection();
|
|
intersectionBox->setName( name );
|
|
|
|
coll->appendIntersectionBoxNoUpdate( intersectionBox );
|
|
intersectionBox->setToDefaultSizeSlice( plane, domainCoord );
|
|
coll->updateConnectedEditors();
|
|
|
|
activeMainOrComparisonView->showGridCells( false );
|
|
activeMainOrComparisonView->scheduleCreateDisplayModelAndRedraw();
|
|
activeView->scheduleCreateDisplayModelAndRedraw();
|
|
|
|
RiuMainWindow::instance()->selectAsCurrentItem( intersectionBox, false );
|
|
RiuMainWindow::instance()->refreshDrawStyleActions();
|
|
}
|
|
}
|