OilfieldToolsNet/opm-common
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Issue warning for operations on empty regions.

Browse Source 
If the user did not set MULTNUM but has e.g.
```
MULTIREG
PORV    0.8     2 /
PORV    0.8     7 /
PORV    0.8   3 /
PORV    0.8   8 /
PORV    1   4 /
PORV    1   9 /
/
```

he at least gets a warning like
```
Warning: MULTNUM region 2 has no active cells when processing operation MULTIREG on keyword PORV.
Please check whether this is on purpose or you missed defining the region properly.
In file /path/to/model/porvmultsny.inc, line 1
```

This should aid him with detecting possible errors.
This commit is contained in:
Markus Blatt
2023-07-05 17:27:04 +02:00
parent 13e4394b45
commit 267e1b07bd
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/opm/input/eclipse/EclipseState/Grid/FieldProps.cpp
View File

@@ -49,6 +49,9 @@
#include <opm/input/eclipse/EclipseState/Aquifer/NumericalAquifer/NumericalAquifers.hpp>
#include <opm/input/eclipse/EclipseState/Tables/TableManager.hpp>
#include <opm/common/OpmLog/OpmLog.hpp>
#include <opm/common/OpmLog/LogUtil.hpp>
#include "Operate.hpp"
@@ -921,6 +924,8 @@ void FieldProps::handle_region_operation(const DeckKeyword& keyword) {
for (const auto& record : keyword) {
const std::string& target_kw = Fieldprops::keywords::get_keyword_from_alias(record.getItem(0).get<std::string>(0));
int region_value = record.getItem("REGION_NUMBER").get<int>(0);
const auto warn_empty_region = R"({} region {} has no active cells when processing operation {} on keyword {}.
Please check whether this is on purpose or you missed defining the region properly.)";
if (this->tran.find(target_kw) != this->tran.end())
throw std::logic_error("The region operations can not be used for manipulations of TRANX, TRANY or TRANZ");
@@ -935,6 +940,11 @@ void FieldProps::handle_region_operation(const DeckKeyword& keyword) {
const auto& src_data = this->init_get<double>(src_kw);
auto& field_data = this->init_get<double>(target_kw);
FieldProps::operate(record, field_data, src_data, index_list);
if (index_list.empty()) {
OpmLog::warning(Log::fileMessage(keyword.location(),
fmt::format(warn_empty_region, region_name, region_value,
keyword.name(), src_kw)));
}
} else {
auto operation = fromString(keyword.name());
const double scalar_value = this->getSIValue(operation, target_kw, record.getItem(1).get<double>(0));
@@ -961,6 +971,11 @@ void FieldProps::handle_region_operation(const DeckKeyword& keyword) {
}
FieldProps::apply(fromString(keyword.name()), field_data.data, field_data.value_status, scalar_value, index_list);
if (index_list.empty()) {
OpmLog::warning(Log::fileMessage(keyword.location(),
fmt::format(warn_empty_region, region_name, region_value, keyword.name(),
target_kw)));
}
}
continue;