Units: add 'Timestep' dimension

the motivation for this is the 'TSTEP' eclipse keyword.

the reason why this dimension is not simply called 'Time' is that in
eclipse, different keywords might use different units, e.g. one
keyword could use seconds, another could use years while a third uses
days. As an added bonus, the used time units may be different for
different scales but identical in others (e.g., for one keyword times
might be specified in 'days' for the metric as well as for the
labscale, but in 'days' and 'hours' for another second keyword.)

opm/parser/eclipse/Units/ConversionFactors.hpp

@@ -54,7 +54,8 @@ namespace Opm {
         const double DissolvedGasRatio = 1.0;
         const double FlowVolume        = 1.0;
         const double Density           = 1.0;
-        const double Viscosity         = 0.001;               // cP -> Pa s
+        const double Viscosity         = 0.001;                // cP -> Pa s
+        const double Timestep          = 24*60*60;             // days -> s
     }
 
 
@@ -68,6 +69,7 @@ namespace Opm {
          const double FlowVolume        = 0.158987294;         // STB -> m^3
          const double Density           = 16.01846;            // lb/ft^3 -> kg / m^3
          const double Viscosity         = 0.001;               // cP -> Pa s
+         const double Timestep          = 24*60*60;            // days -> s
     }
 
 }

opm/parser/eclipse/Units/UnitSystem.cpp

@@ -145,6 +145,7 @@ namespace Opm {
         system->addDimension("FlowVolume", Metric::FlowVolume );
         system->addDimension("Rho"       , Metric::Density );
         system->addDimension("mu"        , Metric::Viscosity);
+        system->addDimension("Timestep"  , Metric::Timestep);
         return system;
     }
 
@@ -163,6 +164,7 @@ namespace Opm {
         system->addDimension("FlowVolume"    , Field::FlowVolume );
         system->addDimension("Rho"  , Field::Density );
         system->addDimension("mu"   , Field::Viscosity);
+        system->addDimension("Timestep", Field::Timestep);
         return system;
     }
 

opm/parser/share/keywords/T/TSTEP

@@ -1 +1,7 @@
-{"name" : "TSTEP" , "size" : 1 , "items" : [{"name" : "step_list" , "value_type" : "FLOAT" , "size_type" : "ALL"}]}
+{"name" : "TSTEP" ,
+ "size" : 1,
+ "items" : [{
+   "name" : "step_list" ,
+   "value_type" : "FLOAT" ,
+   "dimension" : "Timestep",
+   "size_type" : "ALL"}]}