Markus Blatt
87a961246f
Updated copyright.
2023-04-12 16:57:33 +02:00
Markus Blatt
f3767d0f24
Added explicit include of algorithm.
2023-04-12 16:57:11 +02:00
Markus Blatt
e16fd02498
Use deque::assign instead of relying on smart compilers.
2023-04-12 16:50:23 +02:00
Markus Blatt
7187d03f0c
Use stable_sort to keep reverse insertion order for same cell pairs
2023-04-12 16:49:29 +02:00
Markus Blatt
83e05e7ba3
Effort to make the code documentation better.
2023-04-12 16:48:48 +02:00
Markus Blatt
1bb2cbd646
Addressed review comments.
2023-04-12 12:26:39 +02:00
Markus Blatt
9f6122938d
Keep all NNCs when processing EDITNNCR.
...
Those might still be needed to correctly construct the connections
between cells in the grid. Skipping them will produce wrong grids.
2023-04-12 10:22:35 +02:00
Markus Blatt
1ff9100bdc
Fixed NNCTests.
2023-04-12 10:22:35 +02:00
Markus Blatt
5a19bcc4d0
Remove NNC entries that correcpond to EDITNNCR
...
No need to keep those as they will be overwritten anyway.
2023-04-12 10:22:35 +02:00
Markus Blatt
55a0078b3e
Simplify code by keeping track of insertion order of EDITNNCR imlicitly.
...
std::unique will keep the first occurrence and std::sort will keep
the order of equal elements. Hence we use a deque with the EDITNNCR
entries in reverse order (last one specified comes first). The we sort
this and make unique it unique.
2023-04-12 10:22:34 +02:00
Markus Blatt
f2ffebc814
Internalize EDITNNCR and make it available with the NNC information.
...
If there is an EDITNNCR entry and a NNC entry for the same cell pair
then the EDITNNCR entry is not be represented inernally but we simply
overwrite the transmissibility of the corresponding NNC entry.
If there is an EDITNNC entry and an EDITNNCR entry for the same cell
pair then the EDITNNC entry is removed while internalizing EDITNNCR.
Order matters for EDITNNCR entries in the sense that later specified
values will overwrite previous entries when we internalize.
Note that similar to EDITNNC only the first 7 options are represented
and the rest is ignored by OPM flow.
Note that EDITNNCR entries for neighboring cells are ignored (like for
EDITNNC).
2023-04-12 10:22:34 +02:00
Markus Blatt
fb3c2ab5a1
Removed unimplemented declaration of NNC::update_nnc.
2023-04-12 10:22:34 +02:00
Markus Blatt
c24aeceb96
Fixed EDITNNCR specification.
...
Item 7 is of dimension transmissibility.
Also added item numbers to all and comments about being unused where
it seemed appropriate.
2023-04-12 10:22:34 +02:00
Markus Blatt
24d25f7be7
Merge pull request #3384 from plgbrts/well-traj
...
Grid independent well specification
2023-04-10 07:40:08 +02:00
Paul Egberts
694bb016a7
Two more small fixes
2023-04-05 15:58:17 +02:00
Paul Egberts
e781a99ce4
update of license to only gplv3
2023-04-04 22:02:18 +02:00
Paul Egberts
a6d39275c7
code improvements following suggestions of Markus
2023-04-04 21:49:03 +02:00
Markus Blatt
df4c92a8d7
Merge pull request #3461 from blattms/MINPVFIL
...
Minpvfi
2023-04-03 17:45:46 +02:00
Markus Blatt
9d995a40e3
Fix ConstructorMINPV.
...
Exception is now already thrown in createMinpvDefaultCPDeck.
2023-04-03 17:41:22 +02:00
OPMUSER
699f7ad695
Update ConstructorMINPV Test
...
Update ConstructorMINPV Test for MINPV/MINPORV
2023-04-03 16:37:33 +02:00
OPMUSER
f99e7dbc29
Update keyword_list.cmake
...
Remove MINPVFIL from keyword_list.cmake.
2023-04-03 16:37:33 +02:00
OPMUSER
1fac541b6e
Remove MINPVFIL - WIP
...
MINPVFIL is an OPM Flow specific keyword that is not used by the simulator, and thus it should be deleted.
Previously, we moved the checks that only allow either the MINPV or MINPORV keywords to be used in the input deck to the JSON keyword files. This was done to avoid confusion over which global limits are being applied.
Note that if the MINPVV keyword is also in the input deck then these limits are applied post processing the global limits defined by the MINPV/MINPORV keywords. This behavior is unchanged by this PR.
The PR is marked as WIP to give developers time to object for the removal of MINPVFIL keyword.
2023-04-03 16:37:33 +02:00
Bård Skaflestad
00089a888b
Merge pull request #3460 from GitPaean/const_waterReferceDensity
...
add const for WaterPvtMultiplexer::waterReferenceDensity(unsigned)
2023-04-03 16:00:45 +02:00
Kai Bao
548881395e
add const for WaterPvtMultiplexer::waterReferenceDensity(unsigned)
2023-04-03 12:59:43 +02:00
Paul Egberts
7c05ccc553
Merge branch 'well-traj' of https://github.com/blattms/opm-common into well-traj-markus
...
Use Markus' rebased version
2023-04-03 12:11:47 +02:00
Bård Skaflestad
200b6a2cbc
Merge pull request #3456 from blattms/support-pinch-maxgap
...
EclipseGrid: make option 3 (MAX_EMPTY_GAP) of PINCH available
2023-03-30 15:18:01 +02:00
Markus Blatt
3706aae429
Fixed default initialization of EclipseGrid.
2023-03-30 14:03:01 +02:00
Paul Egberts
22a7a81597
Removal of unused files
2023-03-29 17:24:13 +02:00
Paul Egberts
7b0156f6cc
Placed ResInsight code in separate namespace called external
2023-03-29 17:24:13 +02:00
Paul Egberts
b9012d85a3
removal of unused files
2023-03-29 17:24:13 +02:00
Paul Egberts
367ffb1aa2
added missing *.inl files to make file
2023-03-29 17:24:13 +02:00
Paul Egberts
d0fc099d75
explicit listing of header files, removed globbing
2023-03-29 17:24:11 +02:00
Paul Egberts
1d07b6ad9f
attempt to fix build error
2023-03-29 17:23:21 +02:00
Paul Egberts
e7e1411146
added resinsight include files in cmake file part 2
2023-03-29 17:23:21 +02:00
Paul Egberts
7ebfb0b86f
added resinsight include files in cmake file
2023-03-29 17:23:21 +02:00
Paul Egberts
98f41e2e2e
cmake file fix
2023-03-29 17:23:21 +02:00
Paul Egberts
160c5bee10
added #include <string>
2023-03-29 17:23:21 +02:00
Paul Egberts
8091ea73ae
repairing cmake file
2023-03-29 17:23:14 +02:00
Paul Egberts
e7ae500032
added test for calculation of CFs and IJK coordinates of intersected cells
2023-03-29 17:20:57 +02:00
Paul Egberts
3ba31d4304
finalizing and cleaning up
2023-03-29 17:20:54 +02:00
Paul Egberts
46f412e60a
Processing WELTRAJ/COMPTRAJ; Calculation of intersected cells and CFs
2023-03-29 17:05:39 +02:00
Paul Egberts
88e58ba5d2
finalizing keywords COMPTRAJ and WELTRAJ
2023-03-29 17:05:39 +02:00
Paul Egberts
067e645e22
This is a combination of 5 commits.
...
Reorganizing and renaming files
2023-03-29 17:05:39 +02:00
Paul Egberts
5c9a59644f
well trajectory calculation (re)using resinsight code
2023-03-29 17:05:37 +02:00
Paul Egberts
532b626e56
try out code
2023-03-29 17:03:56 +02:00
Paul Egberts
65eff452e3
reading new tables for grid independent well specification
2023-03-29 17:03:56 +02:00
Bård Skaflestad
0be5bee7c4
Merge pull request #3457 from totto82/addThermalBC
...
add THERMAL option to BC
2023-03-29 14:07:45 +02:00
Bård Skaflestad
cbb808b579
Merge pull request #3455 from totto82/diffc_co2store
...
Support DIFFCGAS and DIFFCWAT for the CO2STORE module
2023-03-29 13:41:40 +02:00
Tor Harald Sandve
b8ee8d8652
Merge pull request #3451 from totto82/gaswater_hyst
...
Enable hysteresis in water gas 2p model
2023-03-28 15:48:59 +02:00
Markus Blatt
ea64c29001
Added missing forward declaration to make TransMult.hpp usable standalone.
2023-03-28 15:40:21 +02:00